fix: audio segment on incorrect timeline HLS#1539
Merged
wseymour15 merged 1 commit intomainfrom Sep 11, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
==========================================
- Coverage 86.36% 86.36% -0.01%
==========================================
Files 43 43
Lines 11149 11148 -1
Branches 2546 2545 -1
==========================================
- Hits 9629 9628 -1
Misses 1520 1520 ☔ View full report in Codecov by Sentry. |
dzianis-dashkevich
approved these changes
Sep 11, 2024
adrums86
approved these changes
Sep 11, 2024
wseymour15
added a commit
that referenced
this pull request
Sep 11, 2024
This reverts commit e4e0c2d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related to #1530
This fixes an issue that was previously thought to just happen in DASH above. Now, in HLS, if the audio segment in on a previous timeline to the video segment, we will push playback to where they are both on the same timeline.
Specific Changes proposed
Requirements Checklist