Conversation
650f0ed to
2ef3c6a
Compare
This comment has been minimized.
This comment has been minimized.
|
Have you seen the updated description of #1259? While the tests run much faster now, it's still wasteful to run long builds for commits that didn't change any code. |
|
IMHO, Travis currently takes 15 minutes to run the whole thing, which isn't that long. It's not an ideal allocation of compute resources, but I don't see the harm - a few extra occurrences of 15 minute builds isn't going to really impact global warming, and since the builders are free, it's not going to break the bank either :) Plus, if you run full tests for each PR, you always know the full tests pass. If you get "fancy" and try to run a subset, it's possible to make a mistake and not run a test that should have been run due an error in the test harness. I think KISS is the way to go. In this PR, the tests also fast fail (that's due to the |
|
Ok, let's do it for now. If we want to improve this in the future, here are some links: This example is enough to get an idea. Click here to see more links.
This is the upstream issue: travis-ci/travis-ci#6301. One thing I currently don't like is that Docker images are re-built every time – looks like the layer caching is missing. This is not only inefficient but also produces a lot of noise in Travis logs. I'm not sure how Docker caches this but if this could be added to |
|
Overall, it's awesome to see the test passing on a CI! 🤖 |
2ef3c6a to
40b44c8
Compare
|
Thanks for the changes, I'll take a look shortly. I'd just like to ask for "normal commits" in the future, not force-pushes. For example, the Also, the We prefer multiple smaller commits, some of them heavy WIP, over "clean" (but fake) history. |
40b44c8 to
f76cad6
Compare
No problem - different projects have different requirements, and I've recently been working on ones that use a different model :) |
|
Thank you, it's not documented very well right now, our fault ;) |

Issue: #1259
Travis will now run markdownlint, PHP CodeSniffer, build the Docker images and run the full tests.
With this change, VersionPress can now only merge PRs that have passing tests, ensuring that all tests always pass.
Note that the Docker caching is not part of this PR and should be done separately, see #1419.