Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

Run tests in Travis#1381

Merged
borekb merged 3 commits intoversionpress:masterfrom
candrews:tests-in-travis
Mar 4, 2019
Merged

Run tests in Travis#1381
borekb merged 3 commits intoversionpress:masterfrom
candrews:tests-in-travis

Conversation

@candrews
Copy link
Copy Markdown
Contributor

@candrews candrews commented Mar 4, 2019 •
edited by borekb
Loading

UPDATE: this has been reverted in #1394

Issue: #1259

Have Travis run all tests:

  • npm run lint:markdown
  • npm run build-images
  • npm run tests:full
  • ( cd plugins/versionpress && ./vendor/bin/phpcs --standard=ruleset.xml )

With this improvement, tests are automatically run so no one has to manually do so. Tests are also run for all branches and PRs allowing for test passage to be a quality gate.

candrews added 3 commits March 4, 2019 11:42
@candrews
Remove GH access token
adab902 
The GH access token can be leaked by malicious PRs

Undoes aa69729
@candrews
Run Travis for all, not just master + PRs
97a0765 
Undoes 64922d6
@candrews
Have Travis run tests
4860cbb
@candrews
Copy link
Copy Markdown
Contributor Author

candrews commented Mar 4, 2019

Note that tests currently fail; #1376 #1379 #1380 all work towards making these tests pass.

@borekb
Copy link
Copy Markdown
Member

borekb commented Mar 4, 2019 •
edited
Loading

This is awesome! ❤️

I'm inclined to merge this before the tests pass, do you agree?

@candrews
Copy link
Copy Markdown
Contributor Author

candrews commented Mar 4, 2019

Absolutely!

@borekb borekb merged commit b14fe01 into versionpress:master Mar 4, 2019
@borekb borekb added the noteworthy Significant issue or PR, to be highlighted in release notes label Mar 4, 2019
@borekb borekb added this to the 4.0 milestone Mar 4, 2019
@borekb borekb mentioned this pull request Mar 4, 2019
Closed
3 tasks
@borekb
Copy link
Copy Markdown
Member

borekb commented Mar 6, 2019

I wonder if it's useful to run build-images on Travis, what do you think @candrews?

@candrews
Copy link
Copy Markdown
Contributor Author

candrews commented Mar 6, 2019

I wonder if it's useful to run build-images on Travis

I think it is.

If Travis doesn't build the images, then Travis can't test changes to the images. For example, if you modify a Dockerfile, and Travis isn't building images, then Travis won't be able to run tests with that change in place. This means docker changes can only be tested locally or after the image is pushed.

@borekb
Copy link
Copy Markdown
Member

borekb commented Mar 6, 2019

👍, you're right. It's a bit wasteful most of the time but we could add something like this in the future.

@borekb borekb mentioned this pull request Mar 9, 2019
Merged
@candrews candrews mentioned this pull request Mar 26, 2019
Merged
@borekb borekb removed the noteworthy Significant issue or PR, to be highlighted in release notes label Mar 26, 2019
@borekb borekb added scope: dev-infrastructure Build scripts, IDE settings, CI, Docker dev stack, testing, tooling, etc. scope: tests Testing code. For infrastructure (CI, etc.), use "dev-infrastructure". labels Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@candrews candrews

Labels

scope: dev-infrastructure Build scripts, IDE settings, CI, Docker dev stack, testing, tooling, etc. scope: tests Testing code. For infrastructure (CI, etc.), use "dev-infrastructure".

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@candrews @borekb