Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

Fixing tests & code before 4.0-beta#1272

Merged
borekb merged 9 commits intomasterfrom
1257-fix-tests
Jul 7, 2017
Merged

Fixing tests & code before 4.0-beta#1272
borekb merged 9 commits intomasterfrom
1257-fix-tests

Conversation

@borekb
Copy link
Copy Markdown
Member

@borekb borekb commented Jul 7, 2017

Ref: #1257

Summary:

  • Fixed some bugs in the production code (unit tests were correctly failing for me).
  • Fixed a couple of tests.
  • Moved SqlQueryParserTest to unit tests.
  • WpConfigEditor received a small cleanup and doc update.
  • Some obsolete utils like WpAutomationRunner.sample.php or testing Gulp tasks were removed.
  • The tests folder now has a README pointing to Dev-Setup#testing.
  • Dockerfiles versioning to avoid surprises with stale images.
  • Cleaned up testing docker-compose.yml
  • Improved testing instructions in Dev-Setup.md.

After this PR, all test groups (Unit, End2End, Worklow, ...) pass when run separately. Two most obvious issues are now:

  1. Tests fail when run together, there is probably some interference.
  2. End2end tests take vary long to initialize (6 minutes on my PC). This is proportional to how many tests are actually going to be run and feels like a new bug to me; I don't remember test initialization being that slow on local setup.

@borekb borekb added this to the 4.0 milestone Jul 7, 2017
@borekb borekb self-assigned this Jul 7, 2017
@borekb borekb requested a review from JanVoracek July 7, 2017 08:03
@borekb borekb merged commit 07c0426 into master Jul 7, 2017
@borekb borekb deleted the 1257-fix-tests branch July 7, 2017 08:21
@borekb borekb added the scope: tests Testing code. For infrastructure (CI, etc.), use "dev-infrastructure". label Jul 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scope: tests Testing code. For infrastructure (CI, etc.), use "dev-infrastructure".

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants