This repository was archived by the owner on Jul 28, 2024. It is now read-only.
Filterable action priorities, WPLANG handling#1228
Merged
JanVoracek merged 4 commits intomasterfrom May 29, 2017
Merged
Conversation
borekb
reviewed
May 28, 2017
Member
borekb
left a comment
There was a problem hiding this comment.
Filterable priorities, nice! Two comments:
- Could we pass the whole entity to the filter, not just ID? Would be more flexible IMO.
- This filtering should be mentioned in
Plugin-Support.md.
…to it and checking empty value
Contributor
Author
|
@borekb I've changed the implementation. Can you review it now? |
borekb
approved these changes
May 29, 2017
borekb
added a commit
that referenced
this pull request
Jul 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1226 (WPLANG)
Resolves #1232 (dynamic action priorities)
There is a new filter called
vp_action_priority_{$scope}by which we can dynamically change the priority.