Skip to content
This repository was archived by the owner on Jul 28, 2024. It is now read-only.

1213 frontend dependencies and other updates#1214

Merged
borekb merged 10 commits intomasterfrom
1213-dev-update
May 20, 2017
Merged

1213 frontend dependencies and other updates#1214
borekb merged 10 commits intomasterfrom
1213-dev-update

Conversation

@borekb
Copy link
Copy Markdown
Member

@borekb borekb commented May 13, 2017 •
edited
Loading

Part of #1213

This updates the frontend project:

  • Webpack 1.13 -> 2.5
  • TypeScript 2.0 -> 2.3, only a couple of places needed fixes
  • npm -> Yarn in package.json scripts, lock file committed
  • JS files in src gitignored
  • TSLint v3 -> 5, rules updated
  • Gulpfile removed, the only task was tslint which has been replaced by a package.json script.
  • Review dependencies in package.json, some are probably obsolete
  • Have a look at tests, whether the scripts are still valid etc.

borekb added 2 commits May 13, 2017 10:23
@borekb
[#1213] Frontend README update
245dd92
@borekb
[#1213] Major update to frontend dependencies (Webpack 1.x->2.x etc.)…
bc8a2c3 
…. WIP: everything compiles but the project does not work in a browser yet.

- Webpack 1.13 -> 2.5. It bundles JS and CSS fine but the browser currently doesn't display anything; this will need fixing yet.
- TypeScript 2.0 -> 2.3, only a couple of places needed fixes.
- npm -> Yarn in package.json scripts, lock file committed.
- JS files in `src` gitignored.
- TSLint updated but currently shows many errors (the rule format changed and rules themselves are not updated yet).
- Gulpfile removed, the only task was `tslint` which has been replaced by a package.json script.
@borekb borekb added this to the 4.0 milestone May 13, 2017
@borekb borekb self-assigned this May 13, 2017
@borekb borekb requested review from Ishirak and vasek May 20, 2017 00:05
@borekb
Copy link
Copy Markdown
Member Author

borekb commented May 20, 2017

@vasek17 @Ishirak Are you guys happy with the TSLint rules in 48c2b07 ? I've taken them from the user-portal client project and adapted to fit this project. I've run TSLint on the codebase and made suggested fixes.

@borekb borekb changed the title 1213 update of dependencies and dev-setup 1213 frontend dependencies and other updates May 20, 2017
@borekb borekb removed request for Ishirak and vasek May 20, 2017 17:15
@borekb borekb merged commit 2d07db8 into master May 20, 2017
@borekb borekb deleted the 1213-dev-update branch May 20, 2017 17:15
@borekb borekb mentioned this pull request May 20, 2017
Closed
7 tasks
@borekb borekb mentioned this pull request Jun 20, 2017
Merged
28 tasks
borekb added a commit that referenced this pull request Jul 3, 2017
@borekb
Frontend project switched back from yarn to npm (reverts parts of #1214…
8320dec 
…, npm@5 is now good enough)
borekb added a commit that referenced this pull request Jul 3, 2017
@borekb
Fixed TypeScript error, this must have been broken since #1214 but I …
d72045a 
…don't understand how it could have passed back then
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@borekb borekb

Labels

None yet

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

2 participants

@borekb @Ishirak