[remix] Fix module file path resolution#9248
Closed
smaeda-ks wants to merge 2 commits intovercel:mainfrom
Closed
Conversation
TooTallNate
approved these changes
Jan 18, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
Jan 18, 2023
Follow-up to #8793, which breaks dynamic import of the config file, causing some issues for remix users: https://github.com/orgs/vercel/discussions/1282 The underlying error is `MODULE_NOT_FOUND`. `import()` should work with `file://` URIs, however, since it's using typescript, the `import` gets compiled to `require()`, which does not support `file://` protocol scheme. Supersedes #9248.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was introduced in: #8793
and causing some issues for remix users: https://github.com/orgs/vercel/discussions/1282
The underlying error is
MODULE_NOT_FOUND.import()should work withfile://URIs, however, since it's using typescript, theimportgets compiled torequire(), which does not supportfile://protocol scheme.