Skip to content

Revert "[functions] URL encode cache tags"#15213

Merged
styfle merged 2 commits intomainfrom
revert-14749-kd/01-27-_functions_url_encode_cache_tags
Feb 24, 2026
Merged

Revert "[functions] URL encode cache tags"#15213
styfle merged 2 commits intomainfrom
revert-14749-kd/01-27-_functions_url_encode_cache_tags

Conversation

@styfle
Copy link
Copy Markdown
Member

@styfle styfle commented Feb 23, 2026

Reverts #14749 since this caused a regression when using : and other characters in tags.

The expected behavior is that commas split into multiple tags.

Warning

High Risk Change

Revert removes URL encoding of cache tags, which could allow special characters like commas to be interpreted as tag delimiters, potentially affecting cache invalidation behavior.

  • Removes encodeURIComponent from cache tags in set() and expireTag()
  • Tags with special characters (commas, spaces, ampersands) now passed through unencoded
  • Removes associated URL encoding tests

Risk assessment for commit 83d1d76.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 23, 2026

📦 CLI Tarball Ready

The Vercel CLI tarball for this PR is now available!

Quick Test

You can test this PR's CLI directly by running:

npx https://vercel-9xzxzc912.vercel.sh/tarballs/vercel.tgz --help

Use in vercel.json

To use this CLI version in your project builds, add to your vercel.json:

{
  "build": {
    "env": {
      "VERCEL_CLI_VERSION": "vercel@https://vercel-9xzxzc912.vercel.sh/tarballs/vercel.tgz"
    }
  }
}

Python Runtime Wheel

A Python runtime wheel was also built for this PR.
To use in your Python project builds, also set this environment variable:

VERCEL_RUNTIME_PYTHON="vercel-runtime @ https://vercel-9xzxzc912.vercel.sh/tarballs/vercel_runtime-0.6.0.dev1771881674+83d1d76-py3-none-any.whl"

Copy link
Copy Markdown
Contributor

@kldavis4 kldavis4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need a changeset

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 23, 2026

🧪 Unit Test Strategy

Comparing: 8244a9683d1d76 (view diff)

Strategy: Affected packages only

✅ Only testing packages that have been modified or depend on modified packages.

Affected packages - 11 (28%)
  1. @vercel/edge
  2. @vercel/elysia
  3. @vercel/express
  4. @vercel/fastify
  5. @vercel/functions
  6. @vercel/h3
  7. @vercel/hono
  8. @vercel/koa
  9. @vercel/nestjs
  10. @vercel/node
  11. vercel
Unaffected packages - 29 (73%)
  1. @vercel-internals/get-package-json
  2. @vercel/backends
  3. @vercel/build-utils
  4. @vercel/cervel
  5. @vercel/cli-auth
  6. @vercel/client
  7. @vercel/config
  8. @vercel/detect-agent
  9. @vercel/error-utils
  10. @vercel/firewall
  11. @vercel/frameworks
  12. @vercel/fs-detectors
  13. @vercel/gatsby-plugin-vercel-builder
  14. @vercel/go
  15. @vercel/hydrogen
  16. @vercel/next
  17. @vercel/oidc
  18. @vercel/oidc-aws-credentials-provider
  19. @vercel/python
  20. @vercel/python-analysis
  21. @vercel/redwood
  22. @vercel/related-projects
  23. @vercel/remix-builder
  24. @vercel/routing-utils
  25. @vercel/ruby
  26. @vercel/rust
  27. @vercel/static-build
  28. @vercel/static-config
  29. examples

Results

  • Unit tests: Only affected packages will run unit tests
  • E2E tests: Running in parallel via E2E Tests workflow
  • Type checks: Only affected packages will run type checks

This comment is automatically generated based on the affected testing strategy

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Feb 23, 2026

🦋 Changeset detected

Latest commit: 83d1d76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@vercel/functions Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kldavis4
Copy link
Copy Markdown
Contributor

@QuiiBz here is the relevant thread for the original PR that this is reverting: https://vercel.slack.com/archives/C02K2HCH5V4/p1769213460081909

We discussed today and came to the conclusion that this was the wrong change and we should not support commas in tags.

@styfle styfle enabled auto-merge (squash) February 23, 2026 22:45
@styfle styfle merged commit feafcb7 into main Feb 24, 2026
181 checks passed
@styfle styfle deleted the revert-14749-kd/01-27-_functions_url_encode_cache_tags branch February 24, 2026 08:31
styfle pushed a commit that referenced this pull request Feb 24, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@50.23.0

### Minor Changes

- [dev] allow to skip authentication and project linking for `vc dev` by
setting `VERCEL_EXPERIMENTAL_DEV_SKIP_LINK` env var.
([#15122](#15122))

- [services] detect project root to prevent accidental setup of a
service as a standalone project.
([#15187](#15187))

### Patch Changes

- Fix re-authentication for teams with missing scope to use the device
code flow instead of the deprecated SSO redirect flow.
([#15074](#15074))

- Add CLI eval for vc env command
([#15118](#15118))

-   Updated dependencies \[]:
    -   @vercel/node@5.6.7

## @vercel/functions@3.4.3

### Patch Changes

- [functions] Revert "[functions] URL encode cache tags"
([#15213](#15213))


<!-- VADE_RISK_START -->
> [!NOTE]
> Low Risk Change
>
> This PR contains only version bumps and changelog updates from the
Changesets release automation, with no actual code changes.
> 
> - Deletes changeset markdown files consumed during release
> - Updates version numbers in package.json files (50.22.3→50.23.0,
3.4.2→3.4.3)
> - Adds changelog entries documenting previously merged changes
>
> <sup>Risk assessment for [commit
18f0132](https://github.com/vercel/vercel/commit/18f013287efb10cb34e666236f9e34f0c72d0c83).</sup>
<!-- VADE_RISK_END -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants