Summary

• Fix API contract mismatch: CLI sent { items: [{...}] } but batch threshold API expects bare JSON array [{...}]. Installation-level threshold creation was completely broken.
• Changed return type from { store: { id: string } } to void (API returns 204 No Content)
• Fix help text example 100 50 2000 → 50 100 2000 (old example violated minimum <= spend validation)
• Fix spend and limit parsing: parseInt → parseFloat (was silently truncating decimals)
• Add Math.round after parseFloat * 100 to prevent floating point precision issues
• Fix "resource not found" exit code: return 0 → return 1
• Fix error message: said "Spend" when validating Minimum
• Fix balance mapping: threshold key used resourceName instead of resourceId

Before / After

1. API request body (critical fix)

The batch threshold endpoint expects a bare JSON array. The CLI was wrapping it in { items: [...] }, causing all installation-level threshold creation to fail.

Before — what the CLI sent:

POST /v1/integrations/installations/:id/billing/threshold/batch

{
  "items": [
    {
      "billingPlanId": "plan_123",
      "minimumAmountInCents": 5000,
      "purchaseAmountInCents": 10000,
      "maximumAmountPerPeriodInCents": 200000,
      "metadata": "{}"
    }
  ]
}

After — correct format:

POST /v1/integrations/installations/:id/billing/threshold/batch

[
  {
    "billingPlanId": "plan_123",
    "minimumAmountInCents": 5000,
    "purchaseAmountInCents": 10000,
    "maximumAmountPerPeriodInCents": 200000,
    "metadata": "{}"
  }
]

2. Decimal parsing

Before — parseInt silently truncated decimals:

$ vercel ir create-threshold my-resource 10.10 20.50 100.99
# minimum = parseInt("10.10") * 100 = 10 * 100 = 1000 ($10.00, not $10.10)
# spend   = parseInt("20.50") * 100 = 20 * 100 = 2000 ($20.00, not $20.50)
# limit   = parseInt("100.99") * 100 = 100 * 100 = 10000 ($100.00, not $100.99)

After — parseFloat + Math.round gives correct cents:

$ vercel ir create-threshold my-resource 10.10 20.50 100.99
# minimum = Math.round(parseFloat("10.10") * 100) = Math.round(1010.0000...01) = 1010 ($10.10 ✓)
# spend   = Math.round(parseFloat("20.50") * 100) = Math.round(2050.0) = 2050 ($20.50 ✓)
# limit   = Math.round(parseFloat("100.99") * 100) = Math.round(10099.0) = 10099 ($100.99 ✓)

3. Help text example

Before — violated minimum <= spend validation (100 > 50):

vercel integration-resource create-threshold my-acme-resource 100 50 2000
# → Error: Minimum cannot be greater than spend.

After — valid example:

vercel integration-resource create-threshold my-acme-resource 50 100 2000
# minimum=$50, spend=$100, limit=$2000 ✓

4. Resource not found exit code

Before:

$ vercel ir create-threshold nonexistent 50 100 2000
> The resource nonexistent was not found.    # output.log (no "Error:" prefix)
$ echo $?
0    # success?!

After:

$ vercel ir create-threshold nonexistent 50 100 2000
Error: The resource nonexistent was not found.    # output.error
$ echo $?
1    # correct failure exit code

5. Error message copy

Before:

$ vercel ir create-threshold my-resource abc 100 2000
Error: Minimum is an invalid number format. Spend must be a positive number (ex. "5.75")
#                                           ^^^^^ wrong field name

After:

$ vercel ir create-threshold my-resource abc 100 2000
Error: Minimum is an invalid number format. Minimum must be a positive number (ex. "5.75")
#                                           ^^^^^^^ correct

6. Balance mapping key collision

When merging thresholds into the balance mapping, the else branch keyed by display name (resourceName) instead of resourceId. This caused lookups to fail when iterating the map.

Before:

// threshold for resourceId="res_abc" with display name "my-db"
mappings["my-db"] = { threshold, resourceName: "my-db" };
// but balance was stored under mappings["res_abc"]
// → threshold never merged with its balance

After:

// both balance and threshold keyed by resourceId
mappings["res_abc"] = { threshold, resourceName: "my-db" };
// → threshold correctly merges with balance entry

Test plan

Unit Tests

$ cd packages/cli && pnpm vitest run test/unit/commands/integration-resource/create-threshold.test.ts test/unit/commands/integration/balance.test.ts

 ✓ test/unit/commands/integration/balance.test.ts  (14 tests) 74ms
 ✓ test/unit/commands/integration-resource/create-threshold.test.ts  (29 tests) 112ms

 Test Files  2 passed (2)
      Tests  43 passed (43)

Test updates:

• Fixed create-threshold.test.ts: exit code assertion 0 → 1 for "resource not found"
• Fixed create-threshold.test.ts: error message assertion "Spend must be" → "Minimum must be"
• Added test: batch endpoint body is a bare JSON array (not { items: [...] })
• Added test: Math.round produces exact cents for floats like 5.75 → 575

Manual Testing

Code paths covered

Not manually testable (no prepayment integrations on test team): actual threshold creation via batch endpoint, balance display with real prepayment data. Covered by unit tests with mocks.

🤖 Generated with Claude Code