Skip to content

[cli] Fix flakey link --repo test caused by Inquirer type-ahead#14716

Merged
tknickman merged 3 commits intomainfrom
tknickman/fix-flakey-test
Jan 23, 2026
Merged

[cli] Fix flakey link --repo test caused by Inquirer type-ahead#14716
tknickman merged 3 commits intomainfrom
tknickman/fix-flakey-test

Conversation

@tknickman
Copy link
Copy Markdown
Member

Summary

  • Fixes intermittent test failure in link > --repo > should create projects using subdirectory names for monorepo workspaces
  • Root cause: Sending y\n to confirm prompts triggered Inquirer's type-ahead search, causing wrong selection when team names started with 'Y'
  • Fix: Use \n alone since the desired option is already selected by default

Details

The test was flaky because the mock data uses chance() to generate random team names. When a team name happened to start with 'Y' (like "Yellow Corporation"), the y keystroke in y\n triggered Inquirer's type-ahead search feature, jumping to that option instead of keeping the user selected. The subsequent \n would then confirm the wrong selection.

Expected: "Linked to 2 Projects under francis (created .vercel...)"
Actual: "Linked to 2 Projects under p*num (created .vercel...)" (team name instead of username)

Test plan

  • Run pnpm vitest run test/unit/commands/link/index.test.ts - all 22 tests pass
  • Specifically verified the previously flakey test passes

🤖 Generated with Claude Code

The test "should create projects using subdirectory names for monorepo
workspaces" was failing intermittently because sending 'y\n' to confirm
scope selection triggered Inquirer's type-ahead search feature.

When a randomly-generated team name started with 'Y' (like "Yellow
Corporation"), the 'y' keystroke would jump to that option, then '\n'
would confirm the wrong selection.

Fix: Use '\n' alone for scope selection and checkbox prompts since the
desired option is already selected by default.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@tknickman tknickman requested a review from a team as a code owner January 23, 2026 21:03
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Jan 23, 2026

🦋 Changeset detected

Latest commit: 954e546

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

📦 CLI Tarball Ready

The Vercel CLI tarball for this PR is now available!

Quick Test

You can test this PR's CLI directly by running:

npx https://vercel-fi911fahv.vercel.sh/tarballs/vercel.tgz --help

Use in vercel.json

To use this CLI version in your project builds, add to your vercel.json:

{
  "build": {
    "env": {
      "VERCEL_CLI_VERSION": "vercel@https://vercel-fi911fahv.vercel.sh/tarballs/vercel.tgz"
    }
  }
}

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2026

🧪 Unit Test Strategy

Comparing: 3a1ea3f954e546 (view diff)

Strategy: Affected packages only

✅ Only testing packages that have been modified or depend on modified packages.

Affected packages - 1 (2%)
  1. vercel
Unaffected packages - 40 (98%)
  1. @vercel-internals/get-package-json
  2. @vercel/backends
  3. @vercel/build-utils
  4. @vercel/cervel
  5. @vercel/cli-auth
  6. @vercel/client
  7. @vercel/config
  8. @vercel/detect-agent
  9. @vercel/edge
  10. @vercel/elysia
  11. @vercel/error-utils
  12. @vercel/express
  13. @vercel/fastify
  14. @vercel/firewall
  15. @vercel/frameworks
  16. @vercel/fs-detectors
  17. @vercel/functions
  18. @vercel/gatsby-plugin-vercel-builder
  19. @vercel/go
  20. @vercel/h3
  21. @vercel/hono
  22. @vercel/hydrogen
  23. @vercel/introspection
  24. @vercel/koa
  25. @vercel/nestjs
  26. @vercel/next
  27. @vercel/node
  28. @vercel/oidc
  29. @vercel/oidc-aws-credentials-provider
  30. @vercel/python
  31. @vercel/python-analysis
  32. @vercel/redwood
  33. @vercel/related-projects
  34. @vercel/remix-builder
  35. @vercel/routing-utils
  36. @vercel/ruby
  37. @vercel/rust
  38. @vercel/static-build
  39. @vercel/static-config
  40. examples

Results

  • Unit tests: Only affected packages will run unit tests
  • E2E tests: Handled separately (Version Packages PRs or run-e2e-tests label)
  • Type checks: Only affected packages will run type checks

This comment is automatically generated based on the affected testing strategy

Apply the same fix to all scope selection prompts in the link tests,
including the non-repo tests that use "Which scope should contain your
project?" (singular form).

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@tknickman tknickman merged commit 6888a3e into main Jan 23, 2026
120 checks passed
@tknickman tknickman deleted the tknickman/fix-flakey-test branch January 23, 2026 21:38
tknickman pushed a commit that referenced this pull request Jan 23, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@50.5.0

### Minor Changes

- New, consistent --format command for machine readable output
([#14609](#14609))

-   api command ([#14715](#14715))

- Detect Augment and OpenCode agents
([#14635](#14635))

### Patch Changes

- Track CLI as source for marketplace integration installations
([#14713](#14713))

- Do not show default project settings when framework is detected
([#14608](#14608))

- Fix flakey link tests caused by Inquirer type-ahead search
([#14716](#14716))

- Updated dependencies
\[[`64b4577b6d702335478af47c8395bf36daf4f311`](64b4577),
[`1ba97e3af1c1240703df3297fbbf7af0f809dd56`](1ba97e3)]:
    -   @vercel/python@6.3.1
    -   @vercel/detect-agent@1.1.0

## @vercel/detect-agent@1.1.0

### Minor Changes

- Detect Augment and OpenCode agents
([#14635](#14635))

## @vercel/python@6.3.1

### Patch Changes

- isInstalled check only needs to check for python on the path.
([#14712](#14712))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants