[prebuilt-skew-protection] feat: adding user configured deployment id to build output type#14497
Merged
brookemosby merged 18 commits intomainfrom Jan 8, 2026
Conversation
🦋 Changeset detectedLatest commit: d5439cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 Test StrategyComparing: Strategy: Code changed outside of a package - running ALL tests Affected packages - 39 (100%)
Results
This comment is automatically generated based on the affected testing strategy |
Contributor
There was a problem hiding this comment.
Additional Suggestion:
The deploymentId field is defined in the BuildOutputConfig type but is never populated when constructing the config object that gets written to config.json.
View Details
📝 Patch Details
diff --git a/packages/cli/src/commands/build/index.ts b/packages/cli/src/commands/build/index.ts
index d5b28cebf..725a95cc4 100644
--- a/packages/cli/src/commands/build/index.ts
+++ b/packages/cli/src/commands/build/index.ts
@@ -974,6 +974,7 @@ async function doBuild(
overrides.length > 0 ? Object.assign({}, ...overrides) : undefined;
const framework = await getFramework(workPath, buildResults);
+ const deploymentId = getDeploymentId(buildResults.values());
// Write out the final `config.json` file based on the
// user configuration and Builder build results
@@ -985,6 +986,7 @@ async function doBuild(
overrides: mergedOverrides,
framework,
crons: mergedCrons,
+ deploymentId,
};
await fs.writeJSON(join(outputDir, 'config.json'), config, { spaces: 2 });
@@ -1122,6 +1124,17 @@ function mergeWildcard(
return wildcard;
}
+function getDeploymentId(
+ buildResults: Iterable<BuildResult | BuildOutputConfig>
+): string | undefined {
+ for (const result of buildResults) {
+ if ('deploymentId' in result && result.deploymentId) {
+ return result.deploymentId;
+ }
+ }
+ return undefined;
+}
+
/**
* Takes the build output and writes all the flags into the `flags.json`
* file. It'll skip flags that already exist.
Analysis
Missing deploymentId field in BuildOutputConfig
What fails: The deploymentId field is defined in the BuildOutputConfig interface but never populated in the config object written to config.json at lines 980-988 in packages/cli/src/commands/build/index.ts.
How to reproduce: A builder (e.g., Next.js) that provides a deploymentId in its build result would expect this value to appear in the final config.json. However, the field is missing from the output config object despite being defined in the interface.
// In packages/cli/src/commands/build/index.ts lines 980-988
const config: BuildOutputConfig = {
version: 3,
routes: mergedRoutes,
images: mergedImages,
wildcard: mergedWildcard,
overrides: mergedOverrides,
framework,
crons: mergedCrons,
// deploymentId is missing here
};Result: The deploymentId field is not included in config.json even when builders provide it.
Expected: Following the pattern established for other fields like images, crons, and wildcard, the deploymentId should be extracted from the build results and included in the config object, as documented in the JSDoc comment in packages/build-utils/src/types.ts: "User-configured deployment ID for skew protection... in their next.config.js"
Fix: Added a getDeploymentId() function that extracts the deploymentId from build results (similar to existing merge functions) and assigns it to the config object before writing to config.json.
styfle
reviewed
Dec 18, 2025
…ployment-id-to-build-output-type
Disables the automatic session tracking by Sentry.
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@50.1.5 ### Patch Changes - Disable Sentry session tracking ([#14539](#14539)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ployment-id-to-build-output-type
…ployment-id-to-build-output-type
…ployment-id-to-build-output-type
tknickman
approved these changes
Jan 8, 2026
…ployment-id-to-build-output-type
Merged
tknickman
pushed a commit
that referenced
this pull request
Jan 12, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## vercel@50.2.0 ### Minor Changes - Add `vercel env run` command to run commands with environment variables from the linked Vercel project without writing them to the filesystem ([#14582](#14582)) - Merge computed rewrites/redirects to routes in Vercel config ([#14518](#14518)) ### Patch Changes - Adding in user configured deploymentId to build output type ([#14497](#14497)) - skip secondary installation for vercel.ts ([#14471](#14471)) - Updated dependencies \[[`2eb1b7678bece13e442f8404d519bd07891eb500`](2eb1b76), [`39c95ff6b643a63509571818e67a792df09fd71f`](39c95ff), [`d63084dac296ccb2077ed742bc2ade0264da851d`](d63084d)]: - @vercel/next@4.15.11 - @vercel/build-utils@13.2.5 - @vercel/redwood@2.4.6 - @vercel/rust@1.0.4 - @vercel/static-build@2.8.16 - @vercel/backends@0.0.18 - @vercel/elysia@0.1.16 - @vercel/express@0.1.23 - @vercel/fastify@0.1.19 - @vercel/go@3.3.0 - @vercel/h3@0.1.25 - @vercel/hono@0.2.19 - @vercel/hydrogen@1.3.3 - @vercel/nestjs@0.2.20 - @vercel/node@5.5.17 - @vercel/python@6.1.6 - @vercel/remix-builder@5.5.6 - @vercel/ruby@2.2.4 ## @vercel/build-utils@13.2.5 ### Patch Changes - Adding in user configured deploymentId to build output type ([#14497](#14497)) - skip secondary installation for vercel.ts ([#14471](#14471)) ## @vercel/client@17.2.19 ### Patch Changes - Updated dependencies \[[`e725853a6c41bed634d1e3e2382596f17a18f342`](e725853), [`39c95ff6b643a63509571818e67a792df09fd71f`](39c95ff), [`d63084dac296ccb2077ed742bc2ade0264da851d`](d63084d), [`567d2d41e685cd949274411ce0e60e61a3dc3942`](567d2d4)]: - @vercel/routing-utils@5.3.2 - @vercel/build-utils@13.2.5 ## @vercel/elysia@0.1.16 ### Patch Changes - Updated dependencies \[]: - @vercel/node@5.5.17 ## @vercel/express@0.1.23 ### Patch Changes - Updated dependencies \[]: - @vercel/node@5.5.17 ## @vercel/fastify@0.1.19 ### Patch Changes - Updated dependencies \[]: - @vercel/node@5.5.17 ## @vercel/fs-detectors@5.7.12 ### Patch Changes - Updated dependencies \[[`e725853a6c41bed634d1e3e2382596f17a18f342`](e725853), [`567d2d41e685cd949274411ce0e60e61a3dc3942`](567d2d4)]: - @vercel/routing-utils@5.3.2 - @vercel/frameworks@3.15.4 ## @vercel/gatsby-plugin-vercel-builder@2.0.115 ### Patch Changes - Updated dependencies \[[`39c95ff6b643a63509571818e67a792df09fd71f`](39c95ff), [`d63084dac296ccb2077ed742bc2ade0264da851d`](d63084d)]: - @vercel/build-utils@13.2.5 ## @vercel/h3@0.1.25 ### Patch Changes - Updated dependencies \[]: - @vercel/node@5.5.17 ## @vercel/hono@0.2.19 ### Patch Changes - Updated dependencies \[]: - @vercel/node@5.5.17 ## @vercel/nestjs@0.2.20 ### Patch Changes - Updated dependencies \[]: - @vercel/node@5.5.17 ## @vercel/next@4.15.11 ### Patch Changes - Add early validation for Next.js output directory and improve error messages to guide users when the output directory is missing, empty, or misconfigured. Introduces new error codes `NEXT_OUTPUT_DIR_MISSING` and `NEXT_OUTPUT_DIR_EMPTY` with actionable guidance for common issues like Turborepo cache misconfiguration. ([#14542](#14542)) ## @vercel/node@5.5.17 ### Patch Changes - Updated dependencies \[[`39c95ff6b643a63509571818e67a792df09fd71f`](39c95ff), [`d63084dac296ccb2077ed742bc2ade0264da851d`](d63084d)]: - @vercel/build-utils@13.2.5 ## @vercel/routing-utils@5.3.2 ### Patch Changes - Add respectOriginCacheControl to rewritesSchema ([#14506](#14506)) - Add respectOriginCacheControl to routes schema ([#14565](#14565)) ## @vercel/static-build@2.8.16 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.115 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brookemosby/flow-5149-add-user-configured-deployment-id-to-build-output-type
Needed so we can later store on deployment document.