[rust] Allow developers to develop Rust functions on Windows#14439
[rust] Allow developers to develop Rust functions on Windows#14439Zxilly wants to merge 2 commits intovercel:mainfrom
Conversation
|
|
Will check this week, thanks 👏 |
|
@Zxilly I suppose the agent review comment is valid? |
|
Suggesting the following changes: |
|
I think as a follow-up we'd also need a change to the builder script to prevent compiling production prebuilt deployments and/or we find an alternative in how we can also make things compatible for windows. But I am fine shipping this to unblock you for now. |
|
I'll be creating a new PR as we need to publish a new package version / update codeowners based on your changes. |
Based on #14439 Adds the following in addition: * Disabling prebuilt deployments for production on Windows * Bumps version * Updates codeowners for rust-related packages --------- Co-authored-by: Zxilly <zxilly@outlook.com>
|
The new packages have been released. However, it may take some time for the builder changes to propagate upstream to the live Vercel builds. But the main issue of this PR should be unblocked. |
Previously, the runtime failed to compile on Windows due to the
std::os::unix::net::UnixStreamreferenced in the IPC module. However, it appears IPC is only utilized in Vercel's production environment and is unnecessary during local development. This patch resolves the issue by isolating IPC-related logic into conditional compilation specific to Unix systems.@ecklf plz review this