Skip to content

Conversation

@wyattjoh
Copy link
Member

@wyattjoh wyattjoh commented Sep 13, 2024

This enables the CLI to output the request chaining syntax used for Partial Prerendering (PPR). This resolves a problem when the Next.js application uses a basePath property as well as stabilizing the feature in infrastructure.

Previously, the pathname (including the basePath) was used as both the pathname and the output path. This resolves this by restoring ownership of the header configuration to Next.js, which describes it in the manifest.

@changeset-bot
Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: 7c5d8dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vercel/next Patch
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member Author

wyattjoh commented Sep 13, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @wyattjoh and the rest of your teammates on Graphite Graphite

@socket-security
Copy link

socket-security bot commented Sep 13, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/next@v15.0.0-canary.141 None 0 95 MB rauchg, timneutkens, vercel-release-bot

View full report↗︎

@wyattjoh wyattjoh force-pushed the 08-30-fix_expand_manifest_to_support_basepath_fix_for_ppr branch 2 times, most recently from 4b18ed5 to 8f83802 Compare September 13, 2024 22:52
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from eae5e2f to 1cb749d Compare September 13, 2024 22:52
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from 1cb749d to b82569c Compare September 13, 2024 22:54
@wyattjoh wyattjoh force-pushed the 08-30-fix_expand_manifest_to_support_basepath_fix_for_ppr branch from 8f83802 to 9a1a770 Compare September 13, 2024 22:56
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch 2 times, most recently from de30c9a to b544630 Compare September 13, 2024 22:57
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from b544630 to 8522d95 Compare September 14, 2024 21:51
@wyattjoh wyattjoh force-pushed the 08-30-fix_expand_manifest_to_support_basepath_fix_for_ppr branch from 9a1a770 to aa126a4 Compare September 16, 2024 22:11
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from 8522d95 to 065c94a Compare September 16, 2024 22:11
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from 065c94a to 54b55af Compare September 16, 2024 22:40
@wyattjoh wyattjoh force-pushed the 08-30-fix_expand_manifest_to_support_basepath_fix_for_ppr branch from aa126a4 to a1ccdb6 Compare September 17, 2024 22:20
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from 54b55af to d99443c Compare September 17, 2024 22:20
@wyattjoh wyattjoh force-pushed the 08-30-fix_expand_manifest_to_support_basepath_fix_for_ppr branch from a1ccdb6 to 9144e17 Compare September 17, 2024 22:21
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from d99443c to 21477a0 Compare September 17, 2024 22:21
kodiakhq bot pushed a commit that referenced this pull request Sep 19, 2024
This introduces Request Chaining which is a stabilization of the `experimentalStreamingLambdaPath` feature (for Partial Prerendering) to include additional fields like `headers` which will be sent alongside the request to the "chained" lambda in order to perform the resume request. Previously only the output path was provided, which served as the `x-matched-path` header value as well as the output path. This was at fault, as it assumed that the `basePath` was `/`. When the `basePath` is configured in Next.js, this breaks the implementation. This shifts the logic of which headers to send down to Next.js so it can just provide the explicit headers to be set rather than the logic having to exist upstream.

This is a supporting PR to #12117 which adds the implementation.
Base automatically changed from 08-30-fix_expand_manifest_to_support_basepath_fix_for_ppr to main September 19, 2024 19:14
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from 21477a0 to cd7e090 Compare September 19, 2024 20:47
@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from 2dc38b7 to 98ec70a Compare September 23, 2024 18:42
@wyattjoh wyattjoh marked this pull request as ready for review September 24, 2024 01:58
Copy link
Member Author

wyattjoh commented Sep 24, 2024

Merge activity

  • Sep 24, 12:04 AM EDT: @wyattjoh started a stack merge that includes this pull request via Graphite.
  • Sep 24, 12:05 AM EDT: Graphite rebased this pull request as part of a merge.
  • Sep 24, 12:18 AM EDT: Graphite couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'Summary (Node 16)', 'test-e2e (@vercel/next, 7, ubuntu-latest)').
  • Sep 24, 12:23 AM EDT: @wyattjoh merged this pull request with Graphite.

@wyattjoh wyattjoh force-pushed the feat/chained-responses branch from 98ec70a to 7c5d8dc Compare September 24, 2024 04:04
@wyattjoh wyattjoh merged commit 42ae831 into main Sep 24, 2024
@wyattjoh wyattjoh deleted the feat/chained-responses branch September 24, 2024 04:23
trek pushed a commit that referenced this pull request Sep 26, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@37.6.0

### Minor Changes

- [cli] remove `textInput` in favor of `input.text`
([#12168](#12168))

- Add stub telemetry behavior in preparation for use tracking
([#12173](#12173))

### Patch Changes

- Introduce new chain configuration for Partial Prerendering
([#12117](#12117))

- [cli] correctly call to create new deployment when promoting preview
deployment ([#12178](#12178))

- Updated dependencies
\[[`42ae831561365b8254e62cf57f41caca03af4c31`](42ae831),
[`62f434a79fe25009e63fcaefda0abe283c590f58`](62f434a),
[`37ec6fa7f5ff313bfdb22570fb33f8b7eff280e6`](37ec6fa)]:
    -   @vercel/next@4.3.11
    -   @vercel/build-utils@8.4.5
    -   @vercel/node@3.2.17
    -   @vercel/static-build@2.5.27

## @vercel/build-utils@8.4.5

### Patch Changes

- [build-utils] add types for `images.remotePatterns.search` to
vercel.json ([#12158](#12158))

## @vercel/client@13.4.9

### Patch Changes

- Updated dependencies
\[[`62f434a79fe25009e63fcaefda0abe283c590f58`](62f434a)]:
    -   @vercel/build-utils@8.4.5

## @vercel/gatsby-plugin-vercel-builder@2.0.49

### Patch Changes

- Updated dependencies
\[[`62f434a79fe25009e63fcaefda0abe283c590f58`](62f434a)]:
    -   @vercel/build-utils@8.4.5

## @vercel/next@4.3.11

### Patch Changes

- Introduce new chain configuration for Partial Prerendering
([#12117](#12117))

- fix defaultLocale redirect when using domains pattern
([#12166](#12166))

## @vercel/node@3.2.17

### Patch Changes

- Updated dependencies
\[[`62f434a79fe25009e63fcaefda0abe283c590f58`](62f434a)]:
    -   @vercel/build-utils@8.4.5

## @vercel/static-build@2.5.27

### Patch Changes

-   Updated dependencies \[]:
    -   @vercel/gatsby-plugin-vercel-builder@2.0.49

## @vercel-internals/types@2.0.9

### Patch Changes

- Updated dependencies
\[[`62f434a79fe25009e63fcaefda0abe283c590f58`](62f434a)]:
    -   @vercel/build-utils@8.4.5

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
QuietCraftsmanship pushed a commit to QuietCraftsmanship/Vercel that referenced this pull request Jul 6, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@37.6.0

### Minor Changes

- [cli] remove `textInput` in favor of `input.text`
([#12168](vercel/vercel#12168))

- Add stub telemetry behavior in preparation for use tracking
([#12173](vercel/vercel#12173))

### Patch Changes

- Introduce new chain configuration for Partial Prerendering
([#12117](vercel/vercel#12117))

- [cli] correctly call to create new deployment when promoting preview
deployment ([#12178](vercel/vercel#12178))

- Updated dependencies
\[[`3783b78fafbfbb654351f1e1c270a5daf26275bc`](vercel/vercel@3783b78),
[`d7771d7c652a889402ca89c5e617fc3b44638a12`](vercel/vercel@d7771d7),
[`d79a681bd7d2bb277c615ba07db02dd86be08bd3`](vercel/vercel@d79a681)]:
    -   @vercel/next@4.3.11
    -   @vercel/build-utils@8.4.5
    -   @vercel/node@3.2.17
    -   @vercel/static-build@2.5.27

## @vercel/build-utils@8.4.5

### Patch Changes

- [build-utils] add types for `images.remotePatterns.search` to
vercel.json ([#12158](vercel/vercel#12158))

## @vercel/client@13.4.9

### Patch Changes

- Updated dependencies
\[[`d7771d7c652a889402ca89c5e617fc3b44638a12`](vercel/vercel@d7771d7)]:
    -   @vercel/build-utils@8.4.5

## @vercel/gatsby-plugin-vercel-builder@2.0.49

### Patch Changes

- Updated dependencies
\[[`d7771d7c652a889402ca89c5e617fc3b44638a12`](vercel/vercel@d7771d7)]:
    -   @vercel/build-utils@8.4.5

## @vercel/next@4.3.11

### Patch Changes

- Introduce new chain configuration for Partial Prerendering
([#12117](vercel/vercel#12117))

- fix defaultLocale redirect when using domains pattern
([#12166](vercel/vercel#12166))

## @vercel/node@3.2.17

### Patch Changes

- Updated dependencies
\[[`d7771d7c652a889402ca89c5e617fc3b44638a12`](vercel/vercel@d7771d7)]:
    -   @vercel/build-utils@8.4.5

## @vercel/static-build@2.5.27

### Patch Changes

-   Updated dependencies \[]:
    -   @vercel/gatsby-plugin-vercel-builder@2.0.49

## @vercel-internals/types@2.0.9

### Patch Changes

- Updated dependencies
\[[`d7771d7c652a889402ca89c5e617fc3b44638a12`](vercel/vercel@d7771d7)]:
    -   @vercel/build-utils@8.4.5

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants