[next]: fix issues with rewrite normalization of index routes#11707
Merged
kodiakhq[bot] merged 6 commits intomainfrom Jun 6, 2024
Merged
[next]: fix issues with rewrite normalization of index routes#11707kodiakhq[bot] merged 6 commits intomainfrom
kodiakhq[bot] merged 6 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: fb3a90b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
cd8df4a to
2b848aa
Compare
ijjk
reviewed
Jun 6, 2024
Co-authored-by: JJ Kasper <jj@jjsweb.site>
ijjk
previously approved these changes
Jun 6, 2024
ijjk
reviewed
Jun 6, 2024
Co-authored-by: JJ Kasper <jj@jjsweb.site>
ijjk
previously approved these changes
Jun 6, 2024
ijjk
approved these changes
Jun 6, 2024
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
Jun 7, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@8.2.2 ### Patch Changes - Change node 16.x EOL for Vercel ([#11704](#11704)) - Improve error message and refactor ([#11706](#11706)) - [built-utils] Handle case of not having lockfile when corepack is enabled ([#11697](#11697)) ## vercel@34.2.6 ### Patch Changes - [built-utils] Handle case of not having lockfile when corepack is enabled ([#11697](#11697)) - Updated dependencies \[[`5c12ed695`](5c12ed6), [`21444a38e`](21444a3), [`fa9789a93`](fa9789a), [`c925dc4a1`](c925dc4), [`06d2d860e`](06d2d86), [`b735f37fd`](b735f37)]: - @vercel/build-utils@8.2.2 - @vercel/next@4.2.16 - @vercel/redwood@2.0.10 - @vercel/remix-builder@2.1.7 - @vercel/node@3.1.7 - @vercel/static-build@2.5.11 ## @vercel/client@13.2.9 ### Patch Changes - Updated dependencies \[[`5c12ed695`](5c12ed6), [`21444a38e`](21444a3), [`06d2d860e`](06d2d86)]: - @vercel/build-utils@8.2.2 ## @vercel/gatsby-plugin-vercel-builder@2.0.33 ### Patch Changes - Updated dependencies \[[`5c12ed695`](5c12ed6), [`21444a38e`](21444a3), [`06d2d860e`](06d2d86)]: - @vercel/build-utils@8.2.2 ## @vercel/next@4.2.16 ### Patch Changes - prevent /index from being incorrectly normalized in rewrites ([#11707](#11707)) - Upgrade to @vercel/nft 0.27.2 with browser remapping support ([#11700](#11700)) - ensure unmatched rsc rewrites are routed to correct handler ([#11688](#11688)) ## @vercel/node@3.1.7 ### Patch Changes - Upgrade to @vercel/nft 0.27.2 with browser remapping support ([#11700](#11700)) - Updated dependencies \[[`5c12ed695`](5c12ed6), [`21444a38e`](21444a3), [`06d2d860e`](06d2d86)]: - @vercel/build-utils@8.2.2 ## @vercel/redwood@2.0.10 ### Patch Changes - Upgrade to @vercel/nft 0.27.2 with browser remapping support ([#11700](#11700)) ## @vercel/remix-builder@2.1.7 ### Patch Changes - Upgrade to @vercel/nft 0.27.2 with browser remapping support ([#11700](#11700)) ## @vercel/static-build@2.5.11 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.33 ## @vercel-internals/types@1.0.38 ### Patch Changes - Updated dependencies \[[`5c12ed695`](5c12ed6), [`21444a38e`](21444a3), [`06d2d860e`](06d2d86)]: - @vercel/build-utils@8.2.2 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Next.js builder currently normalizes user rewrites to ensure the internal
.rsc/.actionrewrites are still handled even after following the rewrite.However we have special rewrites:
/index.rscand/index.action. When those routes pass through the normalization logic, a request routed to a catch-all route (e.g.[[...param]]) will go from/->/index.rsc-><someRewriteString>?param=index. This is inconsistentnext startor other spots where the param should be an empty string.Similarly, if a user rewrites their entire app to a subdirectory (eg
/:path*->/base/:path*, a route will go from/->/index.rsc->/base/index.rscwhich won't exist, causing a 404.The solution here is to return the
index.rsc/index.actionroutes back to/so they can be handled by user rewrites, if necessary.This also disables the
hasActionOutputSupportflag ifroutesManifest.i18nis detected as they are not compatible.