Merged
Conversation
🦋 Changeset detectedLatest commit: 68bdd55 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
EndangeredMassa
approved these changes
May 30, 2024
Contributor
EndangeredMassa
left a comment
There was a problem hiding this comment.
I don't know Python deeply, but this looks like it could work.
kytta
reviewed
May 30, 2024
| asgi_task = loop.create_task(asgi_instance) | ||
| loop.run_until_complete(asgi_task) | ||
| else: | ||
| asyncio.run(self.run_asgi_instance(asgi_instance)) |
There was a problem hiding this comment.
I've mentioned this in another PR fixing this issue: Since asgi_instance is a coroutine, I believe you don't have to wrap in a function
…python-is-incompatible-with
Merged
trek
pushed a commit
that referenced
this pull request
May 30, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/python@4.3.0 ### Minor Changes - support newer python versions ([#11675](#11675)) ## @vercel/build-utils@8.2.1 ### Patch Changes - [node] update node@16 deprecation day ([#11671](#11671)) ## vercel@34.2.4 ### Patch Changes - Updated dependencies \[[`3eb9d8c89`](3eb9d8c), [`83741a0eb`](83741a0)]: - @vercel/python@4.3.0 - @vercel/build-utils@8.2.1 - @vercel/node@3.1.6 - @vercel/static-build@2.5.10 ## @vercel/client@13.2.8 ### Patch Changes - Updated dependencies \[[`83741a0eb`](83741a0)]: - @vercel/build-utils@8.2.1 ## @vercel/gatsby-plugin-vercel-builder@2.0.32 ### Patch Changes - Updated dependencies \[[`83741a0eb`](83741a0)]: - @vercel/build-utils@8.2.1 ## @vercel/node@3.1.6 ### Patch Changes - Updated dependencies \[[`83741a0eb`](83741a0)]: - @vercel/build-utils@8.2.1 ## @vercel/static-build@2.5.10 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.32 ## @vercel-internals/types@1.0.37 ### Patch Changes - Updated dependencies \[[`83741a0eb`](83741a0)]: - @vercel/build-utils@8.2.1 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we added the option of getting
al2023in addition toal2, this required a python version bump for those apps onal2023. Python 3.10 had a breaking minor change. #11541 mostly fixed it, with some comments.OP hasn't replied to feedback on that PR, so I've take it over from them.