fix corepack detection for package manager version determination#11596
Merged
kodiakhq[bot] merged 9 commits intomainfrom May 15, 2024
Merged
fix corepack detection for package manager version determination#11596kodiakhq[bot] merged 9 commits intomainfrom
kodiakhq[bot] merged 9 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: bd57cf3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trek
previously approved these changes
May 14, 2024
erikareads
reviewed
May 14, 2024
erikareads
suggested changes
May 14, 2024
Contributor
Author
|
I'm updating this to include the actual fix, not just the logging fix. |
…ub.com/vercel/vercel into endangeredmassa/fix-corepack-detection
EndangeredMassa
commented
May 14, 2024
erikareads
reviewed
May 14, 2024
erikareads
reviewed
May 14, 2024
erikareads
reviewed
May 15, 2024
erikareads
previously approved these changes
May 15, 2024
erikareads
approved these changes
May 15, 2024
Merged
EndangeredMassa
pushed a commit
that referenced
this pull request
May 15, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @vercel/build-utils@8.2.0 ### Minor Changes - fix corepack detection for package manager version determination ([#11596](#11596)) ### Patch Changes - Fix triggering of ignored project settings node version warning ([#11550](#11550)) ## vercel@34.2.0 ### Minor Changes - Stop sending system environment variables in dev ([#11526](#11526)) ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 - @vercel/node@3.1.5 - @vercel/static-build@2.5.9 ## @vercel/client@13.2.7 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 ## @vercel/gatsby-plugin-vercel-builder@2.0.31 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 ## @vercel/node@3.1.5 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 ## @vercel/static-build@2.5.9 ### Patch Changes - Updated dependencies \[]: - @vercel/gatsby-plugin-vercel-builder@2.0.31 ## @vercel-internals/types@1.0.36 ### Patch Changes - Updated dependencies \[[`d3c1267e2`](d3c1267), [`ccd7eb1fb`](ccd7eb1)]: - @vercel/build-utils@8.2.0 Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
This PR may have introduced a regression: #11607 |
|
@EndangeredMassa, with #11607 is that going to take any priority? Or no since corepack is still considered experimental in Vercel's docs https://vercel.com/changelog/corepack-experimental-is-now-available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic was checking for the env var
ENABLE_EXPERIMENTAL_COREPACKto determine if corepack was being used by a project. However, this value only means that the build system should consider corepack, not that it's actively being used.We need to check that flag AND the existence of a
packageManagerproperty in the project'spackage.json.