Skip to content

Project limits error handling#10807

Merged
zlw241 merged 4 commits intomainfrom
zachward/onb-125-handle-too-many-projects-error-message
Nov 8, 2023
Merged

Project limits error handling#10807
zlw241 merged 4 commits intomainfrom
zachward/onb-125-handle-too-many-projects-error-message

Conversation

@zlw241
Copy link
Contributor

@zlw241 zlw241 commented Nov 7, 2023

This PR adds improved error handling for the 200 project limit error that will start being returned for free tier teams/accounts. The following changes have been made:

  • improve error message format by using client.output.prettyError so that the docs link (https://vercel.com/docs/limits/overview#general-limits) returned with the error response is included with the error message
  • add explicit error handling of this error from any places where createProject is called, which includes the following commands:
    • vc project add
    • vc link (indirectly called via ensureLink)
    • vc list (indirectly called via ensureLink)
    • vc git connect (indirectly called via ensureLink)

Testing

  • sign in to a vercel account that is associated with your work email (ends in @vercel.com), this is necessary for creating a team with the proper conditions to artificially trigger the error message
  • create a Pro Trial team and make sure to prefix the name with: vtest314 too many projects , for example vtest314 too many projects test 1
  • check out this branch and cd to vercel/vercel/packages/cli
  • run: pnpm dev add [project-name] --cwd=/path/to/some/project
  • the project should fail to be created and you should see the expected error message (screenshot below) in the terminal output

Screenshot of error message when attempting to add project from cli
image

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: a4592fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

gdborton
gdborton previously approved these changes Nov 7, 2023
Copy link
Member

@gdborton gdborton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, small nit to add PR description.

@zlw241 zlw241 changed the title Handle TooManyProjects error in places where projects are created Project limits error handling Nov 7, 2023
@zlw241 zlw241 marked this pull request as ready for review November 7, 2023 21:12
…' of github.com:vercel/vercel into zachward/onb-125-handle-too-many-projects-error-message
@zlw241 zlw241 merged commit ebd7e3a into main Nov 8, 2023
@zlw241 zlw241 deleted the zachward/onb-125-handle-too-many-projects-error-message branch November 8, 2023 16:48
Ethan-Arrowood pushed a commit that referenced this pull request Nov 8, 2023
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## vercel@32.5.3

### Patch Changes

- Handle `TooManyProjects` error in places where projects are created
([#10807](#10807))

- Updated dependencies
\[[`89c1e0323`](89c1e03),
[`fd29b966d`](fd29b96)]:
    -   @vercel/node@3.0.9
    -   @vercel/next@4.0.14

## @vercel/next@4.0.14

### Patch Changes

- Fixed headers for static routes when PPR is enabled
([#10808](#10808))

## @vercel/node@3.0.9

### Patch Changes

- Replace usage of `fetch` with `undici.request`
([#10767](#10767))

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants