Skip to content

[tests] Fix failures due to Node 14.x being discontinued#10346

Merged
styfle merged 8 commits intomainfrom
fix/node-14-tests
Aug 15, 2023
Merged

[tests] Fix failures due to Node 14.x being discontinued#10346
styfle merged 8 commits intomainfrom
fix/node-14-tests

Conversation

@TooTallNate
Copy link
Member

@TooTallNate TooTallNate commented Aug 15, 2023

This PR upgrades test fixtures from Node.js 14 to 16 and also removes the 35-puppeteer test fixture since it doesn't support Node.js 16 unfortunately.

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2023

🦋 Changeset detected

Latest commit: 9772bda

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

styfle
styfle previously approved these changes Aug 15, 2023
@styfle
Copy link
Member

styfle commented Aug 15, 2023

I think 35-puppeteer has to update dependencies

@styfle styfle marked this pull request as ready for review August 15, 2023 20:26
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll have to delete it since its no longer supported 🫡

@styfle styfle merged commit 10a6aa5 into main Aug 15, 2023
@styfle styfle deleted the fix/node-14-tests branch August 15, 2023 21:59
TooTallNate added a commit that referenced this pull request Aug 17, 2023
This PR upgrades test fixtures from Node.js 14 to 16 and also removes
the `35-puppeteer` test fixture since it doesn't support Node.js 16
unfortunately.

- See alixaxel/chrome-aws-lambda#274

---------

Co-authored-by: Steven <steven@ceriously.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants