fix: Ignore SIGINT in shim after spawning local turbo#12612
Merged
Conversation
When the shim spawns a local turbo from node_modules, both processes share the same process group. Pressing Ctrl+C sends SIGINT to the entire group — the shim had no handler, so it was killed immediately by the default disposition. This caused the shell to draw its prompt while the local turbo was still running its graceful shutdown, producing garbled output and orphaned child processes. Set SIG_IGN for SIGINT in the shim *after* spawning the child so the child inherits the default disposition and can register its own handler, while the shim stays alive to collect the exit status.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
turbo
turboSIGINT in shim after spawning local turbo
github-actions Bot
added a commit
that referenced
this pull request
Apr 13, 2026
## Release v2.9.7-canary.6 Versioned docs: https://v2-9-7-canary-6.turborepo.dev ### Changes - release(turborepo): 2.9.7-canary.5 (#12611) (`61f3f02`) - fix: Ignore SIGINT in shim after spawning local `turbo` (#12612) (`d28c4ea`) Co-authored-by: Turbobot <turbobot@vercel.com>
github-actions Bot
added a commit
that referenced
this pull request
May 1, 2026
## Release v2.9.7 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/25199467832) ### Changes - feat(sandbox): Bump @vercel/sandbox from v1 to beta (#12595) (`dba017a`) - release(turborepo): 2.9.6 (#12597) (`50d7bcf`) - fix: Align Markdown docs routing with docs/md endpoints (#12596) (`ca04adc`) - fix: Support two-dot git ranges in filter selectors (#12599) (`04f9f41`) - chore: Update examples to Turbo 2.9.6 (#12600) (`1a48897`) - release(turborepo): 2.9.7-canary.1 (#12602) (`cc99739`) - release(turborepo): 2.9.7-canary.2 (#12603) (`41ff958`) - chore: Upgrade dependencies to resolve their known vulnerabilities (#12604) (`dd34170`) - ci: Remove cargo and pnpm audit workflows (#12605) (`dbf2aeb`) - release(turborepo): 2.9.7-canary.3 (#12606) (`f674256`) - fix: Preserve graceful shutdown output (#12607) (`0b5bb21`) - release(turborepo): 2.9.7-canary.4 (#12608) (`d727147`) - test: Add stdin EOF startup regression coverage (#12609) (`eba8246`) - release(turborepo): 2.9.7-canary.5 (#12611) (`61f3f02`) - fix: Ignore SIGINT in shim after spawning local `turbo` (#12612) (`d28c4ea`) - release(turborepo): 2.9.7-canary.6 (#12613) (`e8015da`) - fix: Support pnpm v11 multi-document lockfiles (#12616) (`d0d5d3a`) - release(turborepo): 2.9.7-canary.7 (#12617) (`598121f`) - fix: Preserve graceful shutdown exit code (#12620) (`4a3f274`) - release(turborepo): 2.9.7-canary.8 (#12621) (`8b481bb`) - fix: Keep Node wrapper alive during graceful shutdown (#12622) (`a081b02`) - release(turborepo): 2.9.7-canary.9 (#12623) (`7550044`) - fix: Preserve PTY graceful shutdown semantics (#12624) (`f4ba2d0`) - feat: Move Vercel auth to standard OAuth/device flows (#12526) (`0f37c24`) - release(turborepo): 2.9.7-canary.10 (#12625) (`f7c5d3e`) - release(turborepo): 2.9.7-canary.11 (#12626) (`046efea`) - examples: Add Ultracite example (#12615) (`3188a56`) - fix: Preserve legacy Vercel auth compatibility (#12629) (`2d20d3b`) - release(turborepo): 2.9.7-canary.12 (#12630) (`90d1430`) - fix: Recover Vercel auth tokens across login flows (#12631) (`0d83a51`) - release(turborepo): 2.9.7-canary.13 (#12632) (`d7618e6`) - docs: Fix TURBO_PLATFORM_ENV_DISABLED value in docs (true, not false) (#12633) (`99f27c4`) - ci: Temporarily disable cron releases (#12637) (`9f385a1`) - chore: Update flags SDK (#12646) (`a7ee687`) - ci: Disable AWS-backed sccache (#12663) (`5983eb5`) - fix: Prevent prune from overmatching gitignore entries (#12662) (`5478288`) - ci: Harden release API commits (#12664) (`45842be`) - ci: Fix release API commit paths (#12665) (`6d6d70d`) - release(turborepo): 2.9.7-canary.14 (#12666) (`70e9353`) - chore: Add `tbx` sandbox helper (#12668) (`c6f0d53`) - fix: Allow npm registry in tbx sandboxes (#12669) (`57a4716`) - fix: Install turbo globally in tbx base (#12670) (`78134f8`) - docs: Clarify package hash file inputs (#12671) (`fdfed03`) - fix: Allow tbx sandboxes to use stale bases (#12672) (`ce65df5`) - fix: Install dotfiles during `tbx base refresh` (#12673) (`7a3023d`) - fix: Improve tbx sandbox startup (#12674) (`aab6e38`) - fix: Improve tbx sandbox startup defaults (#12675) (`409b6d8`) - fix: Support pnpm 11 flat patch lockfiles (#12676) (`976bdce`) - docs: Fix link to passthrough variables source code (#12643) (`7c64d46`) - release(turborepo): 2.9.7-canary.15 (#12677) (`bca27f0`) - fix: Avoid rerunning non-cacheable watch dependencies (#12678) (`9477571`) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the shim spawns a locally-installed turbo from
node_modules, both processes share the same foreground process group. Pressing Ctrl+C sends SIGINT to the entire group — the shim had no signal handler, so it was killed immediately by the default disposition while the local turbo was still running graceful shutdown.This caused:
The fix ignores SIGINT in the shim after spawning the child process, so:
wait()Testing
From a repo with
turboas a devDependency (so the shim spawns local turbo):turbo dev(with a persistent task that has a SIGINT handler with a countdown)