Skip to content

refactor: Migrate inference and run-logging tests to Rust#12018

Merged
anthonyshew merged 2 commits into
mainfrom
shew/migrate-inference-run-logging
Feb 27, 2026
Merged

refactor: Migrate inference and run-logging tests to Rust#12018
anthonyshew merged 2 commits into
mainfrom
shew/migrate-inference-run-logging

Conversation

@anthonyshew

Copy link
Copy Markdown
Contributor

Summary

  • Converts 4 inference/ and 9 run-logging/ prysk tests to pure Rust
  • Prysk count drops from 124 to 111

Test mapping

inference/ (4 .t files → 4 Rust tests)

Old .t file Rust test Pattern
has-workspaces.t test_has_workspaces Run from 5 subdirs, grep for pkg_inference_root
has-workspaces-dot-prefix.t test_has_workspaces_dot_prefix Run from workspace dirs + --filter=./path
no-workspaces.t test_no_workspaces Multi-repo setup (3 git repos), check error messages
nested-workspaces.t test_nested_workspaces Multi-repo setup (6 git repos), check Repository Root and turbo.json detection from 12 dirs

run-logging/ (9 .t files → 29 Rust tests)

Old .t file Rust tests Pattern
log-order-stream.t 3 assert!(contains) — stream output non-deterministic
log-order-grouped.t 3 insta::assert_snapshot! — grouped output deterministic
log-order-github.t 3 assert!(contains) for ::group:: markers with GITHUB_ACTIONS=1
log-prefix.t 5 Cache miss/hit, log file check, error handling
verbosity.t 5 -v/-vv/--verbosity flag behavior
errors-only.t 4 --output-logs=errors-only flag + turbo.json config
errors-only-show-hash.t 3 Hash display with errors-only mode
full-cache-hit-output.t 1 Cache hit replay with various --output-logs values
no-cache-and-no-output-logs.t 1 --cache=local:,remote: with --output-logs=none

Notable fix

log-order-github.t's ::error:: annotation test was already broken in prysk (the Rust turbo doesn't implement ::error:: annotations). The new test asserts what actually works.

How to verify

cargo nextest run --test inference_test --test run_logging -p turbo

Convert 4 inference and 9 run-logging prysk tests to pure Rust.
Prysk count drops from 124 to 111.

Notable: run-logging/log-order-github.t's ::error:: annotation test was
already broken in prysk (Rust turbo doesn't implement ::error::). The
new test asserts what actually works (task failure output with ::group::).
@anthonyshew anthonyshew requested a review from a team as a code owner February 26, 2026 23:36
@anthonyshew anthonyshew requested review from tknickman and removed request for a team February 26, 2026 23:36
@vercel

vercel Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
examples-basic-web Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
examples-designsystem-docs Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
examples-gatsby-web Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
examples-kitchensink-blog Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
examples-nonmonorepo Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
examples-svelte-web Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
examples-tailwind-web Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
examples-vite-web Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
turbo-site Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
turborepo-agents Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am
turborepo-test-coverage Ready Ready Preview, Comment, Open in v0 Feb 27, 2026 0:28am

@github-actions

github-actions Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Metric Coverage
Lines 78.86%
Functions 50.62%
Branches 0.00%

View full report

@anthonyshew anthonyshew merged commit dc4f922 into main Feb 27, 2026
54 checks passed
@anthonyshew anthonyshew deleted the shew/migrate-inference-run-logging branch February 27, 2026 01:24
github-actions Bot added a commit that referenced this pull request Feb 27, 2026
## Release v2.8.12-canary.3

Versioned docs: https://v2-8-12-canary-3.turborepo.dev

### Changes

- fix: Prevent peerDependencies from overwriting concrete dependency
specifiers (#12004) (`a038409`)
- ci: Trigger prysk integration tests via `cargo nextest` (#11999)
(`2053ede`)
- release(turborepo): 2.8.12-canary.2 (#12005) (`dccfdf0`)
- fix: Resolve correct nested package version in bun lockfile pruning
(#12008) (`95dff45`)
- refactor: Replace shell-based fixture setup with pure Rust (#12006)
(`a743e38`)
- fix: Resolve all lockfile pruning test failures (#12009) (`21dcaed`)
- perf: Extract query module into turborepo-query crate (#12007)
(`0604379`)
- refactor: Migrate dry-json prysk tests to Rust + insta snapshots
(#12010) (`2606f3f`)
- perf: Deduplicate petgraph, fixedbitset, and dashmap (#12011)
(`9b11ef6`)
- refactor: Migrate persistent-dependencies and task-dependencies to
Rust + insta (#12012) (`9aab7b5`)
- test: Add lockfile-tests fixture for issue #12013 (#12014) (`bae81f7`)
- perf: Remove libgit2/git2 dependency, replace with gix-object (#12015)
(`fbf50e5`)
- refactor: Migrate daemon, jsonc, query, edit-turbo-json tests to Rust
(#12016) (`bf730d5`)
- perf: Remove async-graphql from turborepo-lib (#12017) (`7c8a4a0`)
- refactor: Migrate inference and run-logging tests to Rust (#12018)
(`dc4f922`)
- refactor: Migrate run-caching and strict-env-vars tests to Rust
(#12020) (`c07645d`)
- fix: Mark lockfile-aware-caching/bun prysk test as flaky (#12021)
(`c60f0c1`)
- fix: Add nextest retries for flaky tests (#12027) (`9d90270`)
- refactor: Migrate prune and run-summary tests to Rust (#12022)
(`329bdb5`)
- ci: Increase Rust test partitions from 4 to 10 (#12028) (`0c1bd47`)
- fix: Add nextest retries for flaky prysk tests (#12030) (`9b66431`)
- ci: Use larger runners for macOS Rust tests (#12029) (`9479a54`)
- fix: Add nextest retries for flaky
prune_test::test_prune_composable_config (#12032) (`b47e099`)
- fix: Suppress npm upgrade notices in Rust integration tests (#12033)
(`f698b04`)
- ci: Disable flaky Rust unit tests from release pipeline (#12034)
(`829b351`)

---------

Co-authored-by: Turbobot <turbobot@vercel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant