Skip to content

deps: upgrade playwright version#4186

Merged
huozhi merged 1 commit intomainfrom
dep/playwright
Nov 28, 2025
Merged

deps: upgrade playwright version#4186
huozhi merged 1 commit intomainfrom
dep/playwright

Conversation

@promer94
Copy link
Copy Markdown
Collaborator

@promer94 promer94 commented Nov 28, 2025

the playwright version we used is deprecated now.

based on #4184 #4185

@vercel
Copy link
Copy Markdown

vercel bot commented Nov 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
swr Error Error Nov 28, 2025 7:50am

@codesandbox-ci
Copy link
Copy Markdown

codesandbox-ci bot commented Nov 28, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 28, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​playwright/​test@​1.34.3 ⏵ 1.57.0100 +6100100 +2499100

View full report

Copy link
Copy Markdown

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Build Fix:

The Vercel project configuration was pointing to a non-existent "docs" directory as the root build directory. Adding vercel.json with "root": "." tells Vercel to build from the repository root where the actual source code and build configuration are located.

View Details
📝 Patch Details
diff --git a/vercel.json b/vercel.json
new file mode 100644
index 0000000..938fa64
--- /dev/null
+++ b/vercel.json
@@ -0,0 +1,3 @@
+{
+  "root": "."
+}

Analysis

Missing Vercel root directory configuration causes build failure

What fails: Vercel deployment fails because the project is configured to use "docs" as the root directory, but that directory does not exist in the repository.

How to reproduce:

# Attempt to deploy with Vercel using the dep/playwright branch
# The build will fail with: "The specified Root Directory "docs" does not exist. Please update your Project Settings."

Result:

The specified Root Directory "docs" does not exist. Please update your Project Settings.

Expected behavior: Vercel should build the project from the repository root (the current directory) where the package.json, source code, and build configuration files are located.

Solution: Added a vercel.json configuration file with "root": "." to explicitly tell Vercel to use the repository root as the build directory, overriding any project-level configuration that was incorrectly set to "docs".

Fix on Vercel

@huozhi huozhi merged commit cc8071d into main Nov 28, 2025
7 of 8 checks passed
@huozhi huozhi deleted the dep/playwright branch November 28, 2025 15:39
dcondrey pushed a commit to dcondrey/swr that referenced this pull request Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants