fix: react.use should not depend on data condition#4150
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
48bcc49 to
f18bb0c
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
promer94
approved these changes
Aug 5, 2025
Collaborator
|
Great ! This pr would also fix #2702. I can add |
dcondrey
pushed a commit
to dcondrey/swr
that referenced
this pull request
Dec 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix SWR's incorrect usage of React's
use()hook and update tests for React 19Problem
SWR currently uses React's
use()hook incorrectly in the suspense implementation, which causes incorrect data to be displayed in Suspense scenarios. This is particularly problematic with React 19's improved concurrent features and stricteruse()hook behavior.Reference: SWR's incorrect use() implementation
React side changes:
x-ref: facebook/react#34030
Changes
use()in render unconditionally when suspense flag is enabled