bugfix: make suspense and revalidateIfStale work together#1851
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8f6b489:
|
shuding
reviewed
Feb 15, 2022
Member
shuding
left a comment
There was a problem hiding this comment.
Thanks! The fix looks good to me, would you mind also adding a test case to ensure it doesn't break in the future?
Author
Done! |
Author
No problem! |
shuding
pushed a commit
that referenced
this pull request
Apr 10, 2022
* bugfix: make suspense and revalidateIfStale work together * test: add test for revalidateIfStale used with suspense
|
Does this mean the Suspense will be supported in V2? I got the feeling that there is a lot more to implementing suspense then is indicated here based on the discussions we've had. |
nevilm-lt
pushed a commit
to nevilm-lt/swr-1
that referenced
this pull request
Apr 22, 2022
* bugfix: make suspense and revalidateIfStale work together * test: add test for revalidateIfStale used with suspense
himanshiLt
pushed a commit
to himanshiLt/swr
that referenced
this pull request
Jun 10, 2022
* bugfix: make suspense and revalidateIfStale work together * test: add test for revalidateIfStale used with suspense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Today,
revalidateIfStaleis ignored when usingsuspense: true.This fix makes
revalidateIfStalebehave consistently with or withoutsuspense