Skip to content

Test: Included tests for verifying SSL hosting#720

Merged
leerob merged 8 commits intovercel:mainfrom
schemburkar:tests-for-pfx-certs
Jul 27, 2022
Merged

Test: Included tests for verifying SSL hosting#720
leerob merged 8 commits intovercel:mainfrom
schemburkar:tests-for-pfx-certs

Conversation

@schemburkar
Copy link
Contributor

@schemburkar schemburkar commented Jul 18, 2022

Added tests for SSL hosting with PFX and PEM certificates.

Builds on #708 feature to test new scenarios

------------|---------|----------|---------|---------|---------------------------
File        | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
------------|---------|----------|---------|---------|---------------------------
All files   |    91.5 |    82.27 |   84.21 |    91.5 |
 config.ts  |   88.19 |    73.91 |     100 |   88.19 | 49-52,80-87,89-90,96-98
 http.ts    |   83.72 |    77.77 |      80 |   83.72 | 17-21,36,42
 logger.ts  |    87.5 |      100 |      50 |    87.5 | 9,13
 promise.ts |     100 |      100 |     100 |     100 |
 server.ts  |   94.85 |       85 |     100 |   94.85 | 60-61,104,112,130-133,163
------------|---------|----------|---------|---------|---------------------------

CC: @leerob

@schemburkar
Add support for PFX or PKCS12 encoded certificates
028f5d4 
Add support for PFX or PKCS12 encoded certificates
@schemburkar
Updated comments
a7ec55a
@schemburkar
Rename httpMode to protocol
1260d47
@schemburkar
Merge branch 'vercel:main' into typescript-pfx-support
0aebdf3
@schemburkar
Fix Tests: Updated cli snapshot
dfbb4af 
 Updated cli snapshot due to change in help test, using vitest -u option
@schemburkar
Test: Included tests for verifying SSL hosting
6136c84 
Added tests for SSL hosting with PFX and PEM certificates
@schemburkar
Copy link
Contributor Author

schemburkar commented Jul 18, 2022

This workflow is awaiting approval from a maintainer in #720

Can the CI be approved so that I can verify if its working on the ubuntu host as well? My dev box is Windows.

@leerob
Copy link
Contributor

leerob commented Jul 19, 2022

This is awesome - excellent work!

@schemburkar
Copy link
Contributor Author

schemburkar commented Jul 19, 2022

Since we have GitHub Actions now running smooth, do we want to disconnect CircleCI from this repo?
I still get emails on every commit if there is an active PR.

https://app.circleci.com/pipelines/github/vercel/serve

Let me know if an issue should be raised for the same?

gamemaker1
gamemaker1 reviewed Jul 19, 2022
View reviewed changes
gamemaker1
gamemaker1 reviewed Jul 19, 2022
View reviewed changes
gamemaker1
gamemaker1 reviewed Jul 19, 2022
View reviewed changes
@schemburkar
Copy link
Contributor Author

schemburkar commented Jul 19, 2022

Thanks @gamemaker1 For the feedback, address all your comments.

gamemaker1
gamemaker1 reviewed Jul 20, 2022
View reviewed changes
@leerob
Copy link
Contributor

leerob commented Jul 20, 2022

Okay, CircleCI should hopefully be removed now.

@schemburkar
Copy link
Contributor Author

schemburkar commented Jul 26, 2022

All checks are passing fine, do you have any other feedback for me on this PR? If not, I would say its ready to be merged.

@gamemaker1
Copy link
Contributor

gamemaker1 commented Jul 26, 2022

Looks good to me :]

leerob
leerob approved these changes Jul 27, 2022
View reviewed changes
Copy link
Contributor

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work!

@leerob leerob merged commit 0616ce3 into vercel:main Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@gamemaker1 gamemaker1 gamemaker1 left review comments

@leerob leerob leerob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schemburkar @leerob @gamemaker1