fix: Support xlinkHref attribute for SVG image elements#724
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Co-authored-by: shuding <3676859+shuding@users.noreply.github.com>
Co-authored-by: shuding <3676859+shuding@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix interpretation of xlinkHref for image source in SVGs
Support xlinkHref attribute for SVG image elements
Feb 7, 2026
shuding
approved these changes
Mar 2, 2026
|
🎉 This PR is included in version 0.19.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
shuding
added a commit
to vercel/next.js
that referenced
this pull request
Mar 5, 2026
The new `@vercel/og` and `satori` include many improvements: - 2~20x faster image generation (`ImageResponse` API) by using Sharp for rasterization, and optimized Satori core - Better CSS/SVG coverage: - vercel/satori#736 - vercel/satori#734 - vercel/satori#733 - vercel/satori#732 - vercel/satori#728 - vercel/satori#724 - vercel/satori#717 - vercel/satori#718 - vercel/satori#719 - Updated layout engine (vercel/satori#689): - Support for `box-sizing` - Support for `display: contents` - Support for `position: static` - Support for `align-content: space-evenly` - Better support for `position: absolute` - Support for percentage values for `gap` - Noto Sans → Geist Sans
sokra
pushed a commit
to vercel/next.js
that referenced
this pull request
Mar 6, 2026
The new `@vercel/og` and `satori` include many improvements: - 2~20x faster image generation (`ImageResponse` API) by using Sharp for rasterization, and optimized Satori core - Better CSS/SVG coverage: - vercel/satori#736 - vercel/satori#734 - vercel/satori#733 - vercel/satori#732 - vercel/satori#728 - vercel/satori#724 - vercel/satori#717 - vercel/satori#718 - vercel/satori#719 - Updated layout engine (vercel/satori#689): - Support for `box-sizing` - Support for `display: contents` - Support for `position: static` - Support for `align-content: space-evenly` - Better support for `position: absolute` - Support for percentage values for `gap` - Noto Sans → Geist Sans
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG
<image>elements only recognizedhrefas the image source attribute, causing errors when using the JSX/React-compatiblexlinkHrefprop.Changes
src/handler/preprocess.ts
hrefandxlinkHrefwhen resolving image data from cacheprops.hrefandprops.xlinkHrefduring preprocessingtest/image.test.tsx
xlinkHrefattribute includingxmlns:xlinknamespace declarationThe existing
ATTRIBUTE_MAPPINGalready handles thexlinkHref→xlink:hrefconversion for SVG output.Original prompt
This section details on the original issue you should resolve
<issue_title>
xlinkHrefisn't interpreted as source for<image />in SVGs</issue_title><issue_description># Bug report
Description / Observed Behavior
Using namespaced attribute in JSX form like
xlinkHrefinstead ofxlink:hrefcauses error "Image source is not provided" to be thrown.Expected Behavior
Satori should use the JSX/TSX attribute
xlinkHrefas the<image />source, interpreting it the same it doesxlink:hrefandhref.Reproduction
Using
xlink:href(works)[Using
xlinkHref(doesn't work)](https://og-playground.vercel.app/?share=5Vlpb-LIFv0riNGT-sk98YI3Mt0jGTCLbQx4w0aRRt6wDd5XoNX__ZUJJCQ9ip70kg9vYilR1anruvcc36q62D-6duK43fvuNyeoH-JOpyiPofv9x4-23en4buD55X3noYsiyL8eul8f4SZwSv8X1AmKNDSPLb4N3cMT3nZGQe7aZZDE7aidhFUUP42bYeDFs9KNivOgG5du_jS4q4oy2B6HCUDjcySvDLZgRA5O7n2HQLEbbH0JnUSQC1q6h5Jpff0yy8-fD_GfbeNbUXs3FL8_dHsI8tC9FeMlVgduM0gOAEQ6SAcMtH_XwW0QhmAkTmL3Ch2iMC4A5pdleg_DTdPcNb27JPdgDEEQuHV_a6mHQbz_W3O03-_Dh3b48YZz-IBAK_PL4F_FfY2q8YMShNWBb-98bALnwADtE3cY1b_G0-kcAYjjdz2KxJ7BqyuaesaeHN6C-XlO9I54hsrcjIttkkdgJE9Ks3S_4ETn4rdzcfXvZ_tL5FUefvktNUvw_GLkLxz7CyV7N1ZFmSd7F9hZoWlf1HnGf3_S5jry_y0A-oECYAR1h5L4SwFQBIA32Dvz7yOdi9vOo6e36WMfSp-8I_Anuwv910nxzvzRHgEEODu-JsLbCvQ-dAX07qjXK-CXrHhnBX5HaQRQP3u-5sLbEuAfKQFC3L1eAr8kxrsrAJLg0fE1F94WgPhAAXDwIAj8VQ78khjvrQDYBi6Or6nwtgLkRyrwest_3AZf5sV7CwDOgYvfSya8zZ_60CXwcsc_H4Ovs-J_4f83fOh35OO42-LSBr2Lg2u_0wkccNercuJ59k7nMnSpQNU4KNsCLrF2QKZBUsVOEHugBLy95RoLegs-qXGDPoUFAqsKt3Mu6Ka5uwVmvwWR6bnPEb1Ik8I2Q_cLcoeg5wvI9MQXTAVfYv4vWV9riM_F-lo6fC7W13Lhc7G-Vgifi_W1LPhcrK-lwOdifS0APhfra5nwj2N9nusV51fz_xp-_-nN04v4X8Jp7hZuXrtMkQJBJBO8lAM2t--o2uuWmGOW5v3ZOZzG3h-WWbgk_jXQBgupQfiJlzDgEmXVZ1UPtMZtf2AOGaPF8Yxlh21jqA9ma30OWoUC_glswzJR2pyNGF2UJWTG5AVuk6sWkOKVig7AXYddU9PGSgXYKpRVaaBNvQG1OVlyIA7Y2SbHCzlBdHVcSzON3fQZmonVITxFMiZ13eEYp5oS5_QAPzFJdChW9oaqJhx7ILNoPTIxpAf1aG--wQIasnsOi6KKVKEYhLHCvDHETSm6xI4nFGFsKw2GVnCPdHulIDkWn2rJJjIiESVzVPa5Q9k_mlHGE9U2tqmJKCVzMlZBbzo-7FVB0YdDj0kOa2Zv5Iy50IJFjroBvrFzwZsS5TDZjCBsKlM9GR7PY2sI7U9TTphA5gzPQjVfkIs4NTeZE9vIuKYgmOiTqi8jhbCQguUJhzJRywjbINAab5bD7dKy5-Z6VoqlloXISNqRGjOUgmKQEGsGUVM2jVZqfsr285wzhFm6WauJp_M...xlinkHrefisn't interpreted as source for<image />in SVGs #722💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.