fix: do not follow absolute paths outside job base#568
Merged
styfle merged 6 commits intovercel:mainfrom Feb 23, 2026
Merged
Conversation
teemingc
commented
Feb 19, 2026
6 tasks
|
🎉 This PR is included in version 1.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
teemingc
added a commit
to sveltejs/kit
that referenced
this pull request
Feb 23, 2026
closes #13764 closes #15349 We landed a fix in vercel/nft#568 that should prevent system files from being copied into the function bundle. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. No test unless we want a test app that attempts to exceed the function bundle size ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
Copilot AI
pushed a commit
to Stadly/kit
that referenced
this pull request
Mar 6, 2026
closes sveltejs#13764 closes sveltejs#15349 We landed a fix in vercel/nft#568 that should prevent system files from being copied into the function bundle. --- ### Please don't delete this checklist! Before submitting the PR, please make sure you do the following: - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. No test unless we want a test app that attempts to exceed the function bundle size ### Tests - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` and `pnpm check` ### Changesets - [x] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running `pnpm changeset` and following the prompts. Changesets that add features should be `minor` and those that fix bugs should be `patch`. Please prefix changeset messages with `feat:`, `fix:`, or `chore:`. ### Edits - [x] Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to sveltejs/kit#13764 (comment)
SvelteKit stringifies environment variables during build so that it can inject static values into the build output instead of always reading the env vars dynamically. However,
@vercel/nftinterprets any absolute path as an asset it should add. This causes builds on Vercel's build system to balloon in function size because it traces and bundles paths such as Node, Yarn global, etc. Often, this causes the deployment to fail because the function size exceeds the limit.This PR ensures asset paths outside the given job base are ignored to help us avoid packaging in system dependencies.
Draft for now because I'm not confident that this fix doesn't break lots of other things