Skip to content

Fix next-routing header interpolation#91010

Merged
ijjk merged 2 commits intocanaryfrom
ijjk/route-resolver
Mar 7, 2026
Merged

Fix next-routing header interpolation#91010
ijjk merged 2 commits intocanaryfrom
ijjk/route-resolver

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Mar 7, 2026 •
edited
Loading

Summary

  • interpolate source and has captures in @next/routing route headers anywhere destinations are already interpolated
  • make onMatch headers respect route matching and capture interpolation instead of applying unconditionally
  • keep middleware and initial request headers internal to routing so resolvedHeaders only contains actual response headers
  • add regressions for header interpolation and for request-header leakage into resolvedHeaders

Testing

  • pnpm --dir packages/next-routing types
  • pnpm --dir packages/next-routing test -- --runInBand

@nextjs-bot nextjs-bot added the created-by: Next.js team PRs by the Next.js team. label Mar 7, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 7, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 7, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 506ms 506ms ✓ ██▁▁█
Cold (Ready in log) 463ms 461ms ✓ ██▂▁█
Cold (First Request) 902ms 910ms ✓ ██▄▃█
Warm (Listen) 456ms 507ms ✓ ██▁▁█
Warm (Ready in log) 459ms 461ms ✓ ██▁▁█
Warm (First Request) 384ms 340ms ✓ ▇█▂▂█
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁██▁█
Cold (Ready in log) 438ms 437ms ✓ ▇██▅▆
Cold (First Request) 1.920s 1.930s ✓ ▅█▅▄▄
Warm (Listen) 456ms 456ms ✓ ███▁█
Warm (Ready in log) 436ms 437ms ✓ ▇█▆▇▇
Warm (First Request) 1.946s 1.921s ✓ ▅█▅▅▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.068s 4.036s ✓ ██▁▁▇
Cached Build 4.067s 4.071s ✓ █▇▁▁▇
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.038s 13.977s ✓ ▂█▂▂▂
Cached Build 14.193s 14.132s ✓ ▂█▃▂▂
node_modules Size 477 MB 477 MB ✓ ▁████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ✅ -17 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 775 B 764 B 🟢 11 B (-1%)
Total 775 B 764 B ✅ -11 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 448 B ✓
Total 451 B 448 B ✅ -3 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.3 kB -
Total 233 kB 234 kB ⚠️ +747 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 256 kB 257 kB ✓
Total 381 kB 382 kB ⚠️ +698 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 612 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.5 kB 43.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.1 kB 45.5 kB ⚠️ +418 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.07 MB 4.08 MB 🔴 +5.02 kB (+0%)
index.pack gzip 103 kB 102 kB ✓
index.pack.old gzip 103 kB 103 kB ✓
Total 4.28 MB 4.28 MB ⚠️ +4.2 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 322 kB 322 kB ✓
app-page-tur..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 319 kB 319 kB ✓
app-page-tur..prod.js gzip 169 kB 169 kB ✓
app-page.run...dev.js gzip 319 kB 319 kB ✓
app-page.run..prod.js gzip 169 kB 169 kB ✓
app-route-ex...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49.1 kB 49.1 kB ✓
app-route.ru...dev.js gzip 70.5 kB 70.5 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.3 kB 43.3 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.84 MB 2.84 MB ⚠️ +1 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/a0f12a94c09eaef65813ce33fa0c3448b7158504/next

@ijjk ijjk marked this pull request as ready for review March 7, 2026 02:23
@ijjk ijjk requested review from feedthejim and ztanner March 7, 2026 02:23
@ijjk ijjk enabled auto-merge (squash) March 7, 2026 02:44
@ijjk ijjk merged commit b7b58b2 into canary Mar 7, 2026
158 checks passed
@ijjk ijjk deleted the ijjk/route-resolver branch March 7, 2026 02:53
sokra pushed a commit that referenced this pull request Mar 7, 2026
@ijjk @sokra
Fix next-routing header interpolation (#91010)
d0686b8 
## Summary
- interpolate source and `has` captures in `@next/routing` route headers
anywhere destinations are already interpolated
- make `onMatch` headers respect route matching and capture
interpolation instead of applying unconditionally
- keep middleware and initial request headers internal to routing so
`resolvedHeaders` only contains actual response headers
- add regressions for header interpolation and for request-header
leakage into `resolvedHeaders`

## Testing
- `pnpm --dir packages/next-routing types`
- `pnpm --dir packages/next-routing test -- --runInBand`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@feedthejim feedthejim feedthejim approved these changes

@ztanner ztanner Awaiting requested review from ztanner

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijjk @nextjs-bot @feedthejim