Turbopack: CompileTimeDefineValue numbers and regex by mischnic · Pull Request #90934 · vercel/next.js

mischnic · 2026-03-05T14:44:49Z

Number(f64) instead of Number(RcStr)
Add BigInt
Add Regex

mischnic · 2026-03-05T14:45:07Z

Turbopack: cross-module constants #90300
Turbopack: CompileTimeDefineValue numbers and regex #90934 👈 (View in Graphite)
canary

This stack of pull requests is managed by Graphite. Learn more about stacking.

nextjs-bot · 2026-03-05T15:07:49Z

Stats from current PR

✅ No significant changes detected

📊 All Metrics

📖 Metrics Glossary

Dev Server Metrics:

Listen = TCP port starts accepting connections
First Request = HTTP server returns successful response
Cold = Fresh build (no cache)
Warm = With cached build artifacts

Build Metrics:

Fresh = Clean build (no .next directory)
Cached = With existing .next directory

Change Thresholds:

Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
Size: Changes < 1KB AND < 1% are insignificant
All other changes are flagged to catch regressions

⚡ Dev Server

Metric	Canary	PR	Change	Trend
Cold (Listen)	457ms	456ms	✓	▁▁▁▁▁
Cold (Ready in log)	456ms	455ms	✓	▁▂▁▂▂
Cold (First Request)	938ms	936ms	✓	▃▄▁▃▃
Warm (Listen)	457ms	457ms	✓	▁▁▁▁▁
Warm (Ready in log)	456ms	454ms	✓	▁▁▁▁▁
Warm (First Request)	376ms	373ms	✓	▁▁▁▁▁

📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric	Canary	PR	Change	Trend
Cold (Listen)	456ms	455ms	✓	▁▁▁▅▁
Cold (Ready in log)	446ms	447ms	✓	▅▆▅▇▅
Cold (First Request)	1.948s	1.971s	✓	▄▅▄▆▅
Warm (Listen)	456ms	456ms	✓	▃▃▃▁▃
Warm (Ready in log)	446ms	443ms	✓	▅▆▆▆▆
Warm (First Request)	1.979s	1.980s	✓	▄▅▅▅▄

⚡ Production Builds

Metric	Canary	PR	Change	Trend
Fresh Build	4.187s	4.190s	✓	▁▁▂▁▁
Cached Build	4.186s	4.178s	✓	▁▁▂▁▁

📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric	Canary	PR	Change	Trend
Fresh Build	14.224s	14.185s	✓	▃▃▃▂▂
Cached Build	14.354s	14.394s	✓	▅▁▄▂▂
node_modules Size	475 MB	475 MB	✓	▁▁▁▁▁

📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **401 kB** → **401 kB** ⚠️ +10 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	769 B	762 B	✓
Total	769 B	762 B	✅ -7 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	450 B	452 B	✓
Total	450 B	452 B	⚠️ +2 B

📦 Webpack

Client

Main Bundles

	Canary	PR	Change
5528-HASH.js gzip	5.54 kB	N/A	-
6280-HASH.js gzip	59.4 kB	N/A	-
6335.HASH.js gzip	169 B	N/A	-
912-HASH.js gzip	4.59 kB	N/A	-
e8aec2e4-HASH.js gzip	62.6 kB	N/A	-
framework-HASH.js gzip	59.7 kB	59.7 kB	✓
main-app-HASH.js gzip	256 B	254 B	✓
main-HASH.js gzip	39.1 kB	39.1 kB	✓
webpack-HASH.js gzip	1.68 kB	1.68 kB	✓
262-HASH.js gzip	N/A	4.59 kB	-
2889.HASH.js gzip	N/A	169 B	-
5602-HASH.js gzip	N/A	5.55 kB	-
6948ada0-HASH.js gzip	N/A	62.6 kB	-
9544-HASH.js gzip	N/A	60.2 kB	-
Total	233 kB	234 kB	⚠️ +732 B

Polyfills

	Canary	PR	Change
polyfills-HASH.js gzip	39.4 kB	39.4 kB	✓
Total	39.4 kB	39.4 kB	✓

Pages

	Canary	PR	Change
_app-HASH.js gzip	194 B	194 B	✓
_error-HASH.js gzip	183 B	180 B	🟢 3 B (-2%)
css-HASH.js gzip	331 B	330 B	✓
dynamic-HASH.js gzip	1.81 kB	1.81 kB	✓
edge-ssr-HASH.js gzip	256 B	256 B	✓
head-HASH.js gzip	351 B	352 B	✓
hooks-HASH.js gzip	384 B	383 B	✓
image-HASH.js gzip	580 B	581 B	✓
index-HASH.js gzip	260 B	260 B	✓
link-HASH.js gzip	2.51 kB	2.51 kB	✓
routerDirect..HASH.js gzip	320 B	319 B	✓
script-HASH.js gzip	386 B	386 B	✓
withRouter-HASH.js gzip	315 B	315 B	✓
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Total	7.98 kB	7.98 kB	✅ -1 B

Server

Edge SSR

	Canary	PR	Change
edge-ssr.js gzip	125 kB	125 kB	✓
page.js gzip	254 kB	254 kB	✓
Total	379 kB	379 kB	⚠️ +249 B

Middleware

	Canary	PR	Change
middleware-b..fest.js gzip	617 B	615 B	✓
middleware-r..fest.js gzip	156 B	155 B	✓
middleware.js gzip	43.6 kB	43.5 kB	✓
edge-runtime..pack.js gzip	842 B	842 B	✓
Total	45.2 kB	45.1 kB	✅ -121 B

Build Details

Build Manifests

	Canary	PR	Change
_buildManifest.js gzip	715 B	718 B	✓
Total	715 B	718 B	⚠️ +3 B

Build Cache

	Canary	PR	Change
0.pack gzip	4.03 MB	4.04 MB	🔴 +9.37 kB (+0%)
index.pack gzip	103 kB	103 kB	✓
index.pack.old gzip	102 kB	103 kB	✓
Total	4.24 MB	4.25 MB	⚠️ +9.29 kB

🔄 Shared (bundler-independent)

Runtimes

	Canary	PR	Change
app-page-exp...dev.js gzip	321 kB	321 kB	✓
app-page-exp..prod.js gzip	170 kB	170 kB	✓
app-page-tur...dev.js gzip	321 kB	321 kB	✓
app-page-tur..prod.js gzip	170 kB	170 kB	✓
app-page-tur...dev.js gzip	318 kB	318 kB	✓
app-page-tur..prod.js gzip	168 kB	168 kB	✓
app-page.run...dev.js gzip	318 kB	318 kB	✓
app-page.run..prod.js gzip	168 kB	168 kB	✓
app-route-ex...dev.js gzip	70.3 kB	70.3 kB	✓
app-route-ex..prod.js gzip	48.6 kB	48.6 kB	✓
app-route-tu...dev.js gzip	70.4 kB	70.4 kB	✓
app-route-tu..prod.js gzip	48.7 kB	48.7 kB	✓
app-route-tu...dev.js gzip	69.9 kB	69.9 kB	✓
app-route-tu..prod.js gzip	48.4 kB	48.4 kB	✓
app-route.ru...dev.js gzip	69.9 kB	69.9 kB	✓
app-route.ru..prod.js gzip	48.4 kB	48.4 kB	✓
dist_client_...dev.js gzip	324 B	324 B	✓
dist_client_...dev.js gzip	326 B	326 B	✓
dist_client_...dev.js gzip	318 B	318 B	✓
dist_client_...dev.js gzip	317 B	317 B	✓
pages-api-tu...dev.js gzip	43.2 kB	43.2 kB	✓
pages-api-tu..prod.js gzip	32.9 kB	32.9 kB	✓
pages-api.ru...dev.js gzip	43.2 kB	43.2 kB	✓
pages-api.ru..prod.js gzip	32.9 kB	32.9 kB	✓
pages-turbo....dev.js gzip	52.6 kB	52.6 kB	✓
pages-turbo...prod.js gzip	38.5 kB	38.5 kB	✓
pages.runtim...dev.js gzip	52.6 kB	52.6 kB	✓
pages.runtim..prod.js gzip	38.5 kB	38.5 kB	✓
server.runti..prod.js gzip	61.8 kB	61.8 kB	✓
Total	2.83 MB	2.83 MB	✓

📎 Tarball URL

https://vercel-packages.vercel.app/next/commits/4c683ea21c792fd835ed848b736c21447dfc7f38/next

codspeed-hq · 2026-03-05T15:12:10Z

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks¹

_{Comparing mischnic/compile-time-define-value (1aa2532) with canary (73049d6)}

3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

lukesandberg · 2026-03-05T18:12:45Z

turbopack/crates/turbopack-core/src/compile_time_info.rs

+    (mantissa, exponent, sign)
+}
+
+/// Wrapper around f64 that implements total ordering and hashing based on total ordering.


why do we care about total ordering?

shouldn't we just use f64::to_bits?

For Eq and Hash, you need total ordering.

not sure why we have integer_decode, @sokra do you know?

Not sure... I think to_bits would be good too

- Number(f64) instead of Number(RcStr) - Add BigInt - Add Regex

nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 5, 2026

mischnic mentioned this pull request Mar 5, 2026

Turbopack: cross-module constants #90300

Open

mischnic marked this pull request as ready for review March 5, 2026 14:50

mischnic changed the title ~~Turbopack: CompileTimeDefineValue better numbers~~ Turbopack: CompileTimeDefineValue numbers and regex Mar 5, 2026

mischnic requested a review from a team March 5, 2026 14:51

lukesandberg reviewed Mar 5, 2026

View reviewed changes

lukesandberg approved these changes Mar 5, 2026

View reviewed changes

mischnic added 4 commits March 5, 2026 20:35

Turbopack: CompileTimeDefineValue better numbers

35da7ea

Turbopack: CompileTimeDefineValue regex

abb612e

update snapshots

ed95e71

remove integer_decode

1aa2532

mischnic force-pushed the mischnic/compile-time-define-value branch from 4c683ea to 1aa2532 Compare March 5, 2026 19:35

mischnic merged commit 73b44a1 into canary Mar 6, 2026
290 of 292 checks passed

mischnic deleted the mischnic/compile-time-define-value branch March 6, 2026 08:48

sokra pushed a commit that referenced this pull request Mar 6, 2026

Turbopack: CompileTimeDefineValue numbers and regex (#90934)

cde0433

- Number(f64) instead of Number(RcStr) - Add BigInt - Add Regex

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Turbopack: CompileTimeDefineValue numbers and regex#90934

Turbopack: CompileTimeDefineValue numbers and regex#90934
mischnic merged 4 commits intocanaryfrom
mischnic/compile-time-define-value

mischnic commented Mar 5, 2026 •

edited

Loading

Uh oh!

mischnic commented Mar 5, 2026

Uh oh!

nextjs-bot commented Mar 5, 2026

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

codspeed-hq bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

lukesandberg Mar 5, 2026

Uh oh!

mischnic Mar 5, 2026 •

edited

Loading

Uh oh!

sokra Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

mischnic commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mischnic commented Mar 5, 2026

Uh oh!

nextjs-bot commented Mar 5, 2026

Stats from current PR

✅ No significant changes detected

⚡ Dev Server

📦 Dev Server (Webpack)

⚡ Production Builds

📦 Production Builds (Webpack)

Bundle Sizes

⚡ Turbopack

📦 Webpack

🔄 Shared (bundler-independent)

Uh oh!

codspeed-hq bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

lukesandberg Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

mischnic Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sokra Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mischnic commented Mar 5, 2026 •

edited

Loading

codspeed-hq bot commented Mar 5, 2026 •

edited

Loading

mischnic Mar 5, 2026 •

edited

Loading