Cleanup non-generic assertions in our deploy test suite#90894
Merged
Conversation
ztanner
approved these changes
Mar 4, 2026
| // the custom 404 only shows inside of the basePath so this | ||
| // could be a platform default 404 page on deploy | ||
| if (!isNextDeploy) { | ||
| expect(text).toContain('This page could not be found') |
Member
There was a problem hiding this comment.
maybe skip this entire assertion in deploy mode? since we're not testing what it's saying
Member
Author
There was a problem hiding this comment.
the above assertion could still fail if it passes through instead of rendering a 404 or similar. We just can't assert what the 404 content can be since not Next.js specific
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **401 kB** → **401 kB** ✅ -15 B80 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📎 Tarball URL |
Collaborator
Failing test suitesCommit: d462e0f | About building and testing Next.js
Expand output● deterministic build - changing deployment id › build output API - cacheComponents builder › should produce identical build outputs even when changing deployment id |
sokra
pushed a commit
that referenced
this pull request
Mar 6, 2026
This makes sure we don't have assertions that will only pass in one environment e.g. these should work for running against bun and not just node or against a local metadata URL not just a deployed https fully qualified domain. Ensures others can leverage this test suite for their own verification easily.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes sure we don't have assertions that will only pass in one environment e.g. these should work for running against bun and not just node or against a local metadata URL not just a deployed https fully qualified domain. Ensures others can leverage this test suite for their own verification easily.