Skip to content

Turbopack: Make ReadVcFuture::strongly_consistent private#90843

Merged
bgw merged 1 commit intocanaryfrom
bgw/read-vc-future-strongly-consistent
Mar 6, 2026
Merged

Turbopack: Make ReadVcFuture::strongly_consistent private#90843
bgw merged 1 commit intocanaryfrom
bgw/read-vc-future-strongly-consistent

Conversation

@bgw
Copy link
Member

@bgw bgw commented Mar 3, 2026 •
edited
Loading

This method is needed with turbo-tasks to implement OperationVc, but exposing it to other crates turns it into a footgun, because it allows you to attempt to read a Vc or ResolvedVc with strong consistency, which doesn't have a well-defined meaning.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 3, 2026
@bgw bgw mentioned this pull request Mar 3, 2026
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Mar 3, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@bgw bgw mentioned this pull request Mar 3, 2026
Merged
@bgw bgw requested a review from a team March 3, 2026 22:59
@bgw bgw marked this pull request as ready for review March 3, 2026 22:59
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 3, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 442ms 442ms ✓ ▁▁▁▁▁
Cold (First Request) 893ms 882ms ✓ ▂▂▂▂▂
Warm (Listen) 456ms 455ms ✓ ▁▁▂▁▁
Warm (Ready in log) 440ms 441ms ✓ ▁▁▁▁▁
Warm (First Request) 352ms 353ms ✓ ▁▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 435ms 435ms ✓ ▅▄▁▅▅
Cold (First Request) 1.932s 1.925s ✓ ▃▃▁▃▆
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 435ms 435ms ✓ ▅▆▁▅▅
Warm (First Request) 1.922s 1.920s ✓ ▄▅▁▄▇

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.936s 3.885s ✓ ▁▁▂▁▁
Cached Build 3.925s 3.914s ✓ ▁▁▂▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.954s 13.875s ✓ ▁▁▁▁▅
Cached Build 14.140s 14.088s ✓ ▁▁▁▁▅
node_modules Size 477 MB 477 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **402 kB** → **402 kB** ✅ -31 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 766 B ✓
Total 764 B 766 B ⚠️ +2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.5 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 60.3 kB -
Total 233 kB 234 kB ⚠️ +765 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 256 kB 257 kB ✓
Total 381 kB 382 kB ⚠️ +698 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 43.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.5 kB ⚠️ +58 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.07 MB 4.08 MB 🔴 +11.3 kB (+0%)
index.pack gzip 103 kB 103 kB ✓
index.pack.old gzip 102 kB 103 kB ✓
Total 4.27 MB 4.29 MB ⚠️ +12.3 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 322 kB 322 kB ✓
app-page-exp..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 322 kB 322 kB ✓
app-page-tur..prod.js gzip 171 kB 171 kB ✓
app-page-tur...dev.js gzip 319 kB 319 kB ✓
app-page-tur..prod.js gzip 169 kB 169 kB ✓
app-page.run...dev.js gzip 319 kB 319 kB ✓
app-page.run..prod.js gzip 169 kB 169 kB ✓
app-route-ex...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49.1 kB 49.1 kB ✓
app-route.ru...dev.js gzip 70.5 kB 70.5 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.3 kB 43.3 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.84 MB 2.84 MB ⚠️ +4 B
📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/a90c270dcefa7e64769f49c327b91d979110c1dd/next

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing bgw/read-vc-future-strongly-consistent (a90c270) with canary (9d0fbf1)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@bgw bgw force-pushed the bgw/read-vc-future-must-use branch 2 times, most recently from ecb4b7c to cf29870 Compare March 5, 2026 19:17
@bgw bgw force-pushed the bgw/read-vc-future-strongly-consistent branch from fe6a6a0 to 52d79a6 Compare March 5, 2026 19:17
@bgw bgw changed the base branch from bgw/read-vc-future-must-use to graphite-base/90843 March 5, 2026 19:51
@bgw bgw force-pushed the bgw/read-vc-future-strongly-consistent branch from 52d79a6 to a90c270 Compare March 5, 2026 19:51
@bgw bgw force-pushed the graphite-base/90843 branch from cf29870 to 9d0fbf1 Compare March 5, 2026 19:51
@graphite-app graphite-app bot changed the base branch from graphite-base/90843 to canary March 5, 2026 19:52
@graphite-app
Copy link
Contributor

graphite-app bot commented Mar 5, 2026 •
edited by bgw
Loading

Merge activity

  • Mar 5, 7:52 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.
  • Mar 6, 7:36 PM UTC: @bgw merged this pull request with Graphite.

@bgw bgw merged commit 6e894cf into canary Mar 6, 2026
508 of 531 checks passed
@bgw bgw deleted the bgw/read-vc-future-strongly-consistent branch March 6, 2026 19:36
sokra pushed a commit that referenced this pull request Mar 6, 2026
@bgw @sokra
Turbopack: Make ReadVcFuture::strongly_consistent private (#90843)
c282f04 
This method is needed with `turbo-tasks` to implement `OperationVc`, but exposing it to other crates turns it into a footgun, because it allows you to attempt to read a `Vc` or `ResolvedVc` with strong consistency, which doesn't have a well-defined meaning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesandberg lukesandberg lukesandberg approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bgw @nextjs-bot @lukesandberg