Skip to content

Unify Node and Edge externals list#90819

Merged
mischnic merged 2 commits intocanaryfrom
mischnic/fixup-externals
Mar 4, 2026
Merged

Unify Node and Edge externals list#90819
mischnic merged 2 commits intocanaryfrom
mischnic/fixup-externals

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Mar 3, 2026 •
edited
Loading

Unify the list of Node/Edge iexternals.
Turns out readline/promises and stream/consumers was missing in some places.

Closes #90765

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 3, 2026
@mischnic Graphite App
Copy link
Member Author

mischnic commented Mar 3, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic marked this pull request as ready for review March 3, 2026 12:56
@mischnic mischnic mentioned this pull request Mar 3, 2026
Closed
@mischnic mischnic requested a review from a team March 3, 2026 13:02
@mischnic mischnic force-pushed the mischnic/fixup-externals branch from 5fc26b5 to f289ba3 Compare March 3, 2026 13:03
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 3, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 507ms 507ms ✓ ▁▁▁▁▁
Cold (Ready in log) 495ms 493ms ✓ ▁▁▁▁▁
Cold (First Request) 1.074s 1.076s ✓ ▃▃▃▃▄
Warm (Listen) 507ms 506ms ✓ ▁▁▁▁▁
Warm (Ready in log) 492ms 490ms ✓ ▁▁▁▁▁
Warm (First Request) 404ms 405ms ✓ ▂▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 508ms 507ms ✓ ▁▁▁█▁
Cold (Ready in log) 491ms 491ms ✓ ▃▃▃█▃
Cold (First Request) 2.238s 2.214s ✓ ▁▁▁█▁
Warm (Listen) 507ms 507ms ✓ ▁▁▁█▁
Warm (Ready in log) 488ms 490ms ✓ ▃▃▃█▃
Warm (First Request) 2.223s 2.231s ✓ ▁▂▁█▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.590s 4.664s ✓ ▁▁▁▁▁
Cached Build 4.687s 4.533s ✓ ▁▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 16.145s 16.062s ✓ ▁▁▁█▁
Cached Build 16.173s 16.198s ✓ ▁▁▁█▁
node_modules Size 475 MB 475 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **401 kB** → **401 kB** ✅ -24 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 767 B 765 B ✓
Total 767 B 765 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 452 B ✓
Total 450 B 452 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 59.1 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 254 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 59.8 kB -
Total 233 kB 234 kB ⚠️ +709 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.51 kB 2.51 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.98 kB 7.98 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 254 kB 255 kB ✓
Total 379 kB 380 kB ⚠️ +879 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 616 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 44 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.7 kB ⚠️ +254 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B ✓
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.04 MB 4.05 MB 🔴 +4.52 kB (+0%)
index.pack gzip 103 kB 102 kB ✓
index.pack.old gzip 103 kB 103 kB ✓
Total 4.25 MB 4.25 MB ⚠️ +4.14 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 321 kB 321 kB ✓
app-page-exp..prod.js gzip 170 kB 170 kB ✓
app-page-tur...dev.js gzip 321 kB 321 kB ✓
app-page-tur..prod.js gzip 170 kB 170 kB ✓
app-page-tur...dev.js gzip 317 kB 317 kB ✓
app-page-tur..prod.js gzip 168 kB 168 kB ✓
app-page.run...dev.js gzip 318 kB 318 kB ✓
app-page.run..prod.js gzip 168 kB 168 kB ✓
app-route-ex...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-ex..prod.js gzip 48.8 kB 48.8 kB ✓
app-route-tu...dev.js gzip 70.6 kB 70.6 kB ✓
app-route-tu..prod.js gzip 48.9 kB 48.9 kB ✓
app-route-tu...dev.js gzip 70.1 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.6 kB 48.6 kB ✓
app-route.ru...dev.js gzip 70.1 kB 70.1 kB ✓
app-route.ru..prod.js gzip 48.6 kB 48.6 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 61.9 kB 61.9 kB ✓
Total 2.83 MB 2.83 MB ⚠️ +1 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api-tu..time.prod.js
  • pages-turbo...time.prod.js
View diffs
pages-api-tu..time.prod.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/d25b7742616e26c73112bda935c552d160275394/next

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026 •
edited
Loading

Merging this PR will improve performance by 3.51%

⚡ 1 improved benchmark
✅ 16 untouched benchmarks
⏩ 3 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
⚡ Simulation packages-bundle.js[full] 1.2 s 1.2 s +3.51%

Comparing mischnic/fixup-externals (d25b774) with canary (c37ef48)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 4, 2026 •
edited
Loading

Tests Passed

bgw
bgw approved these changes Mar 4, 2026
View reviewed changes
crates/next-taskless/src/constants.rs
Comment on lines +73 to +86
/// List of node.js internals that are supported by edge runtime.
/// If anything Node.js builtin module apart from these these imports are
/// used and user does not provide alias for the polyfill, a runtime error will be thrown.
/// See https://vercel.com/docs/functions/runtimes/edge-runtime#compatible-node.js-modules
// SAFETY: This has to be sorted alphabetically since we are doing binary search on it
pub const EDGE_NODE_EXTERNALS: [&str; 7] = [
"assert",
"assert/strict",
"async_hooks",
"buffer",
"events",
"util",
"util/types",
];
Copy link
Member

@bgw bgw Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is better, listing the thing that are supported instead of the things that aren't.

@mischnic mischnic merged commit a41e4d5 into canary Mar 4, 2026
291 of 295 checks passed
@mischnic Graphite App
Copy link
Member Author

mischnic commented Mar 4, 2026

Merge activity

@mischnic mischnic deleted the mischnic/fixup-externals branch March 4, 2026 17:36
sokra pushed a commit that referenced this pull request Mar 6, 2026
@mischnic @sokra
Unify Node and Edge externals list (#90819)
100af83 
Unify the list of Node/Edge iexternals.
Turns out `readline/promises` and `stream/consumers` was missing in some places.

Closes #90765
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bgw bgw bgw approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Turbopack does not support imports from stream/consumers

3 participants

@mischnic @nextjs-bot @bgw