Skip to content

[turbotask] Make turbotask function registration const#90797

Merged
mmastrac merged 6 commits intocanaryfrom
mmastrac/const-turbotaskfn
Mar 4, 2026
Merged

[turbotask] Make turbotask function registration const#90797
mmastrac merged 6 commits intocanaryfrom
mmastrac/const-turbotaskfn

Conversation

@mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Mar 3, 2026

What

Make turbotask function registration const -- all function registration blocks are true &'static items, compiled directly into the binary. Removes a few thousand allocations of type names and boxed impls of TaskFn.

Why

We have approx 2k functions, so the cost of Lazy construction + temporary allocations adds up (even with compiler optimization). This also unlocks the opportunity for further startup optimizations (in later PRs).

How

The #[turbo_tasks::function] macro now generates static items initialized directly with const fn constructors instead of Lazy::new(|| ...), using const { &into_task_fn(f) as &dyn TaskFn } blocks to produce &'static dyn TaskFn trait objects at compile time from zero-sized function items.

Global names that previously required runtime format!() + Box::leak() are now computed at compile time via const_type_name() (a const wrapper around std::any::type_name) and a const_concat! macro that concatenates string slices into a fixed-size byte array.

The NativeFunction struct, ArgMeta, and the into_task_fn/into_task_fn_with_this wrappers are all const fn-constructible, with input types inferred through a TaskFnInputs trait that maps wrapper types to their argument tuples (we use a non-allocated and non-compiled temporary "duplicate" TaskFn instance that is only useful for type inference in a const context).

Next Steps

I believe we can remove the const type_name in favour of the const type_id and instead pull function names only when needed for display purposes. This will show up in a future PR.

We can also remove non-const registration for things that aren't functions as well, though I believe this is less important.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 3, 2026
Copy link
Contributor Author

mmastrac commented Mar 3, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 3, 2026

Tests Passed

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 3, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1


Comparing mmastrac/const-turbotaskfn (591b339) with canary (eab44ed)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 3, 2026

Stats from current PR

🔴 1 regression

Metric Canary PR Change Trend
node_modules Size 476 MB 476 MB 🔴 +112 kB (+0%) █████
📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▇▁▁▁
Cold (Ready in log) 436ms 438ms ▁▇▁▁▁
Cold (First Request) 1.241s 1.251s ▄▆▃▃▄
Warm (Listen) 457ms 457ms ▁█▁▁▁
Warm (Ready in log) 440ms 440ms ▁▇▁▁▁
Warm (First Request) 347ms 344ms ▁▇▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ▁▁█▅▁
Cold (Ready in log) 438ms 438ms ▃▃█▅▃
Cold (First Request) 1.978s 1.958s ▂▂█▄▂
Warm (Listen) 457ms 456ms ▁▁█▅▁
Warm (Ready in log) 438ms 439ms ▃▃█▄▂
Warm (First Request) 1.975s 1.947s ▂▁█▄▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.787s 3.903s ▁▆▁▁▁
Cached Build 3.892s 3.910s ▁▅▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.090s 14.149s ▁▁█▄▁
Cached Build 14.158s 14.221s ▁▁█▄▁
node_modules Size 476 MB 476 MB 🔴 +112 kB (+0%) █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **401 kB** → **401 kB** ✅ -41 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 768 B 765 B
Total 768 B 765 B ✅ -3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 452 B
Total 451 B 452 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 58.7 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB
main-app-HASH.js gzip 256 B 254 B
main-HASH.js gzip 39.1 kB 39.1 kB
webpack-HASH.js gzip 1.68 kB 1.68 kB
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 59.4 kB -
Total 232 kB 233 kB ⚠️ +731 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB
Total 39.4 kB 39.4 kB
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B
dynamic-HASH.js gzip 1.81 kB 1.81 kB
edge-ssr-HASH.js gzip 256 B 256 B
head-HASH.js gzip 351 B 352 B
hooks-HASH.js gzip 384 B 383 B
image-HASH.js gzip 580 B 581 B
index-HASH.js gzip 260 B 260 B
link-HASH.js gzip 2.5 kB 2.5 kB
routerDirect..HASH.js gzip 320 B 319 B
script-HASH.js gzip 386 B 386 B
withRouter-HASH.js gzip 315 B 315 B
1afbb74e6ecf..834.css gzip 106 B 106 B
Total 7.97 kB 7.97 kB ✅ -2 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB
page.js gzip 254 kB 255 kB
Total 379 kB 380 kB ⚠️ +914 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 618 B 614 B
middleware-r..fest.js gzip 156 B 155 B
middleware.js gzip 43.6 kB 43.7 kB
edge-runtime..pack.js gzip 842 B 842 B
Total 45.2 kB 45.3 kB ⚠️ +100 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 715 B 718 B
Total 715 B 718 B ⚠️ +3 B
Build Cache
Canary PR Change
0.pack gzip 4.05 MB 4.06 MB 🔴 +9.25 kB (+0%)
index.pack gzip 103 kB 102 kB 🟢 1.26 kB (-1%)
index.pack.old gzip 101 kB 103 kB 🔴 +1.42 kB (+1%)
Total 4.26 MB 4.26 MB ⚠️ +9.4 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 321 kB 321 kB
app-page-exp..prod.js gzip 170 kB 170 kB
app-page-tur...dev.js gzip 320 kB 320 kB
app-page-tur..prod.js gzip 170 kB 170 kB
app-page-tur...dev.js gzip 317 kB 317 kB
app-page-tur..prod.js gzip 168 kB 168 kB
app-page.run...dev.js gzip 317 kB 317 kB
app-page.run..prod.js gzip 168 kB 168 kB
app-route-ex...dev.js gzip 70.8 kB 70.8 kB
app-route-ex..prod.js gzip 49.3 kB 49.3 kB
app-route-tu...dev.js gzip 70.9 kB 70.9 kB
app-route-tu..prod.js gzip 49.3 kB 49.3 kB
app-route-tu...dev.js gzip 70.5 kB 70.5 kB
app-route-tu..prod.js gzip 49 kB 49 kB
app-route.ru...dev.js gzip 70.4 kB 70.4 kB
app-route.ru..prod.js gzip 49 kB 49 kB
dist_client_...dev.js gzip 324 B 324 B
dist_client_...dev.js gzip 326 B 326 B
dist_client_...dev.js gzip 318 B 318 B
dist_client_...dev.js gzip 317 B 317 B
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB
pages-turbo....dev.js gzip 52.6 kB 52.6 kB
pages-turbo...prod.js gzip 38.5 kB 38.5 kB
pages.runtim...dev.js gzip 52.6 kB 52.6 kB
pages.runtim..prod.js gzip 38.5 kB 38.5 kB
server.runti..prod.js gzip 61.9 kB 62 kB
Total 2.83 MB 2.83 MB ⚠️ +1.19 kB
📝 Changed Files (9 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js
failed to diff
app-page.runtime.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

📎 Tarball URL
https://vercel-packages.vercel.app/next/commits/7784b4432abc01eb388592390c196db0f2711ca1/next

@mmastrac mmastrac changed the title Make turbotask registration const [turbotask] Make turbotask function registration const Mar 3, 2026
@mmastrac mmastrac marked this pull request as ready for review March 3, 2026 16:42
#![feature(sync_unsafe_cell)]
#![feature(async_fn_traits)]
#![feature(impl_trait_in_assoc_type)]
#![feature(const_type_name)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reading through the discussion upstream i don't have a lot of hope for this being stabilized any time soon.
This isn't the biggest deal i guess given all the other nightly features we rely on....

i guess if we really needed to drop it we could always code gen a function that computes the type name and pass a reference to that to the struct? would that work?

Copy link
Contributor Author

@mmastrac mmastrac Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty sure I can get rid of the need for this feature down the line. There's no actual need for it, but it makes this part of the work far easier.

@mmastrac mmastrac merged commit 5719439 into canary Mar 4, 2026
162 of 163 checks passed
@mmastrac mmastrac deleted the mmastrac/const-turbotaskfn branch March 4, 2026 14:17
sokra pushed a commit that referenced this pull request Mar 6, 2026
# What 

Make turbotask function registration const -- all function registration
blocks are true &'static items, compiled directly into the binary.
Removes a few thousand allocations of type names and boxed impls of
TaskFn.

# Why

We have approx 2k functions, so the cost of Lazy construction +
temporary allocations adds up (even with compiler optimization). This
also unlocks the opportunity for further startup optimizations (in later
PRs).

# How

The `#[turbo_tasks::function]` macro now generates static items
initialized directly with const fn constructors instead of `Lazy::new(||
...)`, using `const { &into_task_fn(f) as &dyn TaskFn }` blocks to
produce `&'static dyn TaskFn` trait objects at compile time from
zero-sized function items.

Global names that previously required runtime format!() + Box::leak()
are now computed at compile time via `const_type_name()` (a const
wrapper around `std::any::type_name`) and a `const_concat!` macro that
concatenates string slices into a fixed-size byte array.

The NativeFunction struct, ArgMeta, and the
into_task_fn/into_task_fn_with_this wrappers are all const
fn-constructible, with input types inferred through a TaskFnInputs trait
that maps wrapper types to their argument tuples (we use a non-allocated
and non-compiled temporary "duplicate" `TaskFn` instance that is only
useful for type inference in a const context).

# Next Steps

I believe we can remove the const `type_name` in favour of the const
`type_id` and instead pull function names only when needed for display
purposes. This will show up in a future PR.

We can also remove non-const registration for things that aren't
functions as well, though I believe this is less important.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants