Skip to content

Add Err(anyhow(... -> bail! ast-grep rule#90786

Merged
mmastrac merged 2 commits intommastrac/turbofmtfrom
mmastrac/add-ast-lint
Mar 3, 2026
Merged

Add Err(anyhow(... -> bail! ast-grep rule#90786
mmastrac merged 2 commits intommastrac/turbofmtfrom
mmastrac/add-ast-lint

Conversation

@mmastrac
Copy link
Contributor

@mmastrac mmastrac commented Mar 2, 2026 •
edited
Loading

What

Add an ast-grep rule to use bail! rather than Err(anyhow!( in a return position.

Why

This is slightly more compact, and allows us to port more code over to turbofmt/turbobail.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Mar 2, 2026
@mmastrac mmastrac changed the title Add Err(anyhow(... ast-grep rule Add Err(anyhow(... - ast-grep rule Mar 2, 2026
@mmastrac Graphite App
Copy link
Contributor Author

mmastrac commented Mar 2, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mmastrac mmastrac mentioned this pull request Mar 2, 2026
Merged
@mmastrac mmastrac changed the title Add Err(anyhow(... - ast-grep rule Add Err(anyhow(... -> bail! ast-grep rule Mar 2, 2026
@mmastrac mmastrac marked this pull request as ready for review March 2, 2026 18:30
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 2, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing mmastrac/add-ast-lint (ae4ea80) with mmastrac/turbofmt (3d3eeea)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Mar 2, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 964ms 964ms ✓ ▁▁▁▁▁
Cold (Ready in log) 938ms 943ms ✓ ▁▁▁▁▁
Cold (First Request) 1.755s 1.710s ✓ ▁▂▂▁▂
Warm (Listen) 913ms 964ms ✓ ▁▁▁▁▁
Warm (Ready in log) 915ms 943ms ✓ ▁▁▁▁▁
Warm (First Request) 735ms 708ms ✓ ▁▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 508ms 508ms ✓ ▁▁▁█▁
Cold (Ready in log) 469ms 467ms ✓ ▃▄▃█▁
Cold (First Request) 2.101s 2.065s ✓ ▂▂▂█▁
Warm (Listen) 508ms 508ms ✓ ▁▁▁█▁
Warm (Ready in log) 467ms 467ms ✓ ▄▄▄█▁
Warm (First Request) 2.102s 2.110s ✓ ▂▂▂█▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 6.729s 6.408s ✓ ▁▁▁▁▁
Cached Build 6.262s 6.444s ✓ ▁▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 15.672s 15.611s ✓ ▁▁▁█▁
Cached Build 15.838s 15.710s ✓ ▁▁▁█▁
node_modules Size 476 MB 476 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **401 kB** → **401 kB** ✅ -21 B

80 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 762 B ✓
Total 764 B 762 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 449 B 451 B ✓
Total 449 B 451 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.54 kB N/A -
6280-HASH.js gzip 58.7 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.59 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.59 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.55 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 59.4 kB -
Total 232 kB 233 kB ⚠️ +733 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.5 kB 2.5 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 385 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 255 kB 255 kB ✓
Total 380 kB 380 kB ⚠️ +281 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 616 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 43.8 kB 43.9 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 45.4 kB 45.5 kB ⚠️ +80 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 717 B 718 B ✓
Total 717 B 718 B ⚠️ +1 B
Build Cache
Canary PR Change
0.pack gzip 4.05 MB 4.06 MB 🔴 +10.8 kB (+0%)
index.pack gzip 102 kB 102 kB ✓
index.pack.old gzip 104 kB 102 kB 🟢 1.17 kB (-1%)
Total 4.26 MB 4.27 MB ⚠️ +9.26 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 321 kB 321 kB ✓
app-page-exp..prod.js gzip 170 kB 170 kB ✓
app-page-tur...dev.js gzip 320 kB 320 kB ✓
app-page-tur..prod.js gzip 170 kB 170 kB ✓
app-page-tur...dev.js gzip 317 kB 317 kB ✓
app-page-tur..prod.js gzip 168 kB 168 kB ✓
app-page.run...dev.js gzip 317 kB 317 kB ✓
app-page.run..prod.js gzip 168 kB 168 kB ✓
app-route-ex...dev.js gzip 70.8 kB 70.8 kB ✓
app-route-ex..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.9 kB 70.9 kB ✓
app-route-tu..prod.js gzip 49.3 kB 49.3 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route.ru...dev.js gzip 70.4 kB 70.4 kB ✓
app-route.ru..prod.js gzip 49 kB 49 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.9 kB 32.9 kB ✓
pages-turbo....dev.js gzip 52.6 kB 52.6 kB ✓
pages-turbo...prod.js gzip 38.5 kB 38.5 kB ✓
pages.runtim...dev.js gzip 52.6 kB 52.6 kB ✓
pages.runtim..prod.js gzip 38.5 kB 38.5 kB ✓
server.runti..prod.js gzip 62 kB 62 kB ✓
Total 2.83 MB 2.83 MB ⚠️ +2 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api.runtime.dev.js
  • pages.runtime.dev.js
View diffs
pages-api.runtime.dev.js

Diff too large to display

pages.runtime.dev.js

Diff too large to display

📎 Tarball URL 
https://vercel-packages.vercel.app/next/commits/ae4ea80b12803a63256d57224929a97e70c6f623/next

@mmastrac mmastrac merged commit 3aa4fc8 into mmastrac/turbofmt Mar 3, 2026
162 of 163 checks passed
@mmastrac mmastrac deleted the mmastrac/add-ast-lint branch March 3, 2026 19:58
@mmastrac mmastrac restored the mmastrac/add-ast-lint branch March 4, 2026 14:24
@mmastrac mmastrac mentioned this pull request Mar 4, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mmastrac @nextjs-bot @mischnic