Skip to content

Append deployment id query string for next-font#89960

Merged
mischnic merged 5 commits intocanaryfrom
mischnic/font-preload-dpl-id
Feb 13, 2026
Merged

Append deployment id query string for next-font#89960
mischnic merged 5 commits intocanaryfrom
mischnic/font-preload-dpl-id

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Feb 13, 2026 •
edited
Loading

This caused two requests and the preloading to not be effective at all

#89771 added the dpl id in CSS for url()s

@mischnic Graphite App
Copy link
Member Author

mischnic commented Feb 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic changed the title Extend test Include deployment id query string for preloaded fonts Feb 13, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 13, 2026 •
edited
Loading

Tests Passed

@mischnic mischnic requested a review from a team February 13, 2026 16:00
@mischnic mischnic force-pushed the mischnic/font-preload-dpl-id branch from b5c698d to 33389c4 Compare February 13, 2026 16:00
@mischnic mischnic marked this pull request as ready for review February 13, 2026 16:09
ijjk
ijjk approved these changes Feb 13, 2026
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to check if we have any assertions for the preload URL so this doesn't fail on deploy tests

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 13, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 457ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 457ms 454ms ✓ █▆▇▁▅
Cold (First Request) 894ms 885ms ✓ █▇█▁▇
Warm (Listen) 457ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 457ms 455ms ✓ ▁▁▁▁▁
Warm (First Request) 369ms 368ms ✓ ▄▅▁▁▆
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 507ms 505ms ✓ ▁▅▁▁▁
Cold (Ready in log) 461ms 461ms ✓ ▄▃▁█▃
Cold (First Request) 1.885s 1.912s ✓ ▃▃▁█▃
Warm (Listen) 505ms 505ms ✓ ▁▁▁▁▁
Warm (Ready in log) 461ms 461ms ✓ ▅▅▁██
Warm (First Request) 1.911s 1.888s ✓ ▄▄▁█▆

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.135s 4.188s ✓ ▂▁▁▁▁
Cached Build 4.158s 4.169s ✓ ▁▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.347s 14.425s ✓ ▁▁▃▁▁
Cached Build 14.496s 14.521s ✓ ▁▁▃▂▁
node_modules Size 472 MB 472 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **437 kB** → **437 kB** ⚠️ +7 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 757 B 762 B ✓
Total 757 B 762 B ⚠️ +5 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 448 B ✓
Total 450 B 448 B ✅ -2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 57 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.6 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 253 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.53 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.49 kB -
6948ada0-HASH.js gzip N/A 62.6 kB -
9544-HASH.js gzip N/A 57.7 kB -
Total 231 kB 231 kB ⚠️ +638 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 125 kB ✓
page.js gzip 249 kB 249 kB ✓
Total 374 kB 375 kB ⚠️ +438 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 617 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.6 kB 34.8 kB ⚠️ +148 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 733 B 735 B ✓
Total 733 B 735 B ⚠️ +2 B
Build Cache
Canary PR Change
0.pack gzip 3.83 MB 3.84 MB 🔴 +10.6 kB (+0%)
index.pack gzip 103 kB 103 kB ✓
index.pack.old gzip 102 kB 104 kB 🔴 +1.65 kB (+2%)
Total 4.04 MB 4.05 MB ⚠️ +11.7 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 316 kB 316 kB ✓
app-page-exp..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 315 kB 315 kB ✓
app-page-tur..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 312 kB 312 kB ✓
app-page-tur..prod.js gzip 165 kB 165 kB ✓
app-page.run...dev.js gzip 312 kB 312 kB ✓
app-page.run..prod.js gzip 165 kB 165 kB ✓
app-route-ex...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-ex..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.1 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.8 kB 48.8 kB ✓
app-route.ru...dev.js gzip 70.1 kB 70.1 kB ✓
app-route.ru..prod.js gzip 48.7 kB 48.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 38.4 kB 38.4 kB ✓
pages.runtim...dev.js gzip 52.5 kB 52.5 kB ✓
pages.runtim..prod.js gzip 38.4 kB 38.4 kB ✓
server.runti..prod.js gzip 63.5 kB 63.5 kB ✓
Total 2.79 MB 2.79 MB ⚠️ +18 B
📝 Changed Files (8 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

@nextjs-bot nextjs-bot added the Font (next/font) Related to Next.js Font Optimization. label Feb 13, 2026
@mischnic Graphite App
Copy link
Member Author

mischnic commented Feb 13, 2026

I started a deploy test run: https://github.com/vercel/next.js/actions/runs/21995384176

@ijjk
Copy link
Member

ijjk commented Feb 13, 2026

Meant more of a fuzzy search for preload checks just as quick pass before canary

@mischnic mischnic changed the title Include deployment id query string for preloaded fonts Append deployment id query string for next-font Feb 13, 2026
@mischnic mischnic merged commit 7784b11 into canary Feb 13, 2026
170 of 172 checks passed
@mischnic Graphite App
Copy link
Member Author

mischnic commented Feb 13, 2026

Merge activity

@mischnic mischnic deleted the mischnic/font-preload-dpl-id branch February 13, 2026 18:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gnoff gnoff gnoff approved these changes

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Font (next/font) Related to Next.js Font Optimization. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mischnic @nextjs-bot @ijjk @gnoff @timneutkens