Skip to content

Fix deployment id header when proxying#89593

Merged
mischnic merged 9 commits intocanaryfrom
mischnic/fix-dpl-id-header-proxying
Feb 6, 2026
Merged

Fix deployment id header when proxying#89593
mischnic merged 9 commits intocanaryfrom
mischnic/fix-dpl-id-header-proxying

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Feb 6, 2026 •
edited
Loading

When proxying through multiple projects, this header would get overwritten by the proxy project:

  • the header would be the proxy's deployment id
  • process.env.NEXT_DEPLOYMENT_ID would be the origin's deployment id

Needs vercel/vercel#14903

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. type: next labels Feb 6, 2026
@mischnic Graphite App
Copy link
Member Author

mischnic commented Feb 6, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic marked this pull request as ready for review February 6, 2026 11:01
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 6, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 6, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 506ms 505ms ✓ ▁▁▁▁▁
Cold (Ready in log) 463ms 462ms ✓ ▅▅▅▅▅
Cold (First Request) 907ms 916ms ✓ ▇▇▇▇▇
Warm (Listen) 459ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 461ms 459ms ✓ ▁▁▁▁▁
Warm (First Request) 371ms 385ms ✓ ▂▄▁▂▄
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █▁▁▄▁
Cold (Ready in log) 439ms 439ms ✓ █▁▃▄▄
Cold (First Request) 1.871s 1.870s ✓ ▇▁▂▂▂
Warm (Listen) 456ms 456ms ✓ █▁▁▄▁
Warm (Ready in log) 438ms 439ms ✓ █▁▃▃▂
Warm (First Request) 1.875s 1.861s ✓ █▁▂▂▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.518s 4.488s ✓ ▁▁▁▁▁
Cached Build 4.498s 4.510s ✓ ▁▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.887s 13.871s ✓ █▁▁▂▁
Cached Build 14.020s 13.988s ✓ █▁▁▂▁
node_modules Size 467 MB 467 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **437 kB** → **437 kB** ⚠️ +5 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 762 B 758 B ✓
Total 762 B 758 B ✅ -4 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 448 B 449 B ✓
Total 448 B 449 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 56.9 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 57.5 kB -
Total 230 kB 231 kB ⚠️ +614 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 249 kB 249 kB ✓
Total 375 kB 375 kB ⚠️ +489 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 615 B 617 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33 kB 33 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.6 kB 34.6 kB ⚠️ +56 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.84 MB 3.85 MB 🔴 +10.2 kB (+0%)
index.pack gzip 103 kB 104 kB 🔴 +1.57 kB (+2%)
index.pack.old gzip 103 kB 103 kB ✓
Total 4.05 MB 4.06 MB ⚠️ +12.1 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 315 kB 315 kB ✓
app-page-exp..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 315 kB 315 kB ✓
app-page-tur..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 312 kB 312 kB ✓
app-page-tur..prod.js gzip 165 kB 165 kB ✓
app-page.run...dev.js gzip 312 kB 312 kB ✓
app-page.run..prod.js gzip 165 kB 165 kB ✓
app-route-ex...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-ex..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.1 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.8 kB 48.8 kB ✓
app-route.ru...dev.js gzip 70.1 kB 70.1 kB ✓
app-route.ru..prod.js gzip 48.7 kB 48.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 39.4 kB 39.4 kB ✓
pages.runtim...dev.js gzip 52.5 kB 52.5 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.3 kB ✓
server.runti..prod.js gzip 62.7 kB 62.7 kB ✓
Total 2.8 MB 2.8 MB ✅ -2 B

@mischnic mischnic force-pushed the mischnic/fix-dpl-id-header-proxying branch from 195f547 to 2b80f8d Compare February 6, 2026 14:37
@mischnic mischnic force-pushed the mischnic/fix-dpl-id-header-proxying branch from 2b80f8d to cd8dd91 Compare February 6, 2026 14:43
mischnic
mischnic commented Feb 6, 2026
View reviewed changes
@mischnic mischnic force-pushed the mischnic/fix-dpl-id-header-proxying branch from 6ecf897 to 0e343e7 Compare February 6, 2026 15:06
@mischnic mischnic mentioned this pull request Feb 6, 2026
Merged
ijjk
ijjk reviewed Feb 6, 2026
View reviewed changes
@mischnic @ijjk
fix next start
8227268 
Co-Authored-By: JJ Kasper <jj@jjsweb.site>
@mischnic mischnic force-pushed the mischnic/fix-dpl-id-header-proxying branch from 865c427 to 8227268 Compare February 6, 2026 15:57
mischnic added a commit to vercel/vercel that referenced this pull request Feb 6, 2026
@mischnic
[next] Apply routes-manifest onMatchHeaders (#14903)
a172b3c 
Corresponds to vercel/next.js#89593
This was referenced Feb 6, 2026
Merged
Merged
ijjk pushed a commit to vercel/vercel that referenced this pull request Feb 6, 2026
@mischnic
[next] Strip routes-manifest.json for determinism more (#14908)
8520612 
For vercel/next.js#89593
@mischnic mischnic merged commit 522de8c into canary Feb 6, 2026
674 of 684 checks passed
@mischnic Graphite App
Copy link
Member Author

mischnic commented Feb 6, 2026

Merge activity

@mischnic mischnic deleted the mischnic/fix-dpl-id-header-proxying branch February 6, 2026 19:34
@ijjk ijjk mentioned this pull request Feb 7, 2026
Merged
ijjk added a commit to vercel/vercel that referenced this pull request Feb 7, 2026
@ijjk
Update next-local integration assertion for canary (#14929)
f639e57 
x-ref: vercel/next.js#89593
x-ref:
https://github.com/vercel/vercel/actions/runs/21770841404/job/62817996025?pr=14913
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk ijjk approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mischnic @nextjs-bot @timneutkens @ijjk