Skip to content

Ensure _middleware is consistent in adapter for name/id#89559

Merged
ijjk merged 1 commit intocanaryfrom
ijjk/middleware-id-name
Feb 5, 2026
Merged

Ensure _middleware is consistent in adapter for name/id#89559
ijjk merged 1 commit intocanaryfrom
ijjk/middleware-id-name

Conversation

@ijjk
Copy link
Member

@ijjk ijjk commented Feb 5, 2026 •
edited
Loading

Makes sure we don't use both _middleware and middleware naming for the output.

Found in #89522 we were using both.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Feb 5, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 506ms 506ms ✓ ▁▁▁▁█
Cold (Ready in log) 460ms 461ms ✓ ▃▁▅▄▇
Cold (First Request) 1.892s 1.921s ✓ ▁▁▃▁▇
Warm (Listen) 506ms 507ms ✓ ▁▁▁▁█
Warm (Ready in log) 461ms 461ms ✓ ▄▁▆▄▇
Warm (First Request) 1.952s 1.923s ✓ ▂▁▃▂█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.483s 14.491s ✓ ▁▁▁▁█
Cached Build 14.610s 14.601s ✓ ▁▁▁▁█
node_modules Size 467 MB 467 MB ✓ ▅████
📦 Bundle Sizes

Bundle Sizes

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 56.9 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 254 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 57.5 kB -
Total 230 kB 231 kB ⚠️ +607 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 249 kB 249 kB ✓
Total 375 kB 375 kB ⚠️ +483 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 614 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33 kB 33 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.6 kB 34.6 kB ⚠️ +28 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.84 MB 3.85 MB 🔴 +9.66 kB (+0%)
index.pack gzip 104 kB 103 kB ✓
index.pack.old gzip 103 kB 105 kB 🔴 +1.9 kB (+2%)
Total 4.05 MB 4.06 MB ⚠️ +10.8 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 315 kB 315 kB ✓
app-page-exp..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 315 kB 315 kB ✓
app-page-tur..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 312 kB 312 kB ✓
app-page-tur..prod.js gzip 165 kB 165 kB ✓
app-page.run...dev.js gzip 312 kB 312 kB ✓
app-page.run..prod.js gzip 165 kB 165 kB ✓
app-route-ex...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-ex..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.1 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.8 kB 48.8 kB ✓
app-route.ru...dev.js gzip 70.1 kB 70.1 kB ✓
app-route.ru..prod.js gzip 48.7 kB 48.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 39.4 kB 39.4 kB ✓
pages.runtim...dev.js gzip 52.4 kB 52.4 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.3 kB ✓
server.runti..prod.js gzip 62.7 kB 62.7 kB ✓
Total 2.8 MB 2.8 MB ⚠️ +2 B

@ijjk ijjk merged commit 7b2a467 into canary Feb 5, 2026
159 of 160 checks passed
@ijjk ijjk deleted the ijjk/middleware-id-name branch February 5, 2026 23:53
bgub pushed a commit to bgub/next.js that referenced this pull request Feb 6, 2026
@ijjk @bgub
Ensure _middleware is consistent in adapter for name/id (vercel#89559)
fd0084b 
Makes sure we don't use both `_middleware` and `middleware` naming for
the output.

Found in vercel#89522 we were using
both.
ijjk added a commit that referenced this pull request Feb 7, 2026
@ijjk
Revert "Ensure _middleware is consistent in adapter for name/id (#89559…
7ccc802 
…)"

This reverts commit 7b2a467.
@ijjk ijjk mentioned this pull request Feb 7, 2026
Merged
ijjk added a commit that referenced this pull request Feb 7, 2026
@ijjk
Revert "Ensure _middleware is consistent in adapter for name/id" (#89624
09851e2 
)

This is causing conflicts as the name value is relied on too much since
it can differ heavily e.g. for `src` dir and if not.

x-ref:
https://github.com/vercel/next.js/actions/runs/21767409431/job/62826336354#step:34:240

Reverts #89559
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mischnic mischnic mischnic approved these changes

@feedthejim feedthejim Awaiting requested review from feedthejim

@devjiwonchoi devjiwonchoi Awaiting requested review from devjiwonchoi

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ijjk @nextjs-bot @mischnic