Revert "Replace build id in Pages data routes with deployment id (#88959)"#89323
Revert "Replace build id in Pages data routes with deployment id (#88959)"#89323
Conversation
)" This reverts commit 6766a27.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Failing test suitesCommit: 6630f50 | About building and testing Next.js
Expand output● app dir client cache with parallel routes › prefetch={true} › should re-use the cache for the full page, only for 5 mins
Expand output● Test suite failed to run |
Stats from current PR🟢 1 improvement
📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **435 kB** → **434 kB** ✅ -171 B81 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (25 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsfailed to diffapp-page-exp..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsfailed to diffapp-page-tur..time.prod.jsDiff too large to display app-page.runtime.dev.jsfailed to diffapp-page.runtime.prod.jsDiff too large to display app-route-ex..ntime.dev.jsDiff too large to display app-route-ex..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route.runtime.dev.jsDiff too large to display app-route.ru..time.prod.jsDiff too large to display pages-api-tu..ntime.dev.jsDiff too large to display pages-api-tu..time.prod.jsDiff too large to display pages-api.runtime.dev.jsDiff too large to display pages-api.ru..time.prod.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages-turbo...time.prod.jsDiff too large to display pages.runtime.dev.jsDiff too large to display pages.runtime.prod.jsDiff too large to display server.runtime.prod.jsDiff too large to display |
Reapply #88959 Revert #89323 Closes PACK-6537 Closes PACK-6756 - Deployment skew (forcing a MPA nav instead of a SPA nav if a deployment happened inbetween) is handled by comparing a header on the client side. - The other case that used build ids was app router, which was changed to the same approach in #88855 - Then, when a deployment id is available, make the build id a constant - Particularly, this makes the rollout of this much easier as the data route paths stay the same (both in Next.js itself as well as in the builder) If you use `output:export` and set `config.deploymentId` (i.e. enable skew protection) you are still expected to set these headers.
…cel#88959)" (vercel#89323) `test/e2e/middleware-redirects` has 404s on the data route
…l#89325) Reapply vercel#88959 Revert vercel#89323 Closes PACK-6537 Closes PACK-6756 - Deployment skew (forcing a MPA nav instead of a SPA nav if a deployment happened inbetween) is handled by comparing a header on the client side. - The other case that used build ids was app router, which was changed to the same approach in vercel#88855 - Then, when a deployment id is available, make the build id a constant - Particularly, this makes the rollout of this much easier as the data route paths stay the same (both in Next.js itself as well as in the builder) If you use `output:export` and set `config.deploymentId` (i.e. enable skew protection) you are still expected to set these headers.

test/e2e/middleware-redirectshas 404s on the data route