Inline handler dependencies instead of tracing#89269
Merged
Conversation
Collaborator
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **435 kB** → **435 kB** ✓81 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
📝 Changed Files (24 files)Files with changes:
View diffsapp-page-exp..ntime.dev.jsDiff too large to display app-page-exp..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsDiff too large to display app-page-tur..time.prod.jsDiff too large to display app-page-tur..ntime.dev.jsDiff too large to display app-page-tur..time.prod.jsDiff too large to display app-page.runtime.dev.jsDiff too large to display app-page.runtime.prod.jsDiff too large to display app-route-ex..ntime.dev.jsDiff too large to display app-route-ex..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route-tu..ntime.dev.jsDiff too large to display app-route-tu..time.prod.jsDiff too large to display app-route.runtime.dev.jsDiff too large to display app-route.ru..time.prod.jsDiff too large to display pages-api-tu..ntime.dev.jsDiff too large to display pages-api-tu..time.prod.jsDiff too large to display pages-api.runtime.dev.jsDiff too large to display pages-api.ru..time.prod.jsDiff too large to display pages-turbo...ntime.dev.jsDiff too large to display pages-turbo...time.prod.jsDiff too large to display pages.runtime.dev.jsDiff too large to display pages.runtime.prod.jsDiff too large to display |
6b97780 to
a00eb64
Compare
a00eb64 to
1183c48
Compare
226eb80 to
73be352
Compare
Merging this PR will not alter performance
Comparing 
Footnotes
|
73be352 to
1efa09b
Compare
1efa09b to
e83b120
Compare
e83b120 to
5f45b5c
Compare
5f45b5c to
3e9a738
Compare
3e9a738 to
fc378d1
Compare
fc378d1 to
ffdf58d
Compare
ztanner
approved these changes
Jan 30, 2026
mischnic
reviewed
Jan 30, 2026
| "/node_modules/@swc/helpers/*", | ||
| "/node_modules/client-only/*", | ||
| "/node_modules/detect-libc/*", | ||
| "/node_modules/next/dist/build/adapter/setup-node-env.external.js", |
Member
There was a problem hiding this comment.
Should this file also be used as an external in minimal mode?
Because I'd have expected it to show up in the other snapshot down below as well then
Member
Author
There was a problem hiding this comment.
The code path that pulls this in is dead code eliminated in next-minimal-server
ijjk
added a commit
that referenced
this pull request
Feb 2, 2026
Partial revert of #89269 the additional tracing is still necessary for webpack so this re-adds that and removes the silent failing to register require-hook. E2E deploy tests run https://github.com/vercel/next.js/actions/runs/21599777917
bgub
pushed a commit
to bgub/next.js
that referenced
this pull request
Feb 5, 2026
Partial revert of vercel#89269 the additional tracing is still necessary for webpack so this re-adds that and removes the silent failing to register require-hook. E2E deploy tests run https://github.com/vercel/next.js/actions/runs/21599777917
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates to remove extra tracing that was being done in
build-completefor deployment adapters to allow importing internalnode-environmentmodules. Instead this exposesnext/setup-node-envto adapters outputs that can be used instead and are traced through our normal bundling/tracing flow.