Skip to content

Turbopack: refactor extend transforms#89116

Merged
sokra merged 8 commits intocanaryfrom
sokra/refactor-module-rules
Jan 30, 2026
Merged

Turbopack: refactor extend transforms#89116
sokra merged 8 commits intocanaryfrom
sokra/refactor-module-rules

Conversation

@sokra
Copy link
Member

@sokra sokra commented Jan 27, 2026 •
edited
Loading

What?

Stop rules when module type is set.
Apply ecmascript transforms before module type is set. (no more errors when trying to apply a transform on non-ecmascript type)
Fix ordering of transform apply.
Reorder module rules to match previous order. They are applied in order now.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 27, 2026
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 27, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sokra sokra mentioned this pull request Jan 27, 2026
Merged
vercel[bot]
vercel bot reviewed Jan 27, 2026
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing sokra/refactor-module-rules (1c8e8c6) with canary (5eb6eef)

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@sokra sokra force-pushed the sokra/refactor-module-rules branch 2 times, most recently from 8c8f749 to 3c9f141 Compare January 28, 2026 12:20
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 28, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 28, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 506ms 506ms ✓ ▁█▁▁▁
Cold (Ready in log) 465ms 466ms ✓ ▇█▇▅▇
Cold (First Request) 828ms 828ms ✓ ▇█▇▆▇
Warm (Listen) 505ms 507ms ✓ ▁█▁▁▁
Warm (Ready in log) 467ms 465ms ✓ ▁█▁▁▁
Warm (First Request) 339ms 332ms ✓ █▂▆▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 437ms 439ms ✓ ▁▁▁▁▁
Cold (First Request) 1.843s 1.859s ✓ ▁▁▁▁▁
Warm (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Warm (Ready in log) 439ms 437ms ✓ ▁▁▁▁▁
Warm (First Request) 1.857s 1.847s ✓ ▁▁▁▁▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.117s 4.068s ✓ ▂█▂▁▂
Cached Build 4.099s 4.140s ✓ ▂█▂▁▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.736s 13.703s ✓ ▁▁▅▁▁
Cached Build 13.772s 13.813s ✓ ▁▁▁▁▁
node_modules Size 463 MB 463 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **434 kB** → **434 kB** ⚠️ +7 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 766 B ✓
Total 764 B 766 B ⚠️ +2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 451 B ✓
Total 450 B 451 B ⚠️ +1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 54.4 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 256 B 254 B ✓
main-HASH.js gzip 39 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 55.1 kB -
Total 228 kB 228 kB ⚠️ +690 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 247 kB 248 kB ✓
Total 374 kB 374 kB ⚠️ +331 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 614 B 613 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 32.9 kB 33.1 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.5 kB 34.8 kB ⚠️ +215 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.76 MB 3.77 MB 🔴 +7.6 kB (+0%)
index.pack gzip 102 kB 102 kB ✓
index.pack.old gzip 102 kB 102 kB ✓
Total 3.97 MB 3.97 MB ⚠️ +8.57 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 311 kB 311 kB ✓
app-page-exp..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 311 kB 311 kB ✓
app-page-tur..prod.js gzip 166 kB 166 kB ✓
app-page-tur...dev.js gzip 307 kB 307 kB ✓
app-page-tur..prod.js gzip 164 kB 164 kB ✓
app-page.run...dev.js gzip 307 kB 307 kB ✓
app-page.run..prod.js gzip 164 kB 164 kB ✓
app-route-ex...dev.js gzip 70.2 kB 70.2 kB ✓
app-route-ex..prod.js gzip 48.8 kB 48.8 kB ✓
app-route-tu...dev.js gzip 70.2 kB 70.2 kB ✓
app-route-tu..prod.js gzip 48.8 kB 48.8 kB ✓
app-route-tu...dev.js gzip 69.8 kB 69.8 kB ✓
app-route-tu..prod.js gzip 48.6 kB 48.6 kB ✓
app-route.ru...dev.js gzip 69.8 kB 69.8 kB ✓
app-route.ru..prod.js gzip 48.6 kB 48.6 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api-tu..prod.js gzip 32.8 kB 32.8 kB ✓
pages-api.ru...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.4 kB 52.4 kB ✓
pages-turbo...prod.js gzip 39.3 kB 39.3 kB ✓
pages.runtim...dev.js gzip 52.3 kB 52.3 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.3 kB ✓
server.runti..prod.js gzip 62.5 kB 62.5 kB ✓
Total 2.77 MB 2.77 MB ✓

@sokra sokra force-pushed the sokra/refactor-module-rules branch from 3c9f141 to f35ef5b Compare January 28, 2026 16:07
sokra
sokra commented Jan 29, 2026
View reviewed changes
@sokra sokra force-pushed the sokra/refactor-module-rules branch 2 times, most recently from 1f3b5cb to abcd9a5 Compare January 29, 2026 12:15
@sokra sokra marked this pull request as ready for review January 29, 2026 12:20
@sokra sokra requested review from bgw and mischnic January 29, 2026 12:21
@sokra sokra force-pushed the sokra/refactor-module-rules branch from abcd9a5 to 1c8e8c6 Compare January 30, 2026 10:36
mischnic
mischnic reviewed Jan 30, 2026
View reviewed changes
@sokra Graphite App
Copy link
Member Author

sokra commented Jan 30, 2026 •
edited
Loading

Merge activity

  • Jan 30, 2:32 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 30, 2:32 PM UTC: @sokra merged this pull request with Graphite.

@sokra sokra merged commit 0ed1edd into canary Jan 30, 2026
165 checks passed
@sokra sokra deleted the sokra/refactor-module-rules branch January 30, 2026 14:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 14, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@mischnic mischnic mischnic approved these changes

@bgw bgw Awaiting requested review from bgw

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sokra @nextjs-bot @mischnic