Create a new compaction mechanism to ensure the TaskCache functions properly#89075
Create a new compaction mechanism to ensure the TaskCache functions properly#89075lukesandberg wants to merge 2 commits intofamily_size_configurationfrom
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
922a7d8 to
9ae341f
Compare
dd53faa to
7d26e47
Compare
Merging this PR will not alter performance
Comparing Footnotes
|
9ae341f to
fd272b9
Compare
7d26e47 to
1e4f1a8
Compare
fd272b9 to
4daa326
Compare
1e4f1a8 to
d8f3fce
Compare
4daa326 to
ec1dad5
Compare
d8f3fce to
8e911a5
Compare
ec1dad5 to
f502c31
Compare
26a17ab to
fdb39f1
Compare
f502c31 to
cc8a6aa
Compare
Failing test suitesCommit: a0ba566 | About building and testing Next.js
Expand output● Test suite failed to run |
fdb39f1 to
a0ba566
Compare
a0ba566 to
c34eeaa
Compare
ebe3e36 to
d482259
Compare
Stats from current PR✅ No significant changes detected📊 All Metrics📖 Metrics GlossaryDev Server Metrics:
Build Metrics:
Change Thresholds:
⚡ Dev Server
📦 Dev Server (Webpack) (Legacy)📦 Dev Server (Webpack)
⚡ Production Builds
📦 Production Builds (Webpack) (Legacy)📦 Production Builds (Webpack)
📦 Bundle SizesBundle Sizes⚡ TurbopackClient Main Bundles: **437 kB** → **437 kB** ✅ -1 B81 files with content-based hashes (individual files not comparable between builds) Server Middleware
Build DetailsBuild Manifests
📦 WebpackClient Main Bundles
Polyfills
Pages
Server Edge SSR
Middleware
Build DetailsBuild Manifests
Build Cache
🔄 Shared (bundler-independent)Runtimes
|
sokra
left a comment
There was a problem hiding this comment.
That MUST be part of #88904, otherwise it's incorrect and would corrupt the cache during compaction.
But I think we shouldn't have a family config for that, but encode this in a bit of the value type. This way you could also mix set values with normal values. See my comment on 88904.
c34eeaa to
b044b58
Compare
d482259 to
49f013c
Compare

When compacting TaskCache data, dedup by key and value. Ensure SSTs break sorting ties by value so that merging works correctly.