Skip to content

Proper e2e test of function determinism#88908

Merged
mischnic merged 5 commits intocanaryfrom
mischnic/test-determinism-builder
Feb 5, 2026
Merged

Proper e2e test of function determinism#88908
mischnic merged 5 commits intocanaryfrom
mischnic/test-determinism-builder

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Jan 22, 2026 •
edited
Loading

Using the Vercel builder to get an authoritative list of files that end up in the function.

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. tests labels Jan 22, 2026
@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 22, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic changed the title feat: implement LRU cache with invocation ID scoping for minimal mode response cache (#88509) Proper e2e test of function determinism Jan 22, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 22, 2026 •
edited
Loading

Tests Passed

vercel[bot]
vercel bot reviewed Jan 22, 2026
View reviewed changes
@mischnic mischnic changed the base branch from canary to graphite-base/88908 January 27, 2026 19:43
@mischnic mischnic force-pushed the mischnic/test-determinism-builder branch from b8cefc9 to 0e334fd Compare January 27, 2026 19:43
@mischnic mischnic changed the base branch from graphite-base/88908 to mischnic/remove-build-id January 27, 2026 19:43
This was referenced Jan 27, 2026
Merged
Merged
Merged
Closed
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 27, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 457ms 456ms ✓ ▁▁▁▁█
Cold (Ready in log) 443ms 443ms ✓ ▁▇▂▆▆
Cold (First Request) 815ms 815ms ✓ ▁█▂█▃
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁█
Warm (Ready in log) 442ms 442ms ✓ ▁▂▃▁█
Warm (First Request) 348ms 344ms ✓ ▅██▅▄
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▁▁██▁
Cold (Ready in log) 438ms 438ms ✓ ▇▆█▆▄
Cold (First Request) 1.853s 1.858s ✓ ▄▃█▅▂
Warm (Listen) 456ms 456ms ✓ ▁▁██▁
Warm (Ready in log) 438ms 438ms ✓ ▅▆█▆▄
Warm (First Request) 1.856s 1.865s ✓ ▃▃█▆▂

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.091s 4.034s ✓ ▂▂▆▁█
Cached Build 4.052s 4.063s ✓ ▃▂▆▁█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.843s 13.833s ✓ ▁▁█▆▁
Cached Build 13.867s 13.914s ✓ ▁▁█▆▁
node_modules Size 465 MB 465 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **437 kB** → **437 kB** ✅ -2 B

81 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 762 B ✓
Total 764 B 762 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 452 B 451 B ✓
Total 452 B 451 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
5528-HASH.js gzip 5.47 kB N/A -
6280-HASH.js gzip 56.9 kB N/A -
6335.HASH.js gzip 169 B N/A -
912-HASH.js gzip 4.53 kB N/A -
e8aec2e4-HASH.js gzip 62.5 kB N/A -
framework-HASH.js gzip 59.7 kB 59.7 kB ✓
main-app-HASH.js gzip 255 B 253 B ✓
main-HASH.js gzip 39.1 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
262-HASH.js gzip N/A 4.52 kB -
2889.HASH.js gzip N/A 169 B -
5602-HASH.js gzip N/A 5.48 kB -
6948ada0-HASH.js gzip N/A 62.5 kB -
9544-HASH.js gzip N/A 57.5 kB -
Total 230 kB 231 kB ⚠️ +606 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 194 B ✓
_error-HASH.js gzip 183 B 180 B 🟢 3 B (-2%)
css-HASH.js gzip 331 B 330 B ✓
dynamic-HASH.js gzip 1.81 kB 1.81 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 351 B 352 B ✓
hooks-HASH.js gzip 384 B 383 B ✓
image-HASH.js gzip 580 B 581 B ✓
index-HASH.js gzip 260 B 260 B ✓
link-HASH.js gzip 2.49 kB 2.49 kB ✓
routerDirect..HASH.js gzip 320 B 319 B ✓
script-HASH.js gzip 386 B 386 B ✓
withRouter-HASH.js gzip 315 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.97 kB ✅ -1 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 126 kB 126 kB ✓
page.js gzip 249 kB 249 kB ✓
Total 375 kB 375 kB ⚠️ +117 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 615 B 615 B ✓
middleware-r..fest.js gzip 156 B 155 B ✓
middleware.js gzip 33.3 kB 33.1 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.9 kB 34.8 kB ✅ -134 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 732 B 736 B ✓
Total 732 B 736 B ⚠️ +4 B
Build Cache
Canary PR Change
0.pack gzip 3.84 MB 3.85 MB 🔴 +6.42 kB (+0%)
index.pack gzip 101 kB 104 kB 🔴 +3.34 kB (+3%)
index.pack.old gzip 104 kB 104 kB ✓
Total 4.05 MB 4.06 MB ⚠️ +9.13 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 313 kB 313 kB ✓
app-page-exp..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 313 kB 313 kB ✓
app-page-tur..prod.js gzip 167 kB 167 kB ✓
app-page-tur...dev.js gzip 309 kB 309 kB ✓
app-page-tur..prod.js gzip 165 kB 165 kB ✓
app-page.run...dev.js gzip 310 kB 310 kB ✓
app-page.run..prod.js gzip 165 kB 165 kB ✓
app-route-ex...dev.js gzip 70.4 kB 70.4 kB ✓
app-route-ex..prod.js gzip 48.9 kB 48.9 kB ✓
app-route-tu...dev.js gzip 70.5 kB 70.5 kB ✓
app-route-tu..prod.js gzip 49 kB 49 kB ✓
app-route-tu...dev.js gzip 70.1 kB 70.1 kB ✓
app-route-tu..prod.js gzip 48.7 kB 48.7 kB ✓
app-route.ru...dev.js gzip 70 kB 70 kB ✓
app-route.ru..prod.js gzip 48.7 kB 48.7 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 43.2 kB 43.2 kB ✓
pages-api-tu..prod.js gzip 32.9 kB 32.9 kB ✓
pages-api.ru...dev.js gzip 43.1 kB 43.1 kB ✓
pages-api.ru..prod.js gzip 32.8 kB 32.8 kB ✓
pages-turbo....dev.js gzip 52.5 kB 52.5 kB ✓
pages-turbo...prod.js gzip 39.4 kB 39.4 kB ✓
pages.runtim...dev.js gzip 52.4 kB 52.4 kB ✓
pages.runtim..prod.js gzip 39.3 kB 39.3 kB ✓
server.runti..prod.js gzip 62.7 kB 62.7 kB ✓
Total 2.79 MB 2.79 MB ✅ -5 B

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 27, 2026 •
edited
Loading

CodSpeed Performance Report

Merging this PR will not alter performance

Comparing mischnic/test-determinism-builder (27bf472) with mischnic/reapply-pages-buildid (b5483b8)1

Summary

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks2

Footnotes

  1. No successful run was found on mischnic/reapply-pages-buildid (f7f0c15) during the generation of this report, so 189e309 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

  2. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@mischnic mischnic changed the base branch from mischnic/remove-build-id to graphite-base/88908 January 28, 2026 09:04
@mischnic mischnic force-pushed the mischnic/test-determinism-builder branch from 0e334fd to 383f44e Compare January 28, 2026 10:16
@mischnic mischnic force-pushed the graphite-base/88908 branch from 18645bb to 02d8ff2 Compare January 28, 2026 10:16
@mischnic mischnic changed the base branch from graphite-base/88908 to canary January 28, 2026 10:17
@mischnic mischnic changed the base branch from canary to graphite-base/88908 February 3, 2026 20:14
@mischnic mischnic force-pushed the mischnic/test-determinism-builder branch from 383f44e to 27bf472 Compare February 3, 2026 20:14
@mischnic mischnic changed the base branch from graphite-base/88908 to mischnic/reapply-pages-buildid February 3, 2026 20:14
@mischnic mischnic mentioned this pull request Feb 3, 2026
Merged
vercel[bot]
vercel bot reviewed Feb 3, 2026
View reviewed changes
@mischnic mischnic force-pushed the mischnic/test-determinism-builder branch from 27bf472 to 333017c Compare February 4, 2026 09:07
@mischnic mischnic changed the base branch from mischnic/reapply-pages-buildid to graphite-base/88908 February 4, 2026 17:07
@mischnic mischnic force-pushed the graphite-base/88908 branch from f7f0c15 to 49e0a8a Compare February 4, 2026 17:08
@mischnic mischnic force-pushed the mischnic/test-determinism-builder branch from 333017c to eee2849 Compare February 4, 2026 17:08
@graphite-app graphite-app bot changed the base branch from graphite-base/88908 to canary February 4, 2026 17:08
@mischnic mischnic force-pushed the mischnic/test-determinism-builder branch from eee2849 to cb54700 Compare February 4, 2026 17:08
@mischnic mischnic force-pushed the mischnic/test-determinism-builder branch from cb54700 to 2dfba83 Compare February 5, 2026 08:26
@mischnic mischnic marked this pull request as ready for review February 5, 2026 08:34
@mischnic mischnic mentioned this pull request Feb 5, 2026
Merged
@mischnic mischnic requested a review from a team February 5, 2026 08:34
@mischnic mischnic merged commit 2842212 into canary Feb 5, 2026
289 of 291 checks passed
@mischnic mischnic deleted the mischnic/test-determinism-builder branch February 5, 2026 13:26
bgub pushed a commit to bgub/next.js that referenced this pull request Feb 5, 2026
@mischnic @bgub
Proper e2e test of function determinism (vercel#88908)
1f893df 
Using the Vercel builder to get an authoritative list of files that end up in the function.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@sokra sokra sokra approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @nextjs-bot @sokra