Skip to content

Remove deploymentId from App Router RenderOptsPartial#88866

Merged
mischnic merged 2 commits intocanaryfrom
mischnic/cleanup-contexts
Jan 22, 2026
Merged

Remove deploymentId from App Router RenderOptsPartial#88866
mischnic merged 2 commits intocanaryfrom
mischnic/cleanup-contexts

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Jan 21, 2026 •
edited
Loading

There should only be a single place for it now (ctx.sharedContext.deploymentId)

@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 21, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic changed the title cleanup Refactor to read build and deployment id from renderOpts instead Jan 21, 2026
@mischnic mischnic marked this pull request as ready for review January 21, 2026 22:19
@mischnic mischnic requested a review from a team January 21, 2026 22:19
vercel[bot]
vercel bot reviewed Jan 21, 2026
View reviewed changes
Copy link
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

app-route module accesses buildId from sharedContext while rest of codebase uses renderOpts, causing inconsistency and potential issues with missing buildId in edge runtime

Fix on Vercel

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 21, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 453ms 456ms ✓ ▁▁▁▁▂
Cold (First Request) 843ms 842ms ✓ ▁▁▃▁▃
Warm (Listen) 456ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 455ms 455ms ✓ ▁▁▁▁▁
Warm (First Request) 368ms 363ms ✓ ▁▂▁▂▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 438ms 438ms ✓ ▁▁▁▁▁
Cold (First Request) 1.738s 1.740s ✓ ▁▁▁▁▁
Warm (Listen) 456ms 455ms ✓ ▁▁▁▁▁
Warm (Ready in log) 438ms 438ms ✓ ▁▁▁▁▁
Warm (First Request) 1.755s 1.771s ✓ ▁▁▁▁▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.564s 4.484s ✓ ▂▂▁▁▁
Cached Build 4.637s 4.510s ✓ ▂▂▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.026s 14.035s ✓ ▁▆▃▄▂
Cached Build 14.122s 14.146s ✓ ▁▇▃▄▄
node_modules Size 460 MB 460 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **432 kB** → **432 kB** ✅ -61 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 764 B 762 B ✓
Total 764 B 762 B ✅ -2 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 450 B ✓
Total 451 B 450 B ✅ -1 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.7 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.7 kB 39.1 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.4 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 226 kB 226 kB ⚠️ +55 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 243 kB 239 kB 🟢 4.87 kB (-2%)
Total 368 kB 363 kB ✅ -4.85 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 616 B 618 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33 kB 33.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.9 kB ⚠️ +261 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.68 MB 3.69 MB 🔴 +5.63 kB (+0%)
index.pack gzip 101 kB 102 kB 🔴 +1.04 kB (+1%)
index.pack.old gzip 101 kB 101 kB ✓
Total 3.89 MB 3.89 MB ⚠️ +6.52 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 305 kB 305 kB ✓
app-page-exp..prod.js gzip 162 kB 162 kB ✓
app-page-tur...dev.js gzip 305 kB 305 kB ✓
app-page-tur..prod.js gzip 162 kB 162 kB ✓
app-page-tur...dev.js gzip 302 kB 302 kB ✓
app-page-tur..prod.js gzip 160 kB 160 kB ✓
app-page.run...dev.js gzip 302 kB 302 kB ✓
app-page.run..prod.js gzip 160 kB 160 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.4 kB 47.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.8 kB 50.8 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.71 MB 2.71 MB ⚠️ +29 B
📝 Changed Files (11 files)

Files with changes:

  • app-page-exp..ntime.dev.js
  • app-page-exp..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page-tur..ntime.dev.js
  • app-page-tur..time.prod.js
  • app-page.runtime.dev.js
  • app-page.runtime.prod.js
  • pages-api-tu..time.prod.js
  • pages-turbo...time.prod.js
  • server.runtime.prod.js
View diffs
app-page-exp..ntime.dev.js 
failed to diff
app-page-exp..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page-tur..ntime.dev.js 
failed to diff
app-page-tur..time.prod.js

Diff too large to display

app-page.runtime.dev.js 
failed to diff
app-page.runtime.prod.js

Diff too large to display

pages-api-tu..time.prod.js

Diff too large to display

pages-turbo...time.prod.js

Diff too large to display

server.runtime.prod.js

Diff too large to display

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 21, 2026 •
edited
Loading

Tests Passed

@mischnic mischnic force-pushed the mischnic/cleanup-contexts branch from 17cbfdd to d90c506 Compare January 22, 2026 15:57
@mischnic mischnic changed the title Refactor to read build and deployment id from renderOpts instead Remove deploymentId from App Router RenderOptsPartial Jan 22, 2026
@mischnic mischnic requested a review from wyattjoh January 22, 2026 16:07
@mischnic mischnic enabled auto-merge (squash) January 22, 2026 16:08
@mischnic mischnic merged commit 6632b90 into canary Jan 22, 2026
161 checks passed
@mischnic mischnic deleted the mischnic/cleanup-contexts branch January 22, 2026 16:30
eps1lon
eps1lon reviewed Jan 22, 2026
View reviewed changes
packages/next/src/server/render.tsx
Comment on lines 307 to +309
* The deployment ID if the user is deploying to a platform that provides one.
*/
deploymentId: string | undefined
deploymentId: string
Copy link
Member

@eps1lon eps1lon Jan 22, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that JSDoc still make sense? What's the expected value/type if the platform doesn't provide a deployment ID?

Copy link
Member Author

@mischnic mischnic Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 90% of the codebase, it's represented as an empty string in that case.

next.js/packages/next/src/server/base-server.ts

Lines 466 to 468 in 9e97759

} else {
let id = this.nextConfig.experimental.useSkewCookie
? ''

Ideally, we'd make it consistently use string | undefined everywhere as opposed to "string or empty string"

@github-actions github-actions bot added the locked label Feb 6, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@eps1lon eps1lon eps1lon left review comments

@vercel vercel[bot] vercel[bot] left review comments

@lukesandberg lukesandberg lukesandberg approved these changes

+1 more reviewer

@wyattjoh wyattjoh wyattjoh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mischnic @nextjs-bot @lukesandberg @wyattjoh @eps1lon