Skip to content

Turbopack: remove deployment id suffix from client reference manifest chunks#88741

Merged
mischnic merged 9 commits intocanaryfrom
mischnic/remove-id-from-client-ref-manifest
Jan 20, 2026
Merged

Turbopack: remove deployment id suffix from client reference manifest chunks#88741
mischnic merged 9 commits intocanaryfrom
mischnic/remove-id-from-client-ref-manifest

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Jan 19, 2026 •
edited
Loading

Closes PACK-6539

When experimental.runtimeServerDeploymentId is enabled, read the process.env.NEXT_DEPLOYMENT_ID and append to the chunks when evaluating the client-reference-manifest.js

Originally, I tried to do it after the manifest is loaded (in loadComponents or in the RouteModule.prepare) to "hydrate" the manifest, but that is too late because the manifest needs to be initialized immediately to make module-evaluation-time server actions work (which need the manifest immediately)

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. type: next labels Jan 19, 2026
@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 19, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic force-pushed the mischnic/remove-id-from-client-ref-manifest branch from ad8426f to 72e490b Compare January 19, 2026 14:27
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 19, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing mischnic/remove-id-from-client-ref-manifest (7a3b794) with canary (363783d)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

vercel[bot]
vercel bot reviewed Jan 19, 2026
View reviewed changes
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 19, 2026 •
edited
Loading

Tests Passed

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 19, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 453ms 448ms ✓ ▇█▇█▇
Cold (First Request) 871ms 873ms ✓ ▇███▇
Warm (Listen) 455ms 455ms ✓ ▅██▅▅
Warm (Ready in log) 447ms 454ms ✓ ▁▁▂▂▁
Warm (First Request) 356ms 361ms ✓ ▂▁▁█▅
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Cold (Ready in log) 439ms 439ms ✓ ▄▂▄▅▅
Cold (First Request) 1.816s 1.809s ✓ ▄█▅▆▅
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁▁
Warm (Ready in log) 439ms 439ms ✓ ▅▃▅▆▆
Warm (First Request) 1.821s 1.826s ✓ ▄█▅▅▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.653s 4.636s ✓ ▂▁▁▁▂
Cached Build 4.660s 4.653s ✓ ▂▂▁▂▂
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.350s 14.356s ✓ ▁█▂▂▁
Cached Build 14.446s 14.419s ✓ ▁█▂▂▂
node_modules Size 459 MB 459 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -96 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 762 B 765 B ✓
Total 762 B 765 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 448 B 451 B ✓
Total 448 B 451 B ⚠️ +3 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.4 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ✅ -3 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 243 kB 238 kB 🟢 4.85 kB (-2%)
Total 368 kB 363 kB ✅ -4.85 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 617 B 617 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.9 kB ⚠️ +161 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.67 MB 🔴 +6.51 kB (+0%)
index.pack gzip 99.5 kB 99.6 kB ✓
index.pack.old gzip 99.1 kB 100 kB 🔴 +1 kB (+1%)
Total 3.86 MB 3.87 MB ⚠️ +7.62 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 305 kB 305 kB ✓
app-page-exp..prod.js gzip 162 kB 162 kB ✓
app-page-tur...dev.js gzip 305 kB 305 kB ✓
app-page-tur..prod.js gzip 162 kB 162 kB ✓
app-page-tur...dev.js gzip 301 kB 301 kB ✓
app-page-tur..prod.js gzip 160 kB 160 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 160 kB 160 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.4 kB 47.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.71 MB 2.71 MB ✅ -1 B

@mischnic mischnic force-pushed the mischnic/remove-id-from-client-ref-manifest branch 5 times, most recently from 577609d to 5dde6f9 Compare January 20, 2026 09:35
@mischnic mischnic force-pushed the mischnic/remove-id-from-client-ref-manifest branch from 5dde6f9 to e8783f3 Compare January 20, 2026 10:23
@mischnic mischnic marked this pull request as ready for review January 20, 2026 11:34
@mischnic mischnic changed the title Remove id suffix from client reference manifest chunks Remove deployment id suffix from client reference manifest chunks Jan 20, 2026
@mischnic mischnic requested review from sokra and timneutkens January 20, 2026 11:44
sokra
sokra reviewed Jan 20, 2026
View reviewed changes
@mischnic mischnic changed the title Remove deployment id suffix from client reference manifest chunks Turbopack: remove deployment id suffix from client reference manifest chunks Jan 20, 2026
@mischnic mischnic merged commit eb14325 into canary Jan 20, 2026
285 of 288 checks passed
@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 20, 2026

Merge activity

@mischnic mischnic deleted the mischnic/remove-id-from-client-ref-manifest branch January 20, 2026 15:11
@mischnic mischnic mentioned this pull request Jan 20, 2026
Merged
@github-actions github-actions bot added the locked label Feb 4, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@sokra sokra sokra approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @nextjs-bot @sokra