Skip to content

Turbopack: don't use build id for pages router client-side manifests#88641

Merged
mischnic merged 8 commits intocanaryfrom
mischnic/build-id
Jan 19, 2026
Merged

Turbopack: don't use build id for pages router client-side manifests#88641
mischnic merged 8 commits intocanaryfrom
mischnic/build-id

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Jan 16, 2026 •
edited
Loading

Goes from

/_next/static/THE_BUILD_ID/_buildManifest.js?dpl=123
/_next/static/THE_BUILD_ID/_ssgManifest.js?dpl=123
/_next/static/THE_BUILD_ID/_clientMiddlewareManifest.js?dpl=123

to

/_next/static/_buildManifest.js?dpl=123
/_next/static/_ssgManifest.js?dpl=123
/_next/static/_clientMiddlewareManifest.js?dpl=123

if skew protection is enabled. This makes the build-manifest.json not depend on the build id

Closes PACK-6535

@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 16, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@mischnic mischnic mentioned this pull request Jan 16, 2026
Merged
2 tasks
@mischnic mischnic changed the title Remove buildId from path of _ssgManifest and _buildManifest Turbopack: don't use build id for pages router manifests Jan 16, 2026
@mischnic mischnic changed the title Turbopack: don't use build id for pages router manifests Turbopack: don't use build id for client-side manifests Jan 16, 2026
vercel[bot]
vercel bot reviewed Jan 16, 2026
View reviewed changes
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 16, 2026 •
edited
Loading

Tests Passed

@mischnic mischnic force-pushed the mischnic/build-id branch 2 times, most recently from dc3f361 to 1a3b053 Compare January 16, 2026 16:21
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 16, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 441ms 440ms ✓ ▁▁▁▁▁
Cold (First Request) 828ms 835ms ✓ ▃▃▁▃▃
Warm (Listen) 457ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 441ms 440ms ✓ ▁▁▁▁▁
Warm (First Request) 344ms 341ms ✓ ▁▂▁▂▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ █▁▁▁▁
Cold (Ready in log) 439ms 437ms ✓ ▅▇▇▇▇
Cold (First Request) 1.814s 1.808s ✓ ▅▅▅▅▅
Warm (Listen) 456ms 456ms ✓ █▁▁▁▁
Warm (Ready in log) 437ms 437ms ✓ ▅▅▅█▅
Warm (First Request) 1.820s 1.821s ✓ ▆▅▅▆▄

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.310s 4.267s ✓ ▁▁▂▁▁
Cached Build 4.343s 4.290s ✓ ▁▁▂▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.862s 13.843s ✓ █▂▂▂▁
Cached Build 14.060s 14.076s ✓ █▁▂▂▁
node_modules Size 458 MB 458 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **430 kB** → **430 kB** ✅ -41 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 789 B 764 B 🟢 25 B (-3%)
Total 789 B 764 B ✅ -25 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 449 B 449 B ✓
Total 449 B 449 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.3 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB 🔴 +455 B (+1%)
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 51.9 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 225 kB ⚠️ +65 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 243 kB 238 kB 🟢 4.93 kB (-2%)
Total 368 kB 363 kB ✅ -4.92 kB
Middleware
Canary PR Change
middleware-b..fest.js gzip 653 B 618 B 🟢 35 B (-5%)
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.8 kB 34.9 kB ⚠️ +90 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.67 MB 🔴 +4.87 kB (+0%)
index.pack gzip 99 kB 100 kB ✓
index.pack.old gzip 101 kB 99.6 kB 🟢 1.32 kB (-1%)
Total 3.86 MB 3.86 MB ⚠️ +4.52 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 300 kB 300 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.4 kB 47.4 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ✓

@mischnic mischnic force-pushed the mischnic/build-id branch 4 times, most recently from 870fc4e to 6d32b3f Compare January 16, 2026 20:41
@mischnic mischnic force-pushed the mischnic/static-deployment-id branch from 1ca7a3a to 31f10c6 Compare January 19, 2026 09:21
@mischnic mischnic force-pushed the mischnic/build-id branch 4 times, most recently from e49766e to e9fb9ba Compare January 19, 2026 11:45
@mischnic mischnic marked this pull request as ready for review January 19, 2026 11:48
@mischnic mischnic requested a review from timneutkens January 19, 2026 11:49
@mischnic mischnic changed the title Turbopack: don't use build id for client-side manifests Turbopack: don't use build id for pages router client-side manifests Jan 19, 2026
@mischnic mischnic changed the base branch from mischnic/static-deployment-id to graphite-base/88641 January 19, 2026 13:16
@mischnic mischnic force-pushed the graphite-base/88641 branch from 31f10c6 to b46d599 Compare January 19, 2026 13:16
@mischnic mischnic changed the base branch from graphite-base/88641 to canary January 19, 2026 13:16
@mischnic mischnic merged commit a1ba3d4 into canary Jan 19, 2026
161 checks passed
@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 19, 2026

Merge activity

@mischnic mischnic deleted the mischnic/build-id branch January 19, 2026 14:42
@mischnic mischnic mentioned this pull request Jan 20, 2026
Merged
mischnic added a commit that referenced this pull request Jan 20, 2026
@mischnic
Fix buildManifest.js deployment tests (#88806)
e5926d3 
When `NEXT_DEPLOYMENT_ID` is set (and thus skew protection is enabled), then these pages router manifests are actually on a different path (so that the output paths doesn't change with the build id anymore)

Fixup for #88641
@mischnic mischnic mentioned this pull request Jan 20, 2026
Merged
@github-actions github-actions bot added the locked label Feb 3, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@timneutkens timneutkens timneutkens approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mischnic @nextjs-bot @timneutkens