Skip to content

[turbopack] Move some of the logic for issue filtering into the rust layer #88511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lukesandberg merged 2 commits into from
Jan 14, 2026
Merged

[turbopack] Move some of the logic for issue filtering into the rust layer #88511

lukesandberg merged 2 commits into from
Jan 14, 2026

Conversation

@lukesandberg
Copy link
Contributor

@lukesandberg lukesandberg commented Jan 14, 2026 •
edited
Loading

Optimize issue filtering in Next.js and Turbopack

What?

This PR introduces an IssueFilter system to control which issues are reported based on severity and location

Why?

To improve performance, we shouldn't spend time formatting issues that will never be displayed to a user.

How?

  • Added IssueFilter to control which issues are displayed based on severity and location
  • Created a specialized InNodeModules context condition for better readability
  • Implemented warnings_and_foreign_errors() filter that shows:
    • Warnings and errors from application code
    • Only errors from node_modules
  • Applied the filter throughout Next.js and Turbopack's issue reporting system
  • Refactored issue collection to filter early rather than collecting everything first

@lukesandberg
Move some of the logic for issue filtering into the rust layer
4f45b02 
Today turbopack reports a lot of warnings about code in node_modules that is never displayed to users due to filtering logic in packages/next/src/server/dev/turbopack-utils.ts

This implements similar logic in rust prior to formatting which should save lots of redundant work tracking import traces and serializing issues across napi that are never displayed to a user.
@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 14, 2026
@lukesandberg lukesandberg changed the title Move some of the logic for issue filtering into the rust layer [turbopack[ Move some of the logic for issue filtering into the rust layer Jan 14, 2026
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 14, 2026

Allow CI Workflow Run

  • approve CI run for commit: 4f45b02

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@lukesandberg Graphite App
Copy link
Contributor Author

lukesandberg commented Jan 14, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@lukesandberg lukesandberg changed the title [turbopack[ Move some of the logic for issue filtering into the rust layer [turbopack] Move some of the logic for issue filtering into the rust layer Jan 14, 2026
@lukesandberg lukesandberg marked this pull request as ready for review January 14, 2026 01:17
@lukesandberg lukesandberg requested a review from a team January 14, 2026 01:18
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 14, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ ▁▁▁▁▁
Cold (Ready in log) 436ms 437ms ✓ ▁▂▂▂▂
Cold (First Request) 1.126s 1.093s ✓ ▁▄▄▄▄
Warm (Listen) 456ms 457ms ✓ ▁▁▁▁▁
Warm (Ready in log) 442ms 442ms ✓ ▁▁▁▁▁
Warm (First Request) 343ms 341ms ✓ ▁▁▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 456ms ✓ ▁▁▁▁█
Cold (Ready in log) 437ms 437ms ✓ ▃▄▁▄█
Cold (First Request) 1.817s 1.799s ✓ ▂▂▁▂█
Warm (Listen) 456ms 456ms ✓ ▁▁▁▁█
Warm (Ready in log) 436ms 436ms ✓ ▃▃▁▄█
Warm (First Request) 1.852s 1.815s ✓ ▂▂▁▂█

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.094s 4.043s ✓ ▁▁▁▁▁
Cached Build 4.024s 4.043s ✓ ▂▁▁▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 13.910s 13.968s ✓ ▁▁▁▁█
Cached Build 14.015s 13.980s ✓ ▁▁▁▁█
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ⚠️ +15 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 786 B 789 B ✓
Total 786 B 789 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 452 B ✓
Total 450 B 452 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +246 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 242 kB ✓
Total 366 kB 367 kB ⚠️ +484 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 653 B 653 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 34.9 kB ⚠️ +190 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.66 MB 3.67 MB 🔴 +7.97 kB (+0%)
index.pack gzip 99.6 kB 98.2 kB 🟢 1.4 kB (-1%)
index.pack.old gzip 101 kB 101 kB ✓
Total 3.87 MB 3.87 MB ⚠️ +6.47 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ✓

@codspeed-hq
Copy link

codspeed-hq bot commented Jan 14, 2026

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing filter_issues_in_rust_to_avoid_expensive_formatting_for_filtered_issues (699502f) with canary (e1c95fc)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@lukesandberg lukesandberg merged commit 9725c47 into canary Jan 14, 2026
166 checks passed
@lukesandberg lukesandberg deleted the filter_issues_in_rust_to_avoid_expensive_formatting_for_filtered_issues branch January 14, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mischnic mischnic mischnic approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lukesandberg @nextjs-bot @mischnic