Skip to content

Turbopack: improve cell order lint rule #88498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mischnic merged 1 commit into from
Jan 13, 2026
Merged

Turbopack: improve cell order lint rule #88498

mischnic merged 1 commit into from
Jan 13, 2026

Conversation

@mischnic
Copy link
Contributor

@mischnic mischnic commented Jan 13, 2026 •
edited
Loading

Addresses the comments on this PR: #88474 (comment)

"Merge when ready" had striked again

This did actually find another violation

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 13, 2026
@mischnic mischnic requested a review from bgw January 13, 2026 18:56
@mischnic Graphite App
Copy link
Contributor Author

mischnic commented Jan 13, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026

Allow CI Workflow Run

  • approve CI run for commit: 80c0f4c

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@mischnic mischnic marked this pull request as ready for review January 13, 2026 18:56
@mischnic mischnic mentioned this pull request Jan 13, 2026
Open
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 456ms ✓ ▁█▁▁▁
Cold (Ready in log) 437ms 437ms ✓ ▁█▁▂▂
Cold (First Request) 1.124s 1.130s ✓ ▂█▁▄▄
Warm (Listen) 456ms 457ms ✓ ▁█▁▁▁
Warm (Ready in log) 442ms 441ms ✓ ▁█▁▁▁
Warm (First Request) 337ms 334ms ✓ ▁█▁▁▁
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▁▁▁▁▅
Cold (Ready in log) 440ms 439ms ✓ ▄▅▅▇▁
Cold (First Request) 1.855s 1.843s ✓ ▄▆▇█▁
Warm (Listen) 456ms 456ms ✓ ███▁█
Warm (Ready in log) 439ms 441ms ✓ ▅▇▇█▁
Warm (First Request) 1.851s 1.856s ✓ ▃▆▆▇▁

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 3.977s 4.011s ✓ ▃█▁▁▁
Cached Build 3.997s 3.988s ✓ ▃█▂▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.049s 14.054s ✓ ▁▃▂▃▃
Cached Build 14.135s 14.118s ✓ ▁▃▃▂▂
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ✅ -7 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 789 B 792 B ✓
Total 789 B 792 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 450 B ✓
Total 450 B 450 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +245 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 242 kB ✓
Total 366 kB 367 kB ⚠️ +468 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 654 B 653 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.3 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.8 kB 34.9 kB ⚠️ +137 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.67 MB 3.67 MB ✓
index.pack gzip 99.7 kB 100 kB ✓
index.pack.old gzip 99.8 kB 100 kB ✓
Total 3.87 MB 3.87 MB ⚠️ +1.83 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ⚠️ +4 B

@mischnic mischnic merged commit 6ed4453 into canary Jan 13, 2026
166 of 170 checks passed
@mischnic mischnic deleted the mischnic/improve-lint branch January 13, 2026 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesandberg lukesandberg lukesandberg approved these changes

@bgw bgw Awaiting requested review from bgw

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mischnic @nextjs-bot @lukesandberg