Skip to content

Turbopack: retain loader tree order for metadata#88487

Merged
mischnic merged 5 commits intocanaryfrom
mischnic/chunk-name-collision
Jan 14, 2026
Merged

Turbopack: retain loader tree order for metadata#88487
mischnic merged 5 commits intocanaryfrom
mischnic/chunk-name-collision

Conversation

@mischnic
Copy link
Member

@mischnic mischnic commented Jan 13, 2026 •
edited
Loading

This appears to basically be a regression from #83115

Closes #87322

The app-page template was looking like this, cause the METADATA imports to be hoisted before the other ones:

const __TURBOPACK__layout__$23$0__ = () => require("MODULE_0");
const __TURBOPACK__not$2d$found__$23$1__ = () => require("MODULE_1");
const __TURBOPACK__forbidden__$23$2__ = () => require("MODULE_2");
const __TURBOPACK__unauthorized__$23$3__ = () => require("MODULE_3");
const __TURBOPACK__global$2d$error__$23$4__ = () => require("MODULE_4");
import __TURBOPACK__openGraph__$23$5__ from "METADATA_5";
const __TURBOPACK__layout__$23$6__ = () => require("MODULE_6");
import __TURBOPACK__openGraph__$23$7__ from "METADATA_7";
const __TURBOPACK__page__$23$8__ = () => require("MODULE_8");
import { AppPageRouteModule } from "next/dist/esm/server/route-modules/app-page/module.compiled" with {
    'turbopack-transition': 'next-ssr'
};

Now, they all use require. This way, the way we detect the layout segments actually corresponds to the loader tree order (e.g. layout, not-found, layout, opengraph, page)

const __TURBOPACK__layout__$23$0__ = () => require("MODULE_0");
const __TURBOPACK__not$2d$found__$23$1__ = () => require("MODULE_1");
const __TURBOPACK__forbidden__$23$2__ = () => require("MODULE_2");
const __TURBOPACK__unauthorized__$23$3__ = () => require("MODULE_3");
const __TURBOPACK__global$2d$error__$23$4__ = () => require("MODULE_4");
const __TURBOPACK__openGraph__$23$5__ = require("METADATA_5");
const __TURBOPACK__layout__$23$6__ = () => require("MODULE_6");
const __TURBOPACK__openGraph__$23$7__ = require("METADATA_7");
const __TURBOPACK__page__$23$8__ = () => require("MODULE_8");
import { AppPageRouteModule } from "next/dist/esm/server/route-modules/app-page/module.compiled" with {
    'turbopack-transition': 'next-ssr'
};

This was causing problems where client reference chunking was using the wrong orders, causing chunk name collisions, e.g.

/a/page
1. node_modules/next/dist/client/components/builtin/global-error.js [app-rsc] (ecmascript, Next.js Server Component, client modules)

/b/page:
1. [project]/app/b/opengraph-image--metadata.js [app-rsc] (ecmascript, Next.js Server Component, client modules)
2. node_modules/next/dist/client/components/builtin/global-error.js [app-rsc] (ecmascript, Next.js Server Component, client modules)

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. type: next labels Jan 13, 2026
@mischnic mischnic changed the title wip Turbopack: retain loader tree order for metadata Jan 13, 2026
@mischnic Graphite App
Copy link
Member Author

mischnic commented Jan 13, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026 •
edited
Loading

Allow CI Workflow Run

  • approve CI run for commit: e833b0d

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

vercel[bot]
vercel bot reviewed Jan 13, 2026
View reviewed changes
crates/next-api/src/app.rs
rcstr!("next-server-utility"),
ResolvedVc::upcast(NextServerUtilityTransition::new().to_resolved().await?),
),
(
Copy link
Contributor

@vercel vercel bot Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GlobalError import was changed to use 'next-server-component' transition (merge_tag: None) instead of 'next-server-utility' transition (merge_tag: Some), preventing chunk merging and potentially causing unnecessary code duplication.

Fix on Vercel

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026 •
edited
Loading

Failing test suites

Commit: 5d70ae5 | About building and testing Next.js

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 507ms 506ms ✓ ▁▁▁█▁
Cold (Ready in log) 471ms 466ms ✓ ▂▁▁█▁
Cold (First Request) 933ms 915ms ✓ ▄▁▂█▁
Warm (Listen) 509ms 507ms ✓ ▁▁▁█▁
Warm (Ready in log) 466ms 467ms ✓ ▁▁▁█▁
Warm (First Request) 337ms 341ms ✓ ▂▁▁█▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 456ms 455ms ✓ ▅▁▁▁▁
Cold (Ready in log) 439ms 439ms ✓ ▆▇▅▆▆
Cold (First Request) 1.822s 1.835s ✓ ▇█▆▇█
Warm (Listen) 455ms 455ms ✓ █████
Warm (Ready in log) 439ms 440ms ✓ ▇█▆██
Warm (First Request) 1.841s 1.851s ✓ ▆▇▅▇▇

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.678s 4.724s ✓ ▁▁▂█▁
Cached Build 4.687s 4.712s ✓ ▁▁▂█▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 14.039s 14.059s ✓ ▃▃▁▃▂
Cached Build 14.153s 14.143s ✓ ▃▃▁▃▃
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ✅ -7 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 789 B 792 B ✓
Total 789 B 792 B ⚠️ +3 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 450 B 450 B ✓
Total 450 B 450 B ✓

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +245 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 242 kB ✓
Total 366 kB 367 kB ⚠️ +469 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 653 B 653 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.1 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.8 kB 34.9 kB ⚠️ +135 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.67 MB 3.67 MB 🔴 +5.12 kB (+0%)
index.pack gzip 102 kB 101 kB ✓
index.pack.old gzip 100 kB 98.2 kB 🟢 1.94 kB (-2%)
Total 3.87 MB 3.87 MB ⚠️ +2.71 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.7 kB 50.7 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ✅ -1 B

@mischnic mischnic force-pushed the mischnic/chunk-name-collision branch from e833b0d to 46adced Compare January 13, 2026 23:04
@codspeed-hq
Copy link

codspeed-hq bot commented Jan 13, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 17 untouched benchmarks
⏩ 3 skipped benchmarks1

Comparing mischnic/chunk-name-collision (5d70ae5) with canary (e1c95fc)

Open in CodSpeed

Footnotes

  1. 3 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@mischnic mischnic marked this pull request as ready for review January 14, 2026 09:13
@mischnic mischnic requested a review from a team January 14, 2026 09:13
@mischnic mischnic merged commit b54f875 into canary Jan 14, 2026
289 of 301 checks passed
@mischnic mischnic deleted the mischnic/chunk-name-collision branch January 14, 2026 09:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@vercel vercel[bot] vercel[bot] left review comments

@sokra sokra sokra approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. locked tests Turbopack Related to Turbopack with Next.js. type: next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Infinite "Compiling" loop with opengraph-image.tsx and Turbopack (Next.js 16)

3 participants

@mischnic @nextjs-bot @sokra