Skip to content

Turbopack: Reduce usage of parse_quote in turbo-tasks-macros #88454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bgw merged 1 commit into from
Jan 13, 2026
Merged

Turbopack: Reduce usage of parse_quote in turbo-tasks-macros #88454

bgw merged 1 commit into from
Jan 13, 2026

Conversation

@bgw
Copy link
Member

@bgw bgw commented Jan 13, 2026 •
edited
Loading

In theory, parse_quote is really nice because it lets you use type safety to assert more things about proc macro code.

However, it does invoke the syn parser, so there's probably some cost.

I had Claude find and remove trivial uses of parse_quote. There are still more uses, but they're not as easy to remove (e.g. because we need the real type, not just a TokenStream, and the type is annoying to construct by hand).

@nextjs-bot nextjs-bot added created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js. labels Jan 13, 2026
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 13, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026

Allow CI Workflow Run

  • approve CI run for commit: d1f5f02

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

1 similar comment
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026

Allow CI Workflow Run

  • approve CI run for commit: d1f5f02

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

@bgw bgw requested a review from a team January 13, 2026 00:44
@bgw bgw marked this pull request as ready for review January 13, 2026 00:44
@bgw bgw mentioned this pull request Jan 13, 2026
Merged
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 13, 2026

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 455ms ✓ █▁▁▁█
Cold (Ready in log) 439ms 439ms ✓ ▃▆▆▃▅
Cold (First Request) 1.168s 1.158s ✓ ▁██▂▃
Warm (Listen) 457ms 457ms ✓ █▁▁██
Warm (Ready in log) 443ms 443ms ✓ ▆▁▁▆█
Warm (First Request) 345ms 342ms ✓ ▆▁█▆▆
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 507ms 508ms ✓ ▁▁▅▁▁
Cold (Ready in log) 493ms 494ms ✓ ▆▆▆▇▅
Cold (First Request) 2.118s 2.128s ✓ █▆▇█▆
Warm (Listen) 508ms 507ms ✓ █▁███
Warm (Ready in log) 493ms 496ms ✓ █▇▇█▆
Warm (First Request) 2.171s 2.147s ✓ ▇▆▆▇▅

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.075s 4.093s ✓ ▄▁▁▄█
Cached Build 4.111s 4.086s ✓ ▃▁▂▄█
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 16.341s 16.203s ✓ ▄▁▃▃▁
Cached Build 16.320s 16.254s ✓ ▄▁▃▃▁
node_modules Size 458 MB 458 MB ✓ ▁▁▁▁▁
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ✅ -14 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 783 B 790 B ✓
Total 783 B 790 B ⚠️ +7 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 451 B 449 B ✓
Total 451 B 449 B ✅ -2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +245 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 242 kB 242 kB ✓
Total 367 kB 367 kB ⚠️ +499 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 654 B 654 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33.2 kB 33.2 kB ✓
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.8 kB 34.9 kB ⚠️ +78 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.67 MB 3.68 MB 🔴 +5.43 kB (+0%)
index.pack gzip 99.6 kB 101 kB ✓
index.pack.old gzip 100 kB 100 kB ✓
Total 3.87 MB 3.88 MB ⚠️ +6.33 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 301 kB 301 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-ex..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.4 kB 47.4 kB ✓
app-route.ru...dev.js gzip 68.4 kB 68.4 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.2 kB 41.2 kB ✓
pages-api-tu..prod.js gzip 31.3 kB 31.3 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.9 kB 50.9 kB ✓
pages-turbo...prod.js gzip 38.3 kB 38.3 kB ✓
pages.runtim...dev.js gzip 50.8 kB 50.8 kB ✓
pages.runtim..prod.js gzip 38.3 kB 38.3 kB ✓
server.runti..prod.js gzip 62.3 kB 62.3 kB ✓
Total 2.69 MB 2.69 MB ⚠️ +1 B

@bgw bgw mentioned this pull request Jan 13, 2026
Merged
@bgw Graphite App
Copy link
Member Author

bgw commented Jan 13, 2026 •
edited
Loading

Merge activity

  • Jan 13, 6:01 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 13, 6:02 PM UTC: @bgw merged this pull request with Graphite.

@bgw bgw merged commit a6371dd into canary Jan 13, 2026
165 of 169 checks passed
@bgw bgw deleted the bgw/rm-parse-quote branch January 13, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesandberg lukesandberg lukesandberg approved these changes

Assignees

No one assigned

Labels

created-by: Turbopack team PRs by the Turbopack team. Turbopack Related to Turbopack with Next.js.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bgw @nextjs-bot @lukesandberg