Skip to content

Type-check run-tests.js and remove unused related flag #88433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
unstubbable merged 1 commit into from
Jan 12, 2026
Merged

Type-check run-tests.js and remove unused related flag #88433

unstubbable merged 1 commit into from
Jan 12, 2026
+29 −36

Conversation

@unstubbable
Copy link
Contributor

@unstubbable unstubbable commented Jan 12, 2026 •
edited
Loading

The file already had the @ts-check directive, so the IDE did show errors in that file. But since it was not included in the root tsconfig.json, those errors were not reported during CI runs.

One issue found this way was that the related flag was defined but never used. The referenced script was removed in #67644.

@nextjs-bot nextjs-bot added created-by: Next.js team PRs by the Next.js team. tests labels Jan 12, 2026
@unstubbable Graphite App
Copy link
Contributor Author

unstubbable commented Jan 12, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 12, 2026
Merged
Merged
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026 •
edited
Loading

Stats from current PR

✅ No significant changes detected

📊 All Metrics
📖 Metrics Glossary

Dev Server Metrics:

  • Listen = TCP port starts accepting connections
  • First Request = HTTP server returns successful response
  • Cold = Fresh build (no cache)
  • Warm = With cached build artifacts

Build Metrics:

  • Fresh = Clean build (no .next directory)
  • Cached = With existing .next directory

Change Thresholds:

  • Time: Changes < 50ms AND < 10%, OR < 2% are insignificant
  • Size: Changes < 1KB AND < 1% are insignificant
  • All other changes are flagged to catch regressions

⚡ Dev Server

Metric Canary PR Change Trend
Cold (Listen) 455ms 454ms ✓ ▁█▁▁▁
Cold (Ready in log) 438ms 439ms ✓ █▅▇█▇
Cold (First Request) 1.132s 1.147s ✓ █▃█▇█
Warm (Listen) 457ms 457ms ✓ ▁█▁▁▁
Warm (Ready in log) 443ms 443ms ✓ ▁█▁▁▁
Warm (First Request) 341ms 343ms ✓ ▁▆▂▂▂
📦 Dev Server (Webpack) (Legacy)

📦 Dev Server (Webpack)

Metric Canary PR Change Trend
Cold (Listen) 507ms 508ms ✓ ▁▁█▅▁
Cold (Ready in log) 467ms 464ms ✓ ▁▇▅██
Cold (First Request) 1.911s 1.929s ✓ ▁▄▅▅▆
Warm (Listen) 508ms 507ms ✓ ▁████
Warm (Ready in log) 465ms 464ms ✓ ▁█▄██
Warm (First Request) 1.941s 1.916s ✓ ▁▇▅▅▇

⚡ Production Builds

Metric Canary PR Change Trend
Fresh Build 4.087s 4.081s ✓ ▂█▂▁▁
Cached Build 4.092s 4.139s ✓ ▂█▂▁▁
📦 Production Builds (Webpack) (Legacy)

📦 Production Builds (Webpack)

Metric Canary PR Change Trend
Fresh Build 15.096s 15.036s ✓ ▁▂▆▁▃
Cached Build 15.139s 15.034s ✓ ▁▂▆▁▃
node_modules Size 458 MB 458 MB ✓ █████
📦 Bundle Sizes

Bundle Sizes

⚡ Turbopack

Client

Main Bundles: **431 kB** → **431 kB** ✅ -10 B

82 files with content-based hashes (individual files not comparable between builds)

Server

Middleware
Canary PR Change
middleware-b..fest.js gzip 787 B 791 B ✓
Total 787 B 791 B ⚠️ +4 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 449 B 451 B ✓
Total 449 B 451 B ⚠️ +2 B

📦 Webpack

Client

Main Bundles
Canary PR Change
2086.HASH.js gzip 169 B N/A -
2161-HASH.js gzip 5.41 kB N/A -
2747-HASH.js gzip 4.48 kB N/A -
4322-HASH.js gzip 52.8 kB N/A -
ec793fe8-HASH.js gzip 62.3 kB N/A -
framework-HASH.js gzip 59.8 kB 59.8 kB ✓
main-app-HASH.js gzip 251 B 254 B 🔴 +3 B (+1%)
main-HASH.js gzip 38.6 kB 39 kB ✓
webpack-HASH.js gzip 1.68 kB 1.68 kB ✓
1596.HASH.js gzip N/A 169 B -
2658-HASH.js gzip N/A 52.7 kB -
6349-HASH.js gzip N/A 4.46 kB -
7019-HASH.js gzip N/A 5.43 kB -
b17a3386-HASH.js gzip N/A 62.3 kB -
Total 225 kB 226 kB ⚠️ +245 B
Polyfills
Canary PR Change
polyfills-HASH.js gzip 39.4 kB 39.4 kB ✓
Total 39.4 kB 39.4 kB ✓
Pages
Canary PR Change
_app-HASH.js gzip 194 B 193 B ✓
_error-HASH.js gzip 182 B 182 B ✓
css-HASH.js gzip 336 B 335 B ✓
dynamic-HASH.js gzip 1.8 kB 1.8 kB ✓
edge-ssr-HASH.js gzip 256 B 256 B ✓
head-HASH.js gzip 352 B 349 B ✓
hooks-HASH.js gzip 385 B 384 B ✓
image-HASH.js gzip 580 B 580 B ✓
index-HASH.js gzip 259 B 258 B ✓
link-HASH.js gzip 2.5 kB 2.51 kB ✓
routerDirect..HASH.js gzip 319 B 317 B ✓
script-HASH.js gzip 385 B 387 B ✓
withRouter-HASH.js gzip 316 B 315 B ✓
1afbb74e6ecf..834.css gzip 106 B 106 B ✓
Total 7.97 kB 7.96 kB ✅ -8 B

Server

Edge SSR
Canary PR Change
edge-ssr.js gzip 125 kB 125 kB ✓
page.js gzip 241 kB 242 kB ✓
Total 366 kB 367 kB ⚠️ +504 B
Middleware
Canary PR Change
middleware-b..fest.js gzip 655 B 653 B ✓
middleware-r..fest.js gzip 155 B 156 B ✓
middleware.js gzip 33 kB 33.3 kB 🔴 +341 B (+1%)
edge-runtime..pack.js gzip 842 B 842 B ✓
Total 34.7 kB 35 kB ⚠️ +340 B
Build Details
Build Manifests
Canary PR Change
_buildManifest.js gzip 738 B 738 B ✓
Total 738 B 738 B ✓
Build Cache
Canary PR Change
0.pack gzip 3.64 MB 3.65 MB 🔴 +9.65 kB (+0%)
index.pack gzip 99.2 kB 100 kB 🔴 +1.22 kB (+1%)
index.pack.old gzip 99.5 kB 100 kB ✓
Total 3.84 MB 3.85 MB ⚠️ +11.4 kB

🔄 Shared (bundler-independent)

Runtimes
Canary PR Change
app-page-exp...dev.js gzip 304 kB 304 kB ✓
app-page-exp..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 304 kB 304 kB ✓
app-page-tur..prod.js gzip 158 kB 158 kB ✓
app-page-tur...dev.js gzip 300 kB 300 kB ✓
app-page-tur..prod.js gzip 156 kB 156 kB ✓
app-page.run...dev.js gzip 300 kB 300 kB ✓
app-page.run..prod.js gzip 156 kB 156 kB ✓
app-route-ex...dev.js gzip 68.7 kB 68.7 kB ✓
app-route-ex..prod.js gzip 47.5 kB 47.5 kB ✓
app-route-tu...dev.js gzip 68.8 kB 68.8 kB ✓
app-route-tu..prod.js gzip 47.6 kB 47.6 kB ✓
app-route-tu...dev.js gzip 68.4 kB 68.4 kB ✓
app-route-tu..prod.js gzip 47.3 kB 47.3 kB ✓
app-route.ru...dev.js gzip 68.3 kB 68.3 kB ✓
app-route.ru..prod.js gzip 47.3 kB 47.3 kB ✓
dist_client_...dev.js gzip 324 B 324 B ✓
dist_client_...dev.js gzip 326 B 326 B ✓
dist_client_...dev.js gzip 318 B 318 B ✓
dist_client_...dev.js gzip 317 B 317 B ✓
pages-api-tu...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api-tu..prod.js gzip 31.2 kB 31.2 kB ✓
pages-api.ru...dev.js gzip 41.1 kB 41.1 kB ✓
pages-api.ru..prod.js gzip 31.2 kB 31.2 kB ✓
pages-turbo....dev.js gzip 50.8 kB 50.8 kB ✓
pages-turbo...prod.js gzip 38.2 kB 38.2 kB ✓
pages.runtim...dev.js gzip 50.8 kB 50.8 kB ✓
pages.runtim..prod.js gzip 38.2 kB 38.2 kB ✓
server.runti..prod.js gzip 62.2 kB 62.2 kB ✓
Total 2.69 MB 2.69 MB ⚠️ +1 B
📝 Changed Files (2 files)

Files with changes:

  • pages-api.ru..time.prod.js
  • pages.runtime.prod.js
View diffs
pages-api.ru..time.prod.js

Diff too large to display

pages.runtime.prod.js

Diff too large to display

@unstubbable
Type-check run-tests.js and remove unused related flag
939ac92 
The file already had the `@ts-check` directive, so the IDE did show
errors in that file. But since it was not included in the root
`tsconfig.json`, those errors were not reported during CI runs.

One issue found this way was that the `related` flag was defined but
never used. The referenced script was removed in #67644.
@unstubbable unstubbable force-pushed the hl/type-check-run-tests branch from 0df5b5c to 939ac92 Compare January 12, 2026 16:49
@nextjs-bot
Copy link
Collaborator

nextjs-bot commented Jan 12, 2026

Failing test suites

Commit: 939ac92 | About building and testing Next.js

pnpm test-start test/e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts (job)

  • runtime prefetching > cache stale time handling > omits short-lived public caches with a short enough staleTime (DD)
Expand output

● runtime prefetching › cache stale time handling › omits short-lived public caches with a short enough staleTime

thrown: "Exceeded timeout of 120000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."

  777 |     })
  778 |
> 779 |     it('omits short-lived public caches with a short enough staleTime', async () => {
      |     ^
  780 |       // If a cache has a stale time below 30s (RUNTIME_PREFETCH_DYNAMIC_STALE), we should omit it from runtime prefetches.
  781 |
  782 |       let page: Playwright.Page

  at it (e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts:779:5)
  at describe (e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts:715:3)
  at Object.describe (e2e/app-dir/segment-cache/prefetch-runtime/prefetch-runtime.test.ts:6:1)

@unstubbable unstubbable marked this pull request as ready for review January 12, 2026 17:48
@unstubbable unstubbable requested a review from eps1lon January 12, 2026 17:48
eps1lon
eps1lon reviewed Jan 12, 2026
View reviewed changes
@unstubbable Graphite App
Copy link
Contributor Author

unstubbable commented Jan 12, 2026 •
edited
Loading

Merge activity

  • Jan 12, 6:45 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 12, 6:46 PM UTC: @unstubbable merged this pull request with Graphite.

@unstubbable unstubbable merged commit 7a2f4ad into canary Jan 12, 2026
287 of 289 checks passed
@unstubbable unstubbable deleted the hl/type-check-run-tests branch January 12, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eps1lon eps1lon eps1lon approved these changes

Assignees

No one assigned

Labels

created-by: Next.js team PRs by the Next.js team. tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@unstubbable @nextjs-bot @eps1lon