fix: capture promisified setImmediate separately#88346
Merged
lubieowoce merged 1 commit intovercel:canaryfrom Jan 16, 2026
Merged
fix: capture promisified setImmediate separately#88346lubieowoce merged 1 commit intovercel:canaryfrom
lubieowoce merged 1 commit intovercel:canaryfrom
Conversation
Collaborator
|
Allow CI Workflow Run
Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer |
4b8ae56 to
2be5e32
Compare
lubieowoce
approved these changes
Jan 16, 2026
Member
|
huh, how weird. nice find, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Capture
setImmediate[promisify.custom]at module initialization instead of lazily accessing it when needed.This was discovered upgrading from
16.0.10to16.1.0Why?
When
util.promisify(setImmediate)is called andcurrentExecution === null, the code was accessingoriginalSetImmediate[promisify.custom]at call time. However,promisify.customcan get lost or returnundefinedafter the module patchessetImmediate, causingpromisify(setImmediate)to fail. Specifically, when used withjest.Reproduction: https://github.com/jgeschwendt/nextjs-setimmediate-promisify-repro
How?
Move the capture of
originalSetImmediate[promisify.custom]to module initialization time (alongsideoriginalSetImmediate,originalClearImmediate, andoriginalNextTick), ensuring the original promisified implementation is preserved before any patching occurs.